New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renaming: acrawriter -> acra-writer / AcraWriter & acraserver -> acra-server / AcraServer #169

Merged
merged 3 commits into from May 4, 2018

Conversation

Projects
None yet
3 participants
@vixentael
Member

vixentael commented May 3, 2018

Continue in renaming.

@vixentael vixentael requested review from Lagovas and shadinua May 3, 2018

@vixentael vixentael changed the base branch from master to rename May 3, 2018

@shadinua

Thank you for great job, there are a few small suggestions.

@@ -149,23 +149,23 @@ func main() {
keysDir := flag.String("keys_dir", keystore.DEFAULT_KEY_DIR_SHORT, "Folder from which will be loaded keys")
clientId := flag.String("client_id", "", "Client id")
acraHost := flag.String("acra_host", "", "IP or domain to acra daemon")
acraCommandsPort := flag.Int("acra_commands_port", cmd.DEFAULT_ACRA_API_PORT, "Port of acra http api")
acraCommandsPort := flag.Int("acra_commands_port", cmd.DEFAULT_ACRA_API_PORT, "Port of Acra HTTP api")

This comment has been minimized.

@shadinua

shadinua May 3, 2018

Contributor

Here and further we use the term Acra port for different instances: AcraServer and AcraConnector. It would be good to explicitly specify application. In this line, I think, should be AcraServer.

acraPort := flag.Int("acra_port", cmd.DEFAULT_ACRA_PORT, "Port of acra daemon")
acraId := flag.String("acra_id", "acra_server", "Expected id from acraserver for Secure Session")
acraId := flag.String("acra_id", "acra_server", "Expected id from AcraServer for Secure Session")
verbose := flag.Bool("v", false, "Log to stderr")
port := flag.Int("port", cmd.DEFAULT_CONNECTOR_PORT, "Port fo acra-connector")

This comment has been minimized.

@shadinua

shadinua May 3, 2018

Contributor

Please, correct: "Port to AcraConnector".
Also, I suggest to use the same way to describe components in messages: AcraServer or acra-server. If we're talking about application, let's use AcraServer. In case we mean the package or binary file, let's use acra-server.

@@ -149,23 +149,23 @@ func main() {
keysDir := flag.String("keys_dir", keystore.DEFAULT_KEY_DIR_SHORT, "Folder from which will be loaded keys")
clientId := flag.String("client_id", "", "Client id")
acraHost := flag.String("acra_host", "", "IP or domain to acra daemon")
acraCommandsPort := flag.Int("acra_commands_port", cmd.DEFAULT_ACRA_API_PORT, "Port of acra http api")
acraCommandsPort := flag.Int("acra_commands_port", cmd.DEFAULT_ACRA_API_PORT, "Port of Acra HTTP api")
acraPort := flag.Int("acra_port", cmd.DEFAULT_ACRA_PORT, "Port of acra daemon")

This comment has been minimized.

@shadinua

shadinua May 3, 2018

Contributor

Probably, we can rename cmd.DEFAULT_ACRA_PORTcmd.DEFAULT_ACRASERVER_PORT or cmd.DEFAULT_SERVER_PORT and so on?

This comment has been minimized.

@vixentael

vixentael May 3, 2018

Member

renamed constants, see in last commit

This comment has been minimized.

@vixentael

vixentael May 3, 2018

Member

we will rename arguments a bit later in a separate chunk of refactoring

@Lagovas

Lagovas approved these changes May 4, 2018

@vixentael vixentael merged commit bed2f02 into rename May 4, 2018

1 check passed

ci/circleci: x86_64 Your tests passed on CircleCI!
Details

@vixentael vixentael deleted the vixentael/T491-acraserverwriter branch May 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment