Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible memory leak in soter_rsa_pub_key_to_engine_specific() [OpenSSL] #515

Closed
outspace opened this issue Aug 2, 2019 · 2 comments

Comments

@outspace
Copy link

commented Aug 2, 2019

In https://github.com/cossacklabs/themis/blob/master/src/soter/openssl/soter_rsa_key.c, in function
soter_rsa_pub_key_to_engine_specific()

if (!rsa_n) {
        return SOTER_NO_MEMORY;
 }

don't free previously allocated rsa

@Lagovas

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2019

agree, we should add RSA_free(rsa)

@ilammy

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2019

Known leaks have been eliminated.

@ilammy ilammy closed this Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.