Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect call of BN_free(pub_exp) in soter_rsa_gen_key(), soter_rsa_key_pair_gen_init() #517

Closed
outspace opened this issue Aug 5, 2019 · 1 comment

Comments

@outspace
Copy link

commented Aug 5, 2019

As explained in #516 we don't need to call BN_free(pub_exp) after ctrl EVP_PKEY_CTRL_RSA_KEYGEN_BITS but in this funtions we do it. In https://github.com/cossacklabs/themis/blob/master/src/soter/openssl/soter_rsa_key_pair_gen.c,
https://github.com/cossacklabs/themis/blob/master/src/soter/boringssl/soter_rsa_common.c

@ilammy

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2019

Now we don't free bignums twice if an error happens.

Thank you for finding this, @outspace.

@ilammy ilammy closed this Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.