New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pythemis wrapper secure cell fixes #241

Merged
merged 6 commits into from Oct 13, 2017

Conversation

Projects
None yet
2 participants
@vixentael
Copy link
Member

vixentael commented Oct 13, 2017

This PR fixes pythemis secure cell checks that were broken after #189.

Unfortunately, broken changes were missed due to poor pythemis tests: tests didn't check result code.

Changes:

  • update scell wrapper to use correct error code from Themis core
  • update pythemis, rubythemis, phpthemis tests running script (handle error code)
  • rename pythemis tests to match test_*.py name style, usepython -m unittest to run all tests instead of running each test files
  • add small scell_test.py example to illustrate scell

Next steps:

After merging this PR I'll push new pythemis package

@vixentael vixentael added the python label Oct 13, 2017

@Lagovas Lagovas merged commit 06ea7b9 into master Oct 13, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@vixentael vixentael deleted the tests-fix branch Oct 13, 2017

@vixentael

This comment has been minimized.

Copy link
Member

vixentael commented Oct 13, 2017

@vixentael vixentael added the tests label Oct 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment