New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix android secure cell wrapper in token protect mode #251

Merged
merged 4 commits into from Nov 6, 2017

Conversation

Projects
None yet
2 participants
@vixentael
Member

vixentael commented Nov 5, 2017

bits and pieces while fixing android secure cell :)

  • uncomment tests for Secure Cell
  • see that tests are failing for token protect mode
  • fix themis_jni for token protect

extra points:

  • update python secure cell example (well, i just use it as reference code)
@@ -22,6 +22,7 @@
#include <soter/soter_container.h>
#include <string.h>
#include <time.h>

This comment has been minimized.

@vixentael

vixentael Nov 5, 2017

Member

clang requires this header to be while building themis with boringssl :D

@@ -45,9 +45,9 @@
@Override
public void runTest() {
try {
// testSeal();

This comment has been minimized.

@vixentael

vixentael Nov 5, 2017

Member

you know, having tests commented... is kinda.. questionable :D

@vixentael

This comment has been minimized.

Member

vixentael commented Nov 5, 2017

Red one was a real current state of themis android tests :/

screen shot 2017-11-05 at 10 35 14 pm

But now they're fixed! 🎉

@Lagovas Lagovas merged commit 11a24a1 into master Nov 6, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@vixentael vixentael deleted the vixentael/android branch Nov 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment