Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test that length of encrypted data == length of raw data #282

Merged

Conversation

@Lagovas
Copy link
Contributor

Lagovas commented Jan 17, 2018

tested python/C tests, but didn't check locally php version update. but ci should test it

@Lagovas Lagovas requested a review from vixentael Jan 17, 2018
@vixentael

This comment has been minimized.

Copy link
Member

vixentael commented Jan 17, 2018

New test checks are always welcomed! Cool that we will check message length now

@vixentael

This comment has been minimized.

Copy link
Member

vixentael commented Jan 17, 2018

Google tells me that it should be count($arr) for php

@@ -100,6 +100,7 @@ public function testTokenProtectWithContext($key, $message, $context, $iscorrect
$this->setExpectedException('Exception');
}
$encrypted_message = phpthemis_scell_token_protect_encrypt($key, $message, $context);
$this->assertEquals(strlen($encrypted_message), strlen($message));

This comment has been minimized.

Copy link
@vixentael
@vixentael vixentael merged commit e4efcb3 into cossacklabs:master Jan 18, 2018
2 checks passed
2 checks passed
ci/bitrise/b32b4ea8bffedad7/pr Passed - themis
Details
ci/circleci Your tests passed on CircleCI!
Details
@Lagovas Lagovas deleted the Lagovas:lagovas/add-token-protect-test-case branch Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.