Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bitcode setting in Themis.podspec [iOS] #407

Merged
merged 2 commits into from Mar 4, 2019

Conversation

Projects
None yet
2 participants
@vixentael
Copy link
Member

commented Mar 4, 2019

Previous version of bitcode setting had significant downside: can't compile on device 🤦‍♀️

  • updated podspec and pushed it.
  • updated connected examples.
  • tested on device.

Will close #406 when merged

vixentael added some commits Mar 4, 2019

@vixentael vixentael self-assigned this Mar 4, 2019

@vixentael vixentael requested a review from Lagovas as a code owner Mar 4, 2019

@vixentael vixentael requested review from ilammy and removed request for Lagovas Mar 4, 2019

@vixentael vixentael assigned vixentael and unassigned vixentael Mar 4, 2019

'BITCODE_GENERATION_MODE[config=Release]' => 'bitcode',
'BITCODE_GENERATION_MODE[config=Debug]' => 'bitcode-marker'
}
so.ios.pod_target_xcconfig = {'ENABLE_BITCODE' => 'YES' }

This comment has been minimized.

Copy link
@vixentael

vixentael Mar 4, 2019

Author Member

this is a real change

@ilammy

ilammy approved these changes Mar 4, 2019

Copy link
Contributor

left a comment

significant downside: can't compile on device

A minor nuisance, indeed 😅

Unfortunately, I don't have a physical iOS device so I can't check that, but the changes look good to me and I am still able to run a build on a simulator.

@vixentael vixentael merged commit 5208078 into master Mar 4, 2019

8 checks passed

ci/bitrise/b32b4ea8bffedad7/push Passed - themis
Details
ci/circleci: analyze Your tests passed on CircleCI!
Details
ci/circleci: android Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: php5 Your tests passed on CircleCI!
Details
ci/circleci: php70 Your tests passed on CircleCI!
Details
ci/circleci: php71 Your tests passed on CircleCI!
Details
ci/circleci: x86_64 Your tests passed on CircleCI!
Details
@vixentael

This comment has been minimized.

Copy link
Member Author

commented Mar 4, 2019

I wish we have autotests that run on real devices 😿

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.