Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SOTER_PRIVATE_API declarations to headers #472

Merged
merged 2 commits into from May 22, 2019

Conversation

@ilammy
Copy link
Contributor

ilammy commented May 21, 2019

Microsoft Visual Studio C Compiler cannot handle attributes added to definitions of functions, it expects __declspecs to be located at declaration sites. Move all macros to headers in order to avoid linkage errors on Windows.

Microsoft Visual Studio C Compiler cannot handle attributes added
to definitions of functions, it expectes __declspecs to be located
at declaration sites. Move all macros to headers in order to avoid
linkage errors on Windows.
@ilammy ilammy added the core label May 21, 2019
@ilammy ilammy requested review from vixentael and Lagovas May 21, 2019
@ilammy ilammy requested review from ignatk and storojs72 as code owners May 21, 2019
Copy link
Contributor

Lagovas left a comment

lgtm

Copy link
Member

vixentael left a comment

lgtm

@ilammy ilammy mentioned this pull request May 22, 2019
@ilammy ilammy merged commit a35684a into cossacklabs:master May 22, 2019
7 of 8 checks passed
7 of 8 checks passed
ci/circleci: android Your tests failed on CircleCI
Details
ci/bitrise/69a1d5c9d42fa60f/pr Passed - themis-tests
Details
ci/circleci: analyze Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: php5 Your tests passed on CircleCI!
Details
ci/circleci: php70 Your tests passed on CircleCI!
Details
ci/circleci: php71 Your tests passed on CircleCI!
Details
ci/circleci: x86_64 Your tests passed on CircleCI!
Details
@ilammy ilammy deleted the ilammy:windows/api-exports branch May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.