From f10034002fbce3ec78418a26aca8cb85e0970a1d Mon Sep 17 00:00:00 2001 From: Noah Schatz Date: Fri, 7 Aug 2026 18:39:18 +0000 Subject: [PATCH] docs(phi-scan): cut a test-composition sentence that was wrong twice The third conformance pass on the phi-scan slice found that the sentence describing which tests stay green under the base scanner under-enumerates: it named "the floor tests, the controls, and the ones that PIN a residual", and at least 15 of the 38 fall in none of those categories. They are regression guards from earlier slices: rename detection, staged non-regular entries, all-mode non-regular entries, and the two invocation-failure cases. This repo's own vocabulary makes "controls" a narrow enumerated set, so they cannot be absorbed into it. That paragraph has now produced a documentation-accuracy defect on three consecutive passes, which is a signal about the paragraph rather than about the scanner. So the sentence is CUT rather than restated a fourth time, per this repo's standing "CUT, do not rewrite" rule. What replaces it is the one fact that is cheap to verify and does not decay into a taxonomy: 33 of the 38 are tests the base suite already carried, re-derived here (34 base tests, 33 carried forward, 14 new, 47 total). The load-bearing number is untouched and was confirmed by the same pass: 9 of 47 red against cd221a0's scanner. No behaviour changes; this is one markdown paragraph. A sibling instance of the same pattern one section up, describing an earlier slice's comparison, is PRE-EXISTING and is deliberately left alone for its own slice. --- documentation/agent-notes.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/documentation/agent-notes.md b/documentation/agent-notes.md index d81390d..68e67cd 100644 --- a/documentation/agent-notes.md +++ b/documentation/agent-notes.md @@ -168,8 +168,10 @@ tracked fixture removed from the working tree with the rest of the root still op away. **9 of `test/scripts/phi-scan.test.ts`'s 47 tests run red against `cd221a0`'s scanner** and green against this one. **Name the denominator and re-derive it, because this very number went stale inside the paragraph correcting a stale number**: it read `8` of `45` one commit earlier, and adding -the unmerged-count test moved it. The 38 that stay green are the floor tests, the controls, and the -ones that PIN a residual, which are green on both trees by design. +the unmerged-count test moved it. **The composition of the 38 that stay green was stated here twice +and was wrong both times, so it is CUT rather than restated a third time**: 33 of them are tests +`cd221a0`'s suite already carried, most of them regression guards from earlier slices that fit none +of the tidy categories a summary reaches for. Re-derive it if you need it; do not summarise it. **The remedy is reconciliation, not counting.** Each root's walk is compared against `git ls-files -z -- `, and two independent conditions refuse: the root contributed nothing, or