feat!: append app name to table name#257
Merged
Merged
Conversation
…d from CARGO_PKG_NAME. * updated cot-cli to add the crate name to the table prefix in migration files (directly encoded into ModelInSource struct in the loop that parses .rs migration files) * updated database names in unit tests (cot/tests/db.rs, cot-cli/tests, etc.) as well as test migration files to adhere to this format.
github-actions
Bot
added
C-cli
Codecov ReportAttention: Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
m4tx
requested changes
Mar 30, 2025
m4tx
left a comment
m4tx
left a comment
Member
There was a problem hiding this comment.
Looks like a good change! There are a few minor issues—after fixing them this should be ready to be merged.
…ion make`. * Added snake-case conversion code to the migration-side code. * Replaced `unwrap()` when failing to extract CARGO_PKG_NAME env var, with `expect()` call + helpful failure message.
Contributor
Author
|
The new commit should address the issues @m4tx brought up. Thanks for the review. |
m4tx
approved these changes
Apr 3, 2025
m4tx
left a comment
m4tx
left a comment
Member
There was a problem hiding this comment.
This change looks good, thanks a lot for the contribution!
I'll merge this soon.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address issue #153
Append app (crate) name to table as a prefix.