fix: ForeignKey<Self> doesn't compileFix self foreignkey - #313
Merged
Conversation
…l by marking the struct as a struct not a use
Codecov ReportAttention: Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
m4tx
approved these changes
May 13, 2025
m4tx
left a comment
Member
There was a problem hiding this comment.
Sorry for my delay in reviewing this. Looks good; thanks a lot for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In database models, if you used
ForeignKey<Self>you'd get an error as described by #298In this PR, I added a check in the symbol resolver to check for any generic
Selfand replace it with the struct name.This also affects migration generation which now references
Selfwith full struct crate name.