Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Newer
Older
100644 108 lines (90 sloc) 5.164 kb
6093b3d2 »
2012-03-22 initial version of core contributing talk, step 0 and 1
1 thrown into a shark poind: surviving core development
2 speaker: gabor hojtsy
3 drupalcon 2012
4
5 shiny handout: "I have an idea for Drupal core!"
6
7 gabor is maintainer for d6 (former?), works for acquia, D8MI (mobile initiative)
8
9 step 0: decide which drupal version you want to add a feature to. d8 gets new shiny, d7 gets mostly backports and small changes, d6 is maint. only
10 d7 has a looser backporting policy than d6 did, so there's some potential for increased awesome
11 d6 needs to stay super-stable. shiny doesn't happen there anymore, though perf improvements are welcome
12 d6 definitely gets security fixes
13 to fix a d6 issue, patch d8 first, backport to d7, backport to d6. wheee.
14 this is good for users, but kinda sucks for hackers
15 there are no forward ports because bug fixed in version X need to stay fixed after version X
16
17 step 1: Do you need it done right or now?
fa49590a »
2012-03-22 finish up the core hacking notes
18 need it right now: hack it (yuck), use hooks, use contrib modules
6093b3d2 »
2012-03-22 initial version of core contributing talk, step 0 and 1
19 even if your patch won't get into core, submit an issue to core anyway
20 drush make helps you with this
fa49590a »
2012-03-22 finish up the core hacking notes
21 you can still get some of the benefits of the oss community (review, validation), even if you don't get all of them
22 override hooks:
23 hook_menu_alter() lets you mess with routing arbitrarily
24 hook_module_implements_alter() lets you mess with how module hooks are invoked arbitrarily (?!?!)
25 using these implies some copy/pasting
26 hook_form_alter, hook_page_alter - mess with forms and page output arbitrarily
27 be careful. internal apis might change.
28 bigger changes imply more divergence over time
29 post a contrib module if possible
30 always be careful with these. with great power...
31 propose d8 changes if possible
32 need it done the right way: work on d8
33 this is preferred
34 you get feedback from the community
35 help you use best practices, use the right api, use the right approach
36 easier to get fixes across different drupal version
37 it's not solely your responsibility
38 other people get to build off your changes
39
40 getting it into d8 core:
41 dont' just start an issue. there are too many already without some differentiating feature
42 start a conversation unless it's a small/obvious fix
43 manage your patch throughout the review process
44 likely first reaction: nobody cares at all. there are 9500 core issues
45 avg lifetimes: bug - 33 weeks, feature req - 1y24w, support - 34w, tasks - 43w
46 ow.
47 check out issue submission guidelines - d.o node 73179, issue tags on d.o node 1207020
48 there are drupal core initiatives. there are a handful and they cover big topics.
49 core initiatives: g.d.o/drupal-initiatives
50 community initiatives: d.o/community-initiatives/drupal-core (less up-to-date, still useful)
51 working groups on g.d.o/groups
52 when working on pushing an issue forward, look at thie git history
53 get issue numbers
54 find usernames of hackers who are likely to care about the thing
55 d.o/irc explains how irc works for the drupal world
56 d.o/core-office-hours - find when someone's available (?)
57 d.o/planet - you can blog about how you're working on an initiative or what not
58 can get some feedback through this, plus blogging is generally a good idea
6093b3d2 »
2012-03-22 initial version of core contributing talk, step 0 and 1
59
fa49590a »
2012-03-22 finish up the core hacking notes
60 now, everyone cares about it. OH NOES!
61 consider all feedback and criticism
62 don't cater to everyone
63 keep the issue summary updated
64 be present and response where needed
65 this will take some serious time
66 have an overall plan with followups
67 don't let the issue get sidetracked. see dcoc for how to deal
68 see also: d.o/dcoc (drupal code of conduct)
69
70 3 approaches to getting stuff into core:
71 d.o project sandbox
72 more flexibility, no risk of breaking core before stuff is ready
73 separate issue queue
74 CMI uses this (config mgmt initiative)
75 at merge time, most poeple haven't been patying attention, so there's ramp-up
76 structure tagging (e.g. "D8MI")
77 work directly in d.o issue queue
78 metaissues (issues that list relevant sub-issues)
79 entity initiative uses this approach
6093b3d2 »
2012-03-22 initial version of core contributing talk, step 0 and 1
80
fa49590a »
2012-03-22 finish up the core hacking notes
81 YAY; patch is rtbc!
82 no guarantees that it'll get into core or not reverted
83 still need to keep an eye on it and make sure it gets into core
84 people can still complain about e.g. codingstd or perf problems
85 once it's in, PARTY!
6093b3d2 »
2012-03-22 initial version of core contributing talk, step 0 and 1
86
fa49590a »
2012-03-22 finish up the core hacking notes
87 see also, denver2012.drupal.org/sprints (if you happen to be at drupalcon denver)
8dcbd606 »
2012-03-22 q/a for core hacking, so far
88
89 q/a:
90 Q; how do you integrate core hacking into $dayjob's workflow
91 use acquia dev desktop as dev env (or whatever. nothing weird's needed)
92 note to self: hack something (or find solution) to quickly spin up a new drupal instance for hacking. manual process sucks atm
93
94 xjm: I don't have ideas for drupal. I help other people who have ideas for drupal.
95 also look for "novice" tagged issues in core
96 core initiatives hold bi-weekly meetings on irc, so jump on in
97 if you read a huge issue comment thread, post an issue summary
4dfd50e7 »
2012-03-22 final core hacking question
98
99 Q: is there any plan to decrease the issue timeline?
100 it's hard and most people don't use the dev version, and testing sucks
101 verifying patches is a highly manual process
102 latest d6 release fixed two bugs, both of which were introduced in the previous release
103
104
105
106
107
8dcbd606 »
2012-03-22 q/a for core hacking, so far
108
Something went wrong with that request. Please try again.