Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable SSLv3 #220

Closed
donlorenzo opened this issue Mar 6, 2018 · 6 comments
Closed

Add option to disable SSLv3 #220

donlorenzo opened this issue Mar 6, 2018 · 6 comments
Assignees

Comments

@donlorenzo
Copy link

By default coturn seems to support SSLv3, TLSv1, TLSv1.1, TLSv1.2.
There are options to disable the newer protocol versions ("--no-tlsv1", "--no-tlsv1_1", and "--no-tlsv1_2") but there does not seem to be an option to disable to old SSLv3 ("--no-ssl23" ?).

It would be nice to have than option to selectively disable support for SSLv3.

@bradleythughes
Copy link
Member

SSLv3 (and SSLv2) are unconditionally disabled by default. You can see that in the code here:
https://github.com/coturn/coturn/blob/master/src/apps/relay/mainrelay.c#L2642-L2650

According to the changelog, SSLv2 was removed in 4.4.1.1, and SSLv3 in 4.5.0.3:
https://github.com/coturn/coturn/blob/master/ChangeLog#L133
https://github.com/coturn/coturn/blob/master/ChangeLog#L44-L48

@donlorenzo
Copy link
Author

Thanks for the reply.
I guess what surprised me (and still does) is that when I start coturn it reports loading certificate and private key for SSL23:

0: SSL23: Certificate file found: snip
0: SSL23: Private key file found: snip
0: TLS1.2: Certificate file found: snip
...

Before I disabled TLSv1 and v1.1 coturn also reported loading of keys for those protocols. Therefore I assumed that it still supports SSL23 since it is reporting the keys being loaded.
Also these lines made me think that SSL was supported for "compatibility".

@bradleythughes
Copy link
Member

Indeed, that does seem confusing. I do not quite understand why it creates that context, though...

@MichaIng
Copy link

Vote to get this confusion fixed: https://help.nextcloud.com/t/howto-setup-nextcloud-talk-with-turn-server/30794/41?u=michaing
🙂

@hucste
Copy link

hucste commented Dec 19, 2018

i vote too.
This confusion should not exists! ;)
It's not normal to display a text about all versions SSL if are disabled.

@eakraly eakraly self-assigned this Aug 25, 2022
@eakraly
Copy link
Collaborator

eakraly commented Sep 21, 2022

As of today, openssl-1.1.1 and above have SSLv3 explicitly disabled (need to recompile openssl to enable it)

@eakraly eakraly closed this as completed Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants