-
Notifications
You must be signed in to change notification settings - Fork 8
Haystack and llamaindex fst and gsi examples #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Haystack and llamaindex fst and gsi examples #63
Conversation
Summary of ChangesHello @shyam-cb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the descriptions for two tutorials, one integrating Haystack and another LlamaIndex, with OpenAI for Retrieval-Augmented Generation (RAG). The primary purpose of these changes is to standardize and accurately reflect the use of Couchbase's GSI (Global Secondary Index) vector indexing capabilities, ensuring consistency in terminology across the documentation. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the descriptions for the Haystack and LlamaIndex GSI examples to better align with the tutorial content. The changes replace references from 'Hyperscale' to the more general 'GSI' (Global Secondary Index), which accurately reflects the technology showcased. The updates are an improvement, and I have one minor suggestion to enhance terminological consistency between the two modified files.
| description: | ||
| - Learn how to build a semantic search engine using Couchbase's Hyperscale vector index. | ||
| - This tutorial demonstrates how to integrate Couchbase's Hyper scale vector search capabilities with OpenAI embeddings. | ||
| - Learn how to build a semantic search engine using Couchbase's GSI vector index. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with the corresponding LlamaIndex example (lamaindex/gsi/___frontmatter._____md) and with line 8 in this file, consider using "GSI vector search" instead of "GSI vector index". While both terms are technically correct, using "GSI vector search" consistently across the examples would improve clarity for the reader.
| - Learn how to build a semantic search engine using Couchbase's GSI vector index. | |
| - Learn how to build a semantic search engine using Couchbase's GSI vector search. |
No description provided.