From 440e3a56b6f7d888c07575a898b79fec8848e06a Mon Sep 17 00:00:00 2001 From: Murtadha Hubail Date: Thu, 13 Dec 2018 20:42:46 +0300 Subject: [PATCH] [ASTERIXDB-2497][TX] Ensure Log Record Flush LSN is Set - user model changes: no - storage format changes: no - interface changes: no Details: - Set the flush LSN of log records before giving it to the log flusher to avoid reading invalid value if the flush is completed before setting the LSN. - Ensure log record LSN is thread-safe. - Warn in case of a flush with LSN = 0. Change-Id: Ifc605c2d794339a3dc5004b462eca50ec103c717 Reviewed-on: https://asterix-gerrit.ics.uci.edu/3087 Sonar-Qube: Jenkins Tested-by: Jenkins Integration-Tests: Jenkins Contrib: Jenkins Reviewed-by: Murtadha Hubail Reviewed-by: Till Westmann --- .../asterix/common/context/PrimaryIndexOperationTracker.java | 3 +++ .../java/org/apache/asterix/common/transactions/LogRecord.java | 2 +- .../transaction/management/service/logging/LogManager.java | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/PrimaryIndexOperationTracker.java b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/PrimaryIndexOperationTracker.java index a1d31d5d87d..59e19ca620b 100644 --- a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/PrimaryIndexOperationTracker.java +++ b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/PrimaryIndexOperationTracker.java @@ -201,6 +201,9 @@ public synchronized void triggerScheduleFlush(LogRecord logRecord) throws Hyrack } idGenerator.refresh(); long flushLsn = logRecord.getLSN(); + if (flushLsn == 0) { + LOGGER.warn("flushing an index with LSN 0. Flush log record: {}", logRecord::getLogRecordForDisplay); + } ILSMComponentId nextComponentId = idGenerator.getId(); Map flushMap = new HashMap<>(); flushMap.put(LSMIOOperationCallback.KEY_FLUSH_LOG_LSN, flushLsn); diff --git a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogRecord.java b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogRecord.java index 0c3b21df782..7a1079d5149 100644 --- a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogRecord.java +++ b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogRecord.java @@ -88,7 +88,7 @@ public class LogRecord implements ILogRecord { private final ILogMarkerCallback callback; // A callback for log mark operations private int PKFieldCnt; private ITransactionContext txnCtx; - private long LSN; + private volatile long LSN; private final AtomicBoolean isFlushed; private final PrimaryKeyTupleReference readPKValue; private final SimpleTupleReference readNewValue; diff --git a/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java b/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java index 0a6dda992c5..a9903799cee 100644 --- a/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java +++ b/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java @@ -187,10 +187,10 @@ synchronized void syncAppendToLogTail(ILogRecord logRecord) { } final int logSize = logRecord.getLogSize(); ensureSpace(logSize); - appendPage.append(logRecord, appendLSN.get()); if (logRecord.getLogType() == LogType.FLUSH) { logRecord.setLSN(appendLSN.get()); } + appendPage.append(logRecord, appendLSN.get()); if (logRecord.isMarker()) { logRecord.logAppended(appendLSN.get()); }