New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0: Provide a script to strip simulator architecture frameworks for app submission #1610

Closed
pasin opened this Issue Feb 5, 2017 · 6 comments

Comments

Projects
None yet
3 participants
@pasin
Contributor

pasin commented Feb 5, 2017

I think we should provide a script to strip simulator architecture framework out of the provided fat framework for user's app submission. In general, users can do this themselves but I think it's good to provide one.


  • Version: 2.0 DP

@pasin pasin changed the title from 2.0 - Provide a script to strip simulator architecture framework to 2.0 - Provide a script to strip simulator architecture framework for app submission Feb 5, 2017

@djpongh djpongh added this to the 2.0 milestone Feb 24, 2017

@djpongh djpongh added the backlog label Feb 24, 2017

@djpongh djpongh added ready backlog and removed backlog ready labels Oct 30, 2017

@djpongh djpongh added the P2: medium label Nov 17, 2017

@pasin pasin changed the title from 2.0 - Provide a script to strip simulator architecture framework for app submission to 2.0: Provide a script to strip simulator architecture frameworks for app submission Nov 17, 2017

@rajagp rajagp removed the P1: high label Dec 19, 2017

@djpongh djpongh modified the milestones: 2.0.0, 2.1.0 Feb 2, 2018

pasin added a commit that referenced this issue Mar 26, 2018

Add script for stripping frameworks and dSYM files
This is a script to add to the build phase in order to strip non-valid architecture types from the frameworks and dSYM files if added to the built product directory. This is require when archiving the app for submission as currently XCode will not strip non-valid archs (e.g. simulator acrch).

The next step is to figure out where to distribute this file: [1] in release zip or [2] in the framework bundle inself.

#1610

@djpongh djpongh removed the P2: medium label Apr 3, 2018

@djpongh djpongh modified the milestones: 2.1.0, 2.2.0 Apr 3, 2018

@pasin pasin modified the milestones: 2.2.0, 2.1.0 May 21, 2018

@pasin

This comment has been minimized.

Contributor

pasin commented May 21, 2018

@djpongh We have recently received a CBSE ticket regarding this so I think we should provide the script for 2.1.0. I already have the script written but need to include in the the release zip file.

@djpongh djpongh added backlog and removed icebox labels Jun 1, 2018

@rajagp

This comment has been minimized.

Contributor

rajagp commented Jun 4, 2018

Agree with @pasin that in order to simplify things for our users, we must provide the script in 2.1.0 release to strip off unwanted architectures
@pasin - Once in place, can you add a ticket for @jamiltz to include a section in the documentation on how they can use the script.

@djpongh djpongh added the P1: high label Jun 4, 2018

@djpongh djpongh added P2: medium and removed P1: high labels Jul 17, 2018

@pasin

This comment has been minimized.

Contributor

pasin commented Jul 19, 2018

@rajagp how should we distribute the script? I think there are two options:

  1. Put the script file in release zip file.
  2. Put the script file in the CouchbaseLiteSwite.framework.

The second approach also distributes the script to Carthage and Cocoapods developers.

@rajagp

This comment has been minimized.

Contributor

rajagp commented Jul 19, 2018

I am fine with 1 or 2. Which ever is simplest. Do u know what Realm or some other framework does?

@pasin

This comment has been minimized.

Contributor

pasin commented Jul 19, 2018

Realm and Carthage have the script inside .framework.

@rajagp

This comment has been minimized.

Contributor

rajagp commented Jul 19, 2018

Lets do 2. then

pasin added a commit that referenced this issue Jul 20, 2018

Include strip framework script in the framework bundle
Included strip framework script in the framework bundle under Scripts folder.

#1610

@pasin pasin removed the backlog label Jul 20, 2018

@pasin pasin closed this Jul 20, 2018

@pasin pasin added the enhancement label Jul 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment