New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBLReplicator always runs on main queue #2127

Closed
snej opened this Issue Mar 30, 2018 · 0 comments

Comments

Projects
None yet
3 participants
@snej
Member

snej commented Mar 30, 2018

Just noticed that CBLReplicator's callbacks all run on the main dispatch queue, since its _dispatchQueue ivar is initialized to dispatch_get_main_queue() and never changed.

This could block UI work the main queue is doing, or if the main queue is overly busy it could delay the replicator.

I think it'd be better to set _dispatchQueue to be the queue of the local CBLDatabase associated with the replicator.

@snej snej added the performance label Mar 30, 2018

@djpongh djpongh added this to the 2.1.0 milestone Mar 30, 2018

@djpongh djpongh added the icebox label Mar 30, 2018

@djpongh djpongh modified the milestones: 2.1.0, 2.2.0 Apr 3, 2018

@pasin pasin modified the milestones: 2.5.0, 2.1.0 Jul 31, 2018

@pasin pasin removed the icebox label Jul 31, 2018

@pasin pasin self-assigned this Jul 31, 2018

pasin added a commit that referenced this issue Jul 31, 2018

Fixed System Test crash when accessing CBLReplicator.status from Swif…
…t API

* Made CBLReplicator.status property atomic (#2187)
* Changed CBLReplicator to use the dispatch queue from the CBLDatabase instead of using Main queue (#2127)

@pasin pasin closed this Jul 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment