Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Expiry doesn't seem to set the expiration timestamp in milliseconds #2270

Closed
pasin opened this issue Dec 9, 2018 · 0 comments

Comments

@pasin
Copy link
Contributor

commented Dec 9, 2018

From the code here https://github.com/couchbase/couchbase-lite-ios/blob/master/Objective-C/CBLDatabase.mm#L540-L547, we need to convert from second to milliseconds before calling c4doc_setExpiration().

@pasin pasin added bug P1: high labels Dec 9, 2018

@pasin pasin added this to the Iridium milestone Dec 9, 2018

@pasin pasin assigned jayahariv and pasin and unassigned jayahariv Dec 9, 2018

pasin added a commit that referenced this issue Dec 9, 2018

Fixed #2270 : Convert from sec to msec and vice versa
* Convert from sec to msec when setting expiration date
* Convert from msec to sec when getting expiration date

@pasin pasin closed this in f1a7e3f Dec 9, 2018

pasin added a commit that referenced this issue Dec 9, 2018

Fix QueryTest to use milliseconds when query doc expiration
Fixed to query document expiration by using milliseconds instead of seconds.

#2270
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.