Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove log rotation change batching #2321

Closed
borrrden opened this issue Jan 12, 2019 · 0 comments

Comments

@borrrden
Copy link
Member

commented Jan 12, 2019

The batching of things like the file logging max size, max rotate count, etc is prone to races and generally over complicated. This will be achieved by moving these settings into a class that will be set so that all properties are changed at once.

@borrrden borrrden added this to the Iridium milestone Jan 12, 2019

@djpongh djpongh added the P1: high label Jan 14, 2019

@djpongh djpongh added the backlog label Jan 14, 2019

pasin added a commit that referenced this issue Jan 15, 2019

Implement a new file logger API (#2326)
* Implement a new file logger API

- Implemented a new file logger API a refactor log file related settings into a single configuration file, LogFileConfiguration.

- Updated unit tests.

#2321

@djpongh djpongh closed this Jan 18, 2019

@djpongh djpongh removed the backlog label Jan 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.