Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement readOnly mode in CBLSyncListener #838

Closed
snej opened this issue Jul 31, 2015 · 1 comment
Closed

Implement readOnly mode in CBLSyncListener #838

snej opened this issue Jul 31, 2015 · 1 comment
Assignees
@pasin
Labels
bug f: Replication peer-to-peer review
Milestone
1.2

Comments

@snej
Copy link
Contributor

snej commented Jul 31, 2015

CBLSyncListener, the listener for the new replication protocol, doesn't yet implement read-only (i.e. pull-only) access.
@snej snej mentioned this issue Jul 31, 2015
Closed
@zgramana zgramana added this to the 1.2 milestone Jul 31, 2015
@zgramana
Copy link
Contributor

zgramana commented Aug 7, 2015

Unblocks #726 when complete.

@zgramana zgramana added ready and removed backlog labels Aug 7, 2015
@zgramana zgramana assigned pasin and unassigned snej Aug 7, 2015
@pasin pasin added in progress and removed ready labels Aug 11, 2015
pasin added a commit that referenced this issue Aug 14, 2015
@pasin
Implement readOnly to CBLSyncListener
2e8f708 
- Added OnSyncAccessCheckBlock property to CBLSyncConnection similarly to CBL_Router.OnAccessCheckBlock property. OnSyncAccessCheckBlock (if specified) will be called to check the access for each sync request coming to the CBLSyncConnection's handlers. The handlers will then return the corresponding error responses depending on the result of the OnSyncAccessCheckBlock call.

- In read only mode, CBLSyncListener will block access to setCheckpoint, changes, and rev requests.

#838
@pasin pasin mentioned this issue Aug 14, 2015
Merged
@pasin pasin added review and removed in progress labels Aug 14, 2015
pasin added a commit that referenced this issue Aug 15, 2015
@pasin
Implement readOnly to CBLSyncListener
29bcbcc 
- Added OnSyncAccessCheckBlock property to CBLSyncConnection similarly to CBL_Router.OnAccessCheckBlock property. OnSyncAccessCheckBlock (if specified) will be called to check the access for each sync request coming to the CBLSyncConnection's handlers. The handlers will then return the corresponding error responses depending on the result of the OnSyncAccessCheckBlock call.

- In read only mode, CBLSyncListener will block access to setCheckpoint, changes, and rev requests.

#838
pasin added a commit that referenced this issue Aug 15, 2015
@pasin
Fixed CBLSyncConnection bug per code review
6fd7e8a 
#838
@snej snej closed this as completed in d486504 Aug 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pasin pasin

Labels
bug f: Replication peer-to-peer review
Projects
None yet
Milestone
1.2
Development

No branches or pull requests
3 participants
@snej @zgramana @pasin