Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out _removed revision from push replication #820

Closed
hideki opened this issue Nov 13, 2015 · 0 comments

Comments

@hideki
Copy link

commented Nov 13, 2015

Originally reported for iOS: couchbase/couchbase-lite-ios#776

Filter out _removed revision in CBL_Pusher's processInbox when preparing revisions to send to the remote server.

No changes in CBL_Pusher.unpushedRevisions properties. Therefore unpushedRevisions could contained _removed revisions. The same for getting _changes feed from the CBLRouter.

Added a unit test

Added cbl_replicator_removed_rev remote database config to Unit-Tests/Server/cbl_unit_tests.json

(couchbase/couchbase-lite-ios#671)

@zgramana zgramana added this to the 1.2.0 milestone Nov 13, 2015

@zgramana zgramana added the backlog label Nov 13, 2015

@zgramana zgramana modified the milestones: 1.2.0, 1.3 Feb 6, 2016

@zgramana zgramana added backlog and removed ready labels Apr 6, 2016

@hideki hideki added review and removed in progress labels May 4, 2016

@pasin pasin closed this in b333061 May 7, 2016

pasin added a commit that referenced this issue May 7, 2016
Merge pull request #1226 from couchbase/feature/issue_820
Fixed #820 - Filter out _removed revision from push replication

@pasin pasin removed the review label May 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.