Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Dec 09, 2013

  1. patrickcouchbase

    NCBC-289: Does not return errors object on exception

    We decided to throw an exception when an error is detected for all view
    error cases. In the next version (2.x) of the client will make a decision
    on how we want the client to behave when an error is encountered when
    processing a view. This commit makes it consistent across all error cases
    and does not change the interface, which would likely impact users
    requiring them to change there code from handling exceptions to checking
    an errors property for failures.
    
    This commit also adds additional unit tests and refactors the
    CouchbaseViewHandler class so that we can pass streams into the
    ReadResponse method that contain text resembling errors returned from the
    server.
    
    Change-Id: I87f982a1b33236eb3b7aa47eb08a4ef88892500e
    Reviewed-on: http://review.couchbase.org/29173
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Jeffry Morris <jeffrymorris@gmail.com>
    authored jeffrymorris committed

Dec 03, 2013

  1. Jeffry Morris

    NCBC-310 Amendment #5 - operation timeout

    This commit adds timeouts to operations where there is potential for
    the client to hang indefinitly.
    
    Change-Id: Id50b6a41167b12c0d8b22d2c939a3ee8846ddf30
    Reviewed-on: http://review.couchbase.org/30777
    Reviewed-by: Jeffry Morris <jeffrymorris@gmail.com>
    Tested-by: Jeffry Morris <jeffrymorris@gmail.com>
    authored

Dec 01, 2013

  1. Jeffry Morris

    NCBC-310: Amendment #4 - added connection pool 'growth'

    This commit enables the connection pool to grow based upon resource demand
    from the MinPoolSize to the MaxPoolSize.
    
    Change-Id: I188b9852282812b85a58e5548c9c70f2645fb22c
    Reviewed-on: http://review.couchbase.org/30437
    Tested-by: Jeffry Morris <jeffrymorris@gmail.com>
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    authored
  2. Jeffry Morris

    NCBC-325: MemcachedClient.ExecuteGet(...) does not return error codes

    Change-Id: Icba87d8096cbf4444632c518e158571fbce54d66
    Reviewed-on: http://review.couchbase.org/30718
    Tested-by: Jeffry Morris <jeffrymorris@gmail.com>
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    authored

Nov 30, 2013

  1. Ivars Auzins

    NCBC-293: enhance or create new multiget to allow getting details on

    missing items.
    
    Note this is a resubmit of http://review.couchbase.org/#/c/29991/ which
    became lost in some expliciable way. To make sure it's in, this change
    was cherry-picked over current and fixed up.
    
    Change-Id: I6c8d397f76c6079d501e390844b55eb72b7a2bd1
    Reviewed-on: http://review.couchbase.org/30708
    Reviewed-by: Jeffry Morris <jeffrymorris@gmail.com>
    Tested-by: Jeffry Morris <jeffrymorris@gmail.com>
    authored jeffrymorris committed

Nov 15, 2013

  1. Jeffry Morris

    NCBC-333 - NCBC-310: Amendment #3 - reference cleanup when SocketPool…

    … is disposed
    
    Change-Id: Ieba7b17f650f413edea4c29aec3cde39fac7324a
    Reviewed-on: http://review.couchbase.org/30294
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Jeffry Morris <jeffrymorris@gmail.com>
    authored

Nov 13, 2013

  1. Matt Ingenthron

    NCBC-332: Change the default DeadTimeout to 2 seconds.

    Change-Id: Ic6c07d8d64e79a7ff8ba50b14e91670a0c3fe490
    Reviewed-on: http://review.couchbase.org/30277
    Reviewed-by: Jeffry Morris <jeffrymorris@gmail.com>
    Tested-by: Jeffry Morris <jeffrymorris@gmail.com>
    authored jeffrymorris committed
  2. Jeffry Morris

    NCBC-311: Change queueTimeout default from 100ms to 2500ms

    The default value for queueTimeout is currently 100ms, which is extremely
    low and will unnecessarily cause queue timeout exceptions. This will increase
    the queueTimeout to 2.5 seconds, which is still a relatively low amount. Note
    that this only affects threads waiting on the SocketPool for a socket, not the
    actual time it takes to execute an operation.
    
    Change-Id: I43fb2368d92e936cb9d15db8b6ba48df46f13413
    Reviewed-on: http://review.couchbase.org/30275
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Jeffry Morris <jeffrymorris@gmail.com>
    authored
  3. Jeffry Morris

    NCBC-329: Ensure IOperationResult returns StatusCode on failure.

    Change-Id: I6f76e749d168757721968f96923143ace7358b3d
    Reviewed-on: http://review.couchbase.org/30243
    Tested-by: Jeffry Morris <jeffrymorris@gmail.com>
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    authored

Nov 12, 2013

  1. Jeffry Morris

    NCBC-330 - During finalization a NRE is thrown on SocketPool

    Fixed minor bug where _pool is null during finalization
    
    Change-Id: I6858811535cbdf1f510ebaf963a0668ec79167d7
    Reviewed-on: http://review.couchbase.org/30236
    Reviewed-by: Jeffry Morris <jeffrymorris@gmail.com>
    Tested-by: Jeffry Morris <jeffrymorris@gmail.com>
    authored
  2. Jeffry Morris

    NCBC-310: Amendment #2 queueTimeout support

    Change-Id: I9ddf1f0d662b0aa91cb0da2210da95a94c1cc2fe
    Reviewed-on: http://review.couchbase.org/30242
    Reviewed-by: Jeffry Morris <jeffrymorris@gmail.com>
    Tested-by: Jeffry Morris <jeffrymorris@gmail.com>
    authored
  3. Jeffry Morris

    NCBC-318: Status Code list contains duplicate value

    Change-Id: I5cdaaa1311c768dc128749a9ea561351faa481b9
    Reviewed-on: http://review.couchbase.org/30237
    Reviewed-by: Jeffry Morris <jeffrymorris@gmail.com>
    Tested-by: Jeffry Morris <jeffrymorris@gmail.com>
    authored
  4. Jeffry Morris

    NCBC-324: ExecuteGet(string key, DateTime newExpiration) returns unex…

    …pected result codes
    
    Change-Id: Ib9f6db0d5917490362f9c0124bdccce44b7d8da0
    Reviewed-on: http://review.couchbase.org/30193
    Tested-by: Jeffry Morris <jeffrymorris@gmail.com>
    Reviewed-by: Brett Lawson <brett19@gmail.com>
    authored

Nov 08, 2013

  1. Jeffry Morris

    NCBC-310 Amendment: Changed socket pool implementation

    Change-Id: Id1a82004ff51d51f393de519bf6b08a885028b95
    Reviewed-on: http://review.couchbase.org/30139
    Reviewed-by: Mark Nunberg <mnunberg@haskalah.org>
    Tested-by: Jeffry Morris <jeffrymorris@gmail.com>
    authored

Nov 06, 2013

  1. Jeffry Morris

    NCBC-317 Mark Sync operations as obsolete

    Change-Id: I28b15eb2ee03681c1e29140742ab3e7bff1a39aa
    Reviewed-on: http://review.couchbase.org/29750
    Tested-by: Jeffry Morris <jeffrymorris@gmail.com>
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    authored
  2. Jeffry Morris

    NCBC-309: Move .NET API documentation from docs repo to auto-doc

    This is the first step in the process - adding the xml comments to each method
    declaration of the publc API. These will be used to generate the HTML API
    reference. Note, that in a MVP fashion, I did the bare minimum documentation
    for each method. In future releases, the documentation should be improved
    
    Change-Id: I7ce1a5cf2f1e286c98f1925fd8cee5b0b8e68dcf
    Reviewed-on: http://review.couchbase.org/29859
    Tested-by: Jeffry Morris <jeffrymorris@gmail.com>
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    authored
  3. Jeffry Morris

    NCBC-306: .NET GetJSON operation throws null reference exception

    Add support for null values persisted for a key via the
    CouchbaseClientExtensions.GetJson(…) method. This method will no 
    longer thrown a NullReferenceException when the value store for a 
    key is null and instead simply return null.
    
    Change-Id: I345cb7e33b5e9f33ea22cb205de84475abf3d35d
    Reviewed-on: http://review.couchbase.org/29840
    Tested-by: Jeffry Morris <jeffrymorris@gmail.com>
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    authored
  4. Jeffry Morris

    NCBC-316: Allow GetJson to support the retrieval of arrays and lists

    Adds support to the CouchbaseClientExtensions.GetJson(…) method to 
    handle the deserialization of arrays and lists of objects and not 
    just individual objects.
    
    Change-Id: I69704b922c559265b736ca54c3eee32a6aef7d5e
    Reviewed-on: http://review.couchbase.org/29746
    Tested-by: Jeffry Morris <jeffrymorris@gmail.com>
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    authored

Nov 05, 2013

  1. Jeffry Morris

    NCBC-310: Refactor Connection Pool

    Refactored the CouchbaseNode class so that it depends upon a different
    implmentation of the internal socket pool that utilizes a queue structure
    instead of the stack based implmentation used by MemcachedClient. The
    PooledSocket now has a new interface, IPooledSocket, with CouchbaseClient
    and MemcachedClient having seperate implementations. Note that these
    changes only impact CouchbaseClient instances - MemcachedClient instances
    still use the older implementation. The benefits of this include: more
    efficient resource allocation and management, elimination of threading
    some issues related to race conditions and other re-entrency problems,
    better structure and code organization, improved unit tests and
    testability and overall extensibility of certain components: pools,
    socket wrappers, etc.
    
    Change-Id: I2348f60dc8c0b3304cba19753db08d9cd60e570f
    Reviewed-on: http://review.couchbase.org/29832
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Jeffry Morris <jeffrymorris@gmail.com>
    authored
  2. Jeffry Morris

    NCBC-299: Fix project references.

    The last commit for NCBC-299 has a couple of errors.  One is that some
    subprojects reference NewtonsoftJSON and shouldn't.  Second is that one
    of the projects references the wrong thing between 3.5/4.0.
    
    Change-Id: Ie116feb16a3c112658693bb108174856fe652ca9
    Reviewed-on: http://review.couchbase.org/30035
    Tested-by: Jeffry Morris <jeffrymorris@gmail.com>
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    authored

Nov 04, 2013

  1. Jeffry Morris

    NCBC-299: Update Project References from Nuget to Local Project.

    In the .NET solution in Github, the some of the projects are referencing
    Nuget instead of the local projects within the solution. As a result,
    when you pull the repo down you cannot step into the dependent code and
    in some cases you need to disable features (such as logging) or you will
    get a version mismatch error.
    
    Change-Id: Ic9dc6bb82fd3fefc62f9b645ee1fc8a4a05bf162
    Reviewed-on: http://review.couchbase.org/29990
    Reviewed-by: Jeffry Morris <jeffrymorris@gmail.com>
    Tested-by: Jeffry Morris <jeffrymorris@gmail.com>
    authored

Oct 04, 2013

  1. Jeffry Morris

    NCBC-308: Key Exists does not release socket pool if not found

    Change-Id: Id9f19887205b87aa6027ef20bb682c756fd807be
    Reviewed-on: http://review.couchbase.org/29347
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    Reviewed-by: Jeffry Morris <jeffrymorris@gmail.com>
    Tested-by: Jeffry Morris <jeffrymorris@gmail.com>
    authored

Oct 01, 2013

  1. Jeffry Morris

    NCBC-257: Refactored the Dispose/Finalize logic

    The purpose is to ensure that objects that have been disposed,
    do not live until finalization. From my testing, this allievates
    the timeout and other socket errors that were occuring. I also
    adding logging in all empty catch() blocks which should help
    debugging.
    
    Change-Id: Iaef5080ec7a7efdb0377df4392e4798e37071a53
    Reviewed-on: http://review.couchbase.org/29197
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    authored
  2. Jeffry Morris

    NCBC-301 StatusCode improvements for client errors

    I added a new enum StatusCode so that we have a consistent interface for
    tracking the Status codes of operations. The current implentation returns
    Integer values for these codes and does not include client side codes in cases
    where the client fails before the operation is sent to the server. Besides the
    standard binary memcached protocol status codes, I added another for socket
    time outs.
    
    Also, I have yet to write a unit test that consistently causes the socket
    timeout to occur, thus I have omitted unit tests for this commit
    
    Change-Id: I92d5d1fb95c11da7980bf580a06ce4eca005034d
    Reviewed-on: http://review.couchbase.org/29175
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    authored
  3. saakshimanocha

    NCBC-250: Fix the test : CouchbaseAuthenticatedViewTests\When_Bucket_…

    …Is_Authenticated_View_Returns_Results# Please enter the commit message for your changes. Lines starting
    
    Change-Id: Ibd27434bf5c760fa8d1aa5702e9fd23e7f407270
    Reviewed-on: http://review.couchbase.org/28735
    Reviewed-by: Jeffry Morris <jeffrymorris@gmail.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    authored jeffrymorris committed

Aug 11, 2013

  1. Matt Ingenthron

    Updated dependencies to 1.2.7.

    Change-Id: Id4f594b6d42c474d7dd3b8672e5c001d681a173c
    Reviewed-on: http://review.couchbase.org/28104
    Reviewed-by: Saakshi Manocha <saakshi.manocha@globallogic.com>
    Tested-by: Saakshi Manocha <saakshi.manocha@globallogic.com>
    authored saakshimanocha committed

Aug 02, 2013

  1. Daniel Wertheim

    Readme updates

    Provided more info about links to forums and documentation etc. as well
    as removed outdated info about linked repository to get started.
    
    Change-Id: I3ec550d05e59de090b3d8d5c9896dea0687b3b7b
    Reviewed-on: http://review.couchbase.org/27805
    Reviewed-by: Saakshi Manocha <saakshi.manocha@globallogic.com>
    Tested-by: Saakshi Manocha <saakshi.manocha@globallogic.com>
    authored saakshimanocha committed
  2. saakshimanocha

    NCBC-283-Fix failing tests for 2.1.1-763

    Change-Id: I796a4879c8388fab2dd6a8d5c1d255056c911744
    Reviewed-on: http://review.couchbase.org/27707
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Reviewed-by: Saakshi Manocha <saakshi.manocha@globallogic.com>
    Tested-by: Saakshi Manocha <saakshi.manocha@globallogic.com>

Jul 30, 2013

  1. saakshimanocha

    NCBC-174: Fix invalid tests in NUnit project

    CouchbaseClientViewNameTransformerTests are failing because of incorrect bucket name
    
    Change-Id: I4067f445dcb4a3ee10cf700a8faeead63cc98881
    Reviewed-on: http://review.couchbase.org/27312
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Reviewed-by: Saakshi Manocha <saakshi.manocha@globallogic.com>
    Tested-by: Saakshi Manocha <saakshi.manocha@globallogic.com>

Jul 10, 2013

  1. M. Nunberg

    Don't return response.OutputStream if response is null

    Throw an 'InvalidOperationException' instead
    
    Change-Id: If8830abc67849f61f60320f32c3c51ccf9e8fc6e
    Reviewed-on: http://review.couchbase.org/27358
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Reviewed-by: Saakshi Manocha <saakshi.manocha@globallogic.com>
    Tested-by: Saakshi Manocha <saakshi.manocha@globallogic.com>
    authored saakshimanocha committed
  2. M. Nunberg

    NCBC-278: Lock WebClient when getting WebRequest

    WebClient is not thread safe
    
    Change-Id: I92e6aa78d58a37ee41e02d516a836defc17efa6f
    Reviewed-on: http://review.couchbase.org/27355
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Reviewed-by: Saakshi Manocha <saakshi.manocha@globallogic.com>
    Tested-by: Saakshi Manocha <saakshi.manocha@globallogic.com>
    authored saakshimanocha committed

Jul 02, 2013

  1. saakshimanocha

    NCBC-275: Modify Nunit tests to allow for execution in single node e…

    …nvironment.
    
    Change-Id: Ib4a95b1f70f7d248fa0bfbff22ebb7199a3187d7
    Reviewed-on: http://review.couchbase.org/26997
    Reviewed-by: Mordechai Nunberg <mnunberg@haskalah.org>
    Reviewed-by: Saakshi Manocha <saakshi.manocha@globallogic.com>
    Tested-by: Saakshi Manocha <saakshi.manocha@globallogic.com>

May 24, 2013

  1. John Zablocki

    NCBC-265: Refactor solution to include directly the Enyim dependencies

    The Enyim.Caching submodule has been removed, and the
    Enyim projects have been moved into the couchbase-net-client
    source structure.  Appropriate 4.0 and 3.5 versions exist
    for each of the Enyim projects.
    
    Solution references have been updated, and NuGet dependencies
    are now set to download when the project is built, rather
    than being stored in the repository.
    
    Change-Id: I6e137d30ac18284a7168a7633c4f86af1d86cf39
    Reviewed-on: http://review.couchbase.org/26411
    Reviewed-by: Saakshi Manocha <saakshi.manocha@globallogic.com>
    Tested-by: Saakshi Manocha <saakshi.manocha@globallogic.com>
    authored saakshimanocha committed

May 14, 2013

  1. John Zablocki

    NCBC-253: Raise exception on FlushAll when called on CouchbaseNode

    Change-Id: I910a9f903af65ccbb0a3656873ca1d6f4bb4c12d
    Reviewed-on: http://review.couchbase.org/26268
    Reviewed-by: Saakshi Manocha <saakshi.manocha@globallogic.com>
    Tested-by: Saakshi Manocha <saakshi.manocha@globallogic.com>
    authored saakshimanocha committed

May 02, 2013

  1. John Zablocki

    Include view test data file in tests project

    Change-Id: I9661ef9eccbb6c61e4f31b1a0e5a9b1176f6ba69
    Reviewed-on: http://review.couchbase.org/26015
    Reviewed-by: Saakshi Manocha <saakshi.manocha@globallogic.com>
    Tested-by: Saakshi Manocha <saakshi.manocha@globallogic.com>
    authored saakshimanocha committed
Something went wrong with that request. Please try again.