Allow Serializer Customization #10

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

Contributor
bchavez commented Dec 15, 2013

Hi there,

I have some custom serialization requirements; however, currently the CouchbaseClientExtensions does not allow me to customize the Newtonsoft.Json serializer.

This patch allows serializer customization by placeing a static field onCouchbaseClientExtensions.JsonSerializerSettings that enables users of the couchbase extension class to customize the serializer.

Also added a static constructor to CouchbaseClientExtensions which maintains defaults.

Thanks,
Brian

Member

Hi bchavez -

Thanks for the submission!

We require contributors to sign a Contributor License Agreement (CLA), can you create an account and sign our CLA?

Just follow these steps:

1-http://review.couchbase.org
2-Login in and select your username on the top right hand side and then "settings"
3-The last item on the left in the settings view is an "Agreements" menu tab, select that an then
select the "New Contributor Agreement"

Thanks,

Jeff

Contributor
bchavez commented Dec 24, 2013

Hi Jeff, I already did. It's the same bchavez that submitted this bug report:

https://www.couchbase.com/issues/browse/NCBC-352

Thanks,
Brian

Member

Thanks Brian! I'll try to push this into the 1.3.1 release the first week of January assuming it passes code review and regression testing, etc.

Member

This is scheduled for 1.3.2 release, you can track progress here: http://www.couchbase.com/issues/browse/NCBC-358

Thanks for the submission,

-Jeff

@bchavez bchavez closed this Mar 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment