New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use default server configuration when there is no bucket config #52
Conversation
Thanks for the pull request!! To ensure quality review, Couchbase employs a code review system based on Gerrit to manage the workflow of changes in addition to tracking our contributor agreements. To get this change in and collaborate in code review, please register on Gerrit and accept our CLA. More detailed instructions are available here: http://developer.couchbase.com/open-source-projects#how-to-contribute-code. Thanks, Jeff |
Hi @jeffrymorris, I've signed the agreement (I created a new Yahoo account for OpenId, mrk.vincze@yahoo.com). Cheers, |
I'll push the PR to Gerrit and review it sometime in the near future. Depending upon how the code review goes, I may ask you to do another patchset, otherwise I'll merge it to master. -Jeff |
It looks like your email is missing from your gerrit profile can you check this and if it is missing, please add it? I can't push the PR without it (gerrit won't allow it). Let me know when you have done this. Thanks! -Jeff |
Hey @jeffrymorris, I see email address in two places in the Settings: in Profile, but I can't find where I can edit it. Cheers, |
@markvincze - I don't think so, the profile email is what we need. @ingenthr - can you lend a hand here? I still can't push the PR because of the missing email issue. Thanks! Jeff |
This may be related to the OpenID provider you used when you signed up. The gerrit review side seems to not have the email address. @markvincze, do you recall if you allowed sharing of email or not? Sorry for the trouble here. Thanks for working through it with us. I'll look a level deeper on this. I may also force through the PR in the mean time. |
Hey @ingenthr, No problem. I'm having a bit of a hard time navigating in the UI of gerrit, so maybe I'm missing something :) I created an OpenId with Yahoo I don't remember having the option to share the email-address during the process. Now if I access the Settings page in gerrit, I actually see my email address there: Did you manage to set it somehow in the meantime? Yesterday that field was empty. Cheers, |
This PR has been pushed to Gerrit successfully; i'll be reviewing it in the next couple of days and it should be in v2.3.0 or 2.2.5 whichever comes first. Thanks! -Jeff |
This has been merged with master, can you please close this pull request? Thanks for the submission! -Jeff |
Cheers! :) |
If in the web.config
<couchbase>
section we only have a<servers>
section, but no<buckets>
section (because we don't want to statically configure any buckets), then when we try to open a bucket using its name, the client tries to use localhost:8091 instead of the server configured<servers>
.The scenario is when our config looks like the following
This causes two problems.
<servers>
. This is clearly a bug.With this PR, when we get the configuration for a bucket, the server configuration is getting used even if there is no
<buckets>
section.