Same named tests covering up mismatched exception test on no id found. #3

Closed
wants to merge 7 commits into
from

Projects

None yet

2 participants

@mje113
Contributor
mje113 commented Dec 28, 2012

Not really sure if Couchbase::Model's Couchbase::Error::MissingId or the Couchbase gem's Couchbase::Error::NotFound exception should actually be raised here. Changed it to NotFound in the test so it would pass.

@avsej
Member
avsej commented Feb 19, 2013

I have fixed this issue in http://review.couchbase.org/24684, but could you extract the changes about logging into the separate commit and upload to out review system?

We have a document about how to make a contribution https://github.com/couchbase/couchbase-ruby-model/blob/master/CONTRIBUTING.markdown

@avsej
Member
avsej commented Feb 19, 2013

@ingenthr I think this ticket might be closed, because original issue has been fixed

@mje113
Contributor
mje113 commented Jul 3, 2013

I should have closed this a while ago...

@mje113 mje113 closed this Jul 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment