Backport changes from production UI to cloud (aka new) UI #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@mojavelinux PR#16 & #17 look good and are ready to be merged. Just confirming that I can merge them before this PR |
Contributor
Author
|
Yep, go ahead and merge.
…On Tue, Jun 16, 2020, 22:19 Amarantha Kulkarni ***@***.***> wrote:
@mojavelinux <https://github.com/mojavelinux> PR#16 & #17
<#17> look good and are
ready to be merged. Just confirming that I can merge them before this PR
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAATL54XG2PKPQO2KRTEOS3RXA737ANCNFSM4N75HBCA>
.
|
Contributor
Author
|
I'll rebase this PR. |
…ed file if newer than parent
…nsolidate zip routine to a single call
…e pages better; remove relativize helper
…ng helper; add not helper
- delegate to helper to compute latest page URL (latest-page-url) - delegate to helper to compute canonical URL (canonical-url) - update latest page URL resolution to consider aliases - update canonical URL resolution to consider aliases - don't show prerelease banner if all versions are prereleases - document the logic for computing the latest page URL and canonical URL - hide View Latest button if page is not available in latest version
Contributor
Author
|
Rebase complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports changes added to production UI and build since the cloud UI was forked from it. Except for a few minor style changes, this does not fundamentally change the appearance or behavior of the cloud UI. Once this is merged, the cloud UI will become the official new UI.