From 2a1483524c8d31d70698e8e4266bb868e5e3c2c8 Mon Sep 17 00:00:00 2001 From: rakeshAlgo Date: Fri, 10 Jul 2020 16:55:51 +0530 Subject: [PATCH 1/6] UI issues fixes for image block paragraph and table difinition list fixes --- src/css/doc.css | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/src/css/doc.css b/src/css/doc.css index f2b0c48c..f5eedbb7 100644 --- a/src/css/doc.css +++ b/src/css/doc.css @@ -176,6 +176,18 @@ ul ul ul { border-top-width: 1px; } +.ulist li .paragraph:first-child, +.olist li .paragraph:first-child, +.dlist li .paragraph:first-child { + margin-top: var(--base-extra-small-space); +} + +.ulist li .imageblock, +.olist li .imageblock, +.dlist li .imageblock { + margin-bottom: var(--base-extra-small-space); +} + /* .doc table.tableblock, .doc th.tableblock, .doc td.tableblock { @@ -517,6 +529,10 @@ ul ul ul { margin: 0; } +.hdlist table .hdlist1 + .hdlist2 p { + margin-left: var(--base-space); +} + .doc pre:not(.highlight), .doc pre.highlight code { /* background-color: #151514; */ From c4e45e1c9a371786091502efc1f3dfe4c0e0164a Mon Sep 17 00:00:00 2001 From: bindaasrakesh Date: Mon, 13 Jul 2020 15:55:33 +0530 Subject: [PATCH 2/6] Regression testing on live site and fixes the bug for landing page and mobile UI --- src/css/doc.css | 19 ++++++++++++++++--- src/js/01-nav.js | 12 ++++++------ 2 files changed, 22 insertions(+), 9 deletions(-) diff --git a/src/css/doc.css b/src/css/doc.css index f5eedbb7..c88be9f5 100644 --- a/src/css/doc.css +++ b/src/css/doc.css @@ -416,7 +416,7 @@ ul ul ul { } .doc .imageblock img { - display: block; + display: inline-block; } .doc .imageblock .title { @@ -442,7 +442,7 @@ ul ul ul { width: auto; } -.doc .abstract blockquote { +.doc blockquote { font-size: 0.9375rem; margin: 1rem 0 1.5625rem 0; font-weight: var(--weight-light); @@ -450,7 +450,7 @@ ul ul ul { padding-left: 1.125rem; } -.doc .abstract blockquote * { +.doc blockquote * { font-weight: inherit; } /* .doc .abstract blockquote::before { @@ -1085,4 +1085,17 @@ table.tableblock pre code.language-bash.hljs { .doc h6 > a.anchor { font-size: 18px; } + + .card-row .column .content .imageblock { + text-align: center; + } + + .doc.landing-page-doc .media-left { + padding-left: 0; + text-align: center; + } + + main { + padding-bottom: 2rem; + } } diff --git a/src/js/01-nav.js b/src/js/01-nav.js index c5474f53..e206b7ff 100644 --- a/src/js/01-nav.js +++ b/src/js/01-nav.js @@ -143,14 +143,14 @@ function concealEvent (e) { e.stopPropagation() } - // scroll left menu to current active page - - var currentPageMenu = document.querySelector('.is-current-page') - var topPositon = currentPageMenu.offsetTop - var leftMenu = document.querySelector('.left-sidebar-menu .nav-menu') setTimeout(function () { - leftMenu.scrollTop = topPositon + if (document.querySelector('.is-current-page')) { + var currentPageMenu = document.querySelector('.is-current-page') + var topPositon = currentPageMenu.offsetTop + var leftMenu = document.querySelector('.left-sidebar-menu .nav-menu') + leftMenu.scrollTop = topPositon + } }, 200) // clearTimeout(scrollCurrentPageMenu, 20000) From 2876111aabeefe82f16e37073e6432608c3ece2f Mon Sep 17 00:00:00 2001 From: bindaasrakesh Date: Tue, 14 Jul 2020 11:12:06 +0530 Subject: [PATCH 3/6] Fix font size for code tag & table heading --- src/css/base.css | 11 ++++++++++- src/css/table.css | 8 ++++++-- 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/src/css/base.css b/src/css/base.css index b33545a3..c36b1627 100644 --- a/src/css/base.css +++ b/src/css/base.css @@ -64,11 +64,20 @@ pre { code { background-color: #0074e00e; - font-size: var(--font-small); + /* font-size: var(--font-small); */ + font-size: inherit; word-spacing: -0.125em; color: var(--color-brand-gray1); } +h2 code, +h3 code, +h4 code, +h5 code, +a code { + font-size: inherit; +} + html code { hyphens: none; } diff --git a/src/css/table.css b/src/css/table.css index 22b17a00..1bb403ed 100644 --- a/src/css/table.css +++ b/src/css/table.css @@ -40,11 +40,15 @@ table.tableblock thead th { padding-bottom: var(--base-space); text-align: left; border-bottom: 2px solid var(--color-brand-blue-secondary); - font-size: 1rem; - line-height: 1.25rem; + font-size: 1.125rem; + line-height: 1.5rem; font-weight: var(--weight-semibold); } +/* table.tableblock tbody td:first-child strong { + font-size: 1.125rem; +} */ + table.tableblock tbody tr { display: table-cell; } From b5c12ebea71faf39b763caa1679842923c596782 Mon Sep 17 00:00:00 2001 From: bindaasrakesh Date: Fri, 17 Jul 2020 17:16:38 +0530 Subject: [PATCH 4/6] Fix responsive image and video spacing issues --- src/css/doc.css | 5 ----- src/css/landing-page.css | 5 +++++ 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/css/doc.css b/src/css/doc.css index de57f46e..338752b3 100644 --- a/src/css/doc.css +++ b/src/css/doc.css @@ -1116,11 +1116,6 @@ table.tableblock pre code.language-bash.hljs { text-align: center; } - .doc.landing-page-doc .media-left { - padding-left: 0; - text-align: center; - } - main { padding-bottom: 2rem; } diff --git a/src/css/landing-page.css b/src/css/landing-page.css index bfa2f74a..4fa36ddc 100644 --- a/src/css/landing-page.css +++ b/src/css/landing-page.css @@ -397,4 +397,9 @@ padding-left: 0; padding-right: 0; } + + .doc.landing-page-doc .media-left { + padding-left: 0; + text-align: center; + } } From 43216756a4a66ab2ebe30fe125d04cf0ab55012b Mon Sep 17 00:00:00 2001 From: bindaasrakesh Date: Mon, 20 Jul 2020 22:25:48 +0530 Subject: [PATCH 5/6] Fix mobile menu overlap with left menu and footer content --- src/css/header.css | 9 ++++++++- src/css/nav.css | 2 +- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/css/header.css b/src/css/header.css index 46315159..3007bdf4 100644 --- a/src/css/header.css +++ b/src/css/header.css @@ -1,5 +1,11 @@ -.navbar-new-top { +.header-top-row { background: var(--color-brand-white); + padding: 0 var(--width-container-gutter); +} + +.header-top-row .container { + padding-left:0; + padding-right: 0; } .navbar-brand img { @@ -305,5 +311,6 @@ display: block; position: absolute; width: 100%; + left: 0; } } diff --git a/src/css/nav.css b/src/css/nav.css index a18ccf9b..d4634ec8 100644 --- a/src/css/nav.css +++ b/src/css/nav.css @@ -7,7 +7,7 @@ scrollbar-width: thin; scrollbar-color: var(--color-border) transparent; height: 100%; - z-index: var(--z-index-nav); + z-index: 5; transition: all 0.1s; } From 7eeebef6d23fffd618f1e4cde65021660e713188 Mon Sep 17 00:00:00 2001 From: rakeshAlgo Date: Wed, 22 Jul 2020 10:38:14 +0530 Subject: [PATCH 6/6] Remove font size from code block --- src/css/base.css | 10 ---------- src/css/header.css | 2 +- src/css/landing-page.css | 7 ++----- 3 files changed, 3 insertions(+), 16 deletions(-) diff --git a/src/css/base.css b/src/css/base.css index 0e6cdf83..413780e6 100644 --- a/src/css/base.css +++ b/src/css/base.css @@ -64,20 +64,10 @@ pre { code { background-color: #0074e00e; - /* font-size: var(--font-small); */ - font-size: inherit; word-spacing: -0.125em; color: var(--color-brand-gray1); } -h2 code, -h3 code, -h4 code, -h5 code, -a code { - font-size: inherit; -} - html code { hyphens: none; } diff --git a/src/css/header.css b/src/css/header.css index 3007bdf4..35d71f5c 100644 --- a/src/css/header.css +++ b/src/css/header.css @@ -4,7 +4,7 @@ } .header-top-row .container { - padding-left:0; + padding-left: 0; padding-right: 0; } diff --git a/src/css/landing-page.css b/src/css/landing-page.css index 4fa36ddc..994093ab 100644 --- a/src/css/landing-page.css +++ b/src/css/landing-page.css @@ -370,6 +370,8 @@ .doc.landing-page-doc .media-left { margin-left: 0; + padding-left: 0; + text-align: center; } .doc.landing-page-doc figure { @@ -397,9 +399,4 @@ padding-left: 0; padding-right: 0; } - - .doc.landing-page-doc .media-left { - padding-left: 0; - text-align: center; - } }