Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Jul 31, 2015
  1. @abhinavdangeti @chiyoung

    Print error message when unknown dcp op received

    abhinavdangeti authored chiyoung committed
    Change-Id: Iafb1b328a575edf56aa4886e0208d8316bd36979
    Reviewed-on: http://review.couchbase.org/53978
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
    Tested-by: Chiyoung Seo <chiyoung@couchbase.com>
  2. @abhinavdangeti @chiyoung

    ep_testsuite: Use std::string for dcp_last_meta

    abhinavdangeti authored chiyoung committed
    Replacing the manually managed char* with std::string,
    ensures there'd be error-free memory management.
    
    Change-Id: I6901f94b9ad785a22ee4d66028579db0f65ea950
    Reviewed-on: http://review.couchbase.org/53977
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
    Tested-by: Chiyoung Seo <chiyoung@couchbase.com>
  3. @manudhundi @chiyoung

    MB-13910: Refactor flow control code

    manudhundi authored chiyoung committed
    Create flow control class and flow control manager class.
    Change-Id: I473dc553b12ef8512ac47fb898f3e311e8e53c0c
    Reviewed-on: http://review.couchbase.org/52991
    Tested-by: buildbot <build@couchbase.com>
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
  4. @abhinavdangeti @chiyoung

    Refactor variable names to describe intention

    abhinavdangeti authored chiyoung committed
    Context:
    enableNoop --> pendingEnableNoop
    sendNoopInterval --> pendingSendNoopInterval
    setPriority --> pendingSetPriority
    enableExtMetaData --> pendingEnableExtMetaData
    
    Change-Id: I81d5d46af82d05ecb6f5971e488b4211c797a8b2
    Reviewed-on: http://review.couchbase.org/53959
    Tested-by: buildbot <build@couchbase.com>
    Reviewed-by: Dave Rigby <daver@couchbase.com>
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
  5. @abhinavdangeti @chiyoung

    Refactoring in tests/mock/mock_dcp.cc

    abhinavdangeti authored chiyoung committed
    sizeof(uint8_t) = 1, no matter the platform
    Replacing, 'sizeof(uint8_t) * x' with 'x'
    
    Change-Id: I8b8b5a30eefe0e104a6b36c165c296c1cc51f427
    Reviewed-on: http://review.couchbase.org/53958
    Tested-by: buildbot <build@couchbase.com>
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Commits on Jul 30, 2015
  1. @manudhundi

    MB-14987: Update the test case test_failover_log_dcp.

    manudhundi authored
    This tests the DCP producer behavior regarding rollbacks.
    Increase the test coverage by adding more cases and add comments
    to the test case
    Change-Id: I771d1bf53eca8dbe84887fdacd43bf6bfa8d065b
    Reviewed-on: http://review.couchbase.org/53899
    Tested-by: buildbot <build@couchbase.com>
    Reviewed-by: abhinav dangeti <abhinav@couchbase.com>
    Tested-by: Manu Dhundi <manu@couchbase.com>
  2. @daverigby @chiyoung

    Enable CB_FORMAT_PRINTF on LOG(), fix warnings

    daverigby authored chiyoung committed
    As LOG() takes a printf-style format string, annotate it with the
    CB_FORMAT_PRINTF macro which enables compiler warnings on mismatches
    between the format string and arguments. Fix all the usage errors in
    ep-engine flagged by this.
    
    Change-Id: Ie9a46caf5fd7ba182b61e6078e49f30a8cab1aa7
    Reviewed-on: http://review.couchbase.org/53874
    Tested-by: buildbot <build@couchbase.com>
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Commits on Jul 29, 2015
  1. @chiyoung

    Merge remote-tracking branch 'couchbase/sherlock'

    chiyoung authored
    * couchbase/sherlock:
      MB-15837 Fix to tap_notify_set_vbucket_state unit test.
      MB-15837 Generate a new vbucket UUID for TAP-based VBucket takeover.
    
    Change-Id: I3e806129d48087ffe139cd230fad4a06e6996094
Commits on Jul 28, 2015
  1. @chiyoung

    Merge remote-tracking branch 'couchbase/3.0.x' into sherlock

    chiyoung authored
    * couchbase/3.0.x:
      MB-15837 Fix to tap_notify_set_vbucket_state unit test.
      MB-15837 Generate a new vbucket UUID for TAP-based VBucket takeover.
    
    Change-Id: I7fceedd75a861250d2a3a2d56b0a3535cdef1d84
  2. @chiyoung

    MB-15837 Fix to tap_notify_set_vbucket_state unit test.

    chiyoung authored chiyoung committed
    Change-Id: Ia7af2243a41b86987a76f06b1b1e30dda6a479b0
    Reviewed-on: http://review.couchbase.org/53834
    Tested-by: buildbot <build@couchbase.com>
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
  3. @abhinavdangeti @chiyoung

    [Unittest] Add a test case that demonstrates snappy behavior

    abhinavdangeti authored chiyoung committed
    Change-Id: Ia10934e104807c38ba1bfab439916f5660ee575d
    Reviewed-on: http://review.couchbase.org/53816
    Tested-by: buildbot <build@couchbase.com>
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
  4. @manudhundi @chiyoung

    MB-14987: Modify DCP Rollback code logic to make it more structured

    manudhundi authored chiyoung committed
    Change-Id: I5c31f6ca66dac97aac5e4d291d6e85d299d6c212
    Reviewed-on: http://review.couchbase.org/53763
    Tested-by: buildbot <build@couchbase.com>
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
  5. @chiyoung

    MB-15837 Generate a new vbucket UUID for TAP-based VBucket takeover.

    chiyoung authored chiyoung committed
    A new vbucket UUID should be generated for each TAP-based vbucket takeover
    completion. Otherwise, it can cause potential data loss after fully
    switching from TAP to DCP, because TAP-based replication doesn't synchronize
    sequence numbers between active and replica vbuckets.
    
    For more details, please refer to
    https://issues.couchbase.com/browse/MB-15837
    
    Change-Id: Id8931bd110417065b244f10c71e18d0b5d47f6d2
    Reviewed-on: http://review.couchbase.org/53784
    Tested-by: buildbot <build@couchbase.com>
    Reviewed-by: abhinav dangeti <abhinav@couchbase.com>
  6. @chiyoung

    Merge "Merge remote-tracking branch 'couchbase/sherlock'"

    chiyoung authored Gerrit Code Review committed
  7. @abhinavdangeti

    Minor refactoring in dcp producer code

    abhinavdangeti authored
    String compare complying with C++ standards.
    
    Change-Id: I2ab1ccf08bc1b11da101e819476b6aa466083733
    Reviewed-on: http://review.couchbase.org/53811
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
    Tested-by: buildbot <build@couchbase.com>
  8. @abhinavdangeti @chiyoung

    Minor refactoring in dcp consumer code

    abhinavdangeti authored chiyoung committed
    Use a constructor instead of assigning, this
    saves a default initializing of std::string.
    
    Change-Id: I04fd05fbf84b398760e26a4d37d0c0507d62c1cc
    Reviewed-on: http://review.couchbase.org/53810
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
    Tested-by: buildbot <build@couchbase.com>
  9. @manudhundi

    Merge remote-tracking branch 'couchbase/sherlock'

    manudhundi authored
    Change-Id: Ife150d1b5d2b13d07912c71c3987225826cdb1d9
  10. @abhinavdangeti @chiyoung

    Handling the race between flusher and snapshot tasks

    abhinavdangeti authored chiyoung committed
    If a snapshot task hasn't run when the first flusher
    task runs, and there is no entry in cachedVBStates,
    at this point rather than asserting, retry the flush
    operation after the VBStatePersistTask.
    
    Change-Id: I61f9abb1d240050531854b27686af8df209c726c
    Reviewed-on: http://review.couchbase.org/53687
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
    Tested-by: Chiyoung Seo <chiyoung@couchbase.com>
  11. @chiyoung

    Merge remote-tracking branch 'couchbase/3.0.x'

    chiyoung authored
    * couchbase/3.0.x:
      MB-15826: Handle lower values of snap_st_seqno by DCP client more effectively
    
    Change-Id: I49d616ccf9bae07c1c1bc711290297b9fd9fe372
  12. @manudhundi @chiyoung

    MB-15874: Have sufficient size for dcp stream stats buffer

    manudhundi authored chiyoung committed
    Increase the dcp stream stats buffer size from 128 bytes to 1024 bytes.
    
    Change-Id: I979f599c5f915b14b895fff798e4cdf5bddc233c
    Reviewed-on: http://review.couchbase.org/53773
    Tested-by: buildbot <build@couchbase.com>
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Commits on Jul 27, 2015
  1. @manudhundi @chiyoung

    MB-15826: Handle lower values of snap_st_seqno by DCP client more eff…

    manudhundi authored chiyoung committed
    …ectively
    
    If a DCP client passes snap_st_seqno < start_seqno when
    start_seqno == snap_end_seqno, then DCP can be more efficient by setting
    snap_start_seqno = start_seqno.
    Change-Id: Ie59cfed23e9e3855ef0eca6d3b609a53db65c36f
    Reviewed-on: http://review.couchbase.org/53635
    Tested-by: buildbot <build@couchbase.com>
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Commits on Jul 24, 2015
  1. @abhinavdangeti @chiyoung

    [Unittest] Update to test_exp_persisted_set_del

    abhinavdangeti authored chiyoung committed
    Ensure that we check all the sets and deletes
    are persisted in the above mentioned test.
    
    Change-Id: I8ef9e4a71c9e0f84c0fdc5963619200b77338fd9
    Reviewed-on: http://review.couchbase.org/53677
    Tested-by: buildbot <build@couchbase.com>
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
  2. @jimwwalker @chiyoung

    Join all executorpool threads on shutdown.

    jimwwalker authored chiyoung committed
    This primarily improves the stability of some unit tests that
    call reload_engine, unloading ep.so whilst threads are still
    running could cause a variety of issues.
    
    This change also ensures we have a clean and proper shutdown.
    
    Change-Id: Ib43a28c2bfc258d3dc9df63c6d9cf01f80c63f4b
    Reviewed-on: http://review.couchbase.org/53666
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
    Tested-by: Chiyoung Seo <chiyoung@couchbase.com>
  3. @abhinavdangeti @chiyoung

    [Unittest-slowdisk] Fix to test_exp_persisted_set_del

    abhinavdangeti authored chiyoung committed
    Rather than waiting for curr items to become zero
    (which is updated by persistence callback - flusher),
    wait for expired items to become 1 (set by the expiry
    pager / by access).
    
    Change-Id: I54b3d219004c3466a393f615284ea733c8ef3513
    Reviewed-on: http://review.couchbase.org/53636
    Tested-by: buildbot <build@couchbase.com>
    Reviewed-by: Sundararaman Sridharan <sundar@couchbase.com>
Commits on Jul 23, 2015
  1. @abhinavdangeti @chiyoung

    [Unittest-slowdisk] Fix testcase expiry_duplicate_warmup

    abhinavdangeti authored chiyoung committed
    Wait for flusher to settle before warming up vbucket
    to ensure that the item has actually persisted and
    that warmup will be able to load it back into memory.
    
    Change-Id: I86c85a099d1ef0888720b6f69937361dfab11c69
    Reviewed-on: http://review.couchbase.org/53630
    Reviewed-by: Sundararaman Sridharan <sundar@couchbase.com>
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
    Tested-by: Chiyoung Seo <chiyoung@couchbase.com>
  2. @abhinavdangeti @chiyoung

    [Unittest-slowdisk] Fix test_dcp_cursor_dropping

    abhinavdangeti authored chiyoung committed
    Consider the case where the dcp cursors weren't
    dropped as the persistence cursor was too slow
    (because of a slow disk) causing the stream to
    close only after all items have been received.
    
    Change-Id: Id0e04536922b25234289b83b6faea5db03076f64
    Reviewed-on: http://review.couchbase.org/53627
    Tested-by: buildbot <build@couchbase.com>
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
  3. @abhinavdangeti @chiyoung

    MB-9897: Add a stat that tracks number of dropped cursors

    abhinavdangeti authored chiyoung committed
    Change-Id: Id3fce7daab01ea162385ae3715f625715bcf5e60
    Reviewed-on: http://review.couchbase.org/53626
    Tested-by: buildbot <build@couchbase.com>
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
  4. @abhinavdangeti @chiyoung

    [Unittest-slowdisk] Fix test_est_vb_move

    abhinavdangeti authored chiyoung committed
    Wait for flusher to settle after checking the
    estimate from taptakeover stats. This would avoid
    the situtation where wait_for_flusher_to_settle
    takes too long on a slow disk, and after that the
    number of open checkpoint items is different because
    the checkpoint was closed.
    
    Change-Id: Idadaa341270cd21b1fb502b6e67fd482df6bb665
    Reviewed-on: http://review.couchbase.org/53625
    Tested-by: buildbot <build@couchbase.com>
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
  5. @abhinavdangeti @chiyoung

    Consistent naming for stats: dcp/tap_vb_takeover

    abhinavdangeti authored chiyoung committed
    Context:
    dcp-takeover --> dcp-vbtakeover
    tap-takeover --> tap-vbtakeover
    
    Change-Id: I9ba0d5380e6e15f43ebb7b73deee8a961ad38c7b
    Reviewed-on: http://review.couchbase.org/53624
    Tested-by: buildbot <build@couchbase.com>
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
  6. @abhinavdangeti @chiyoung

    [Unittest-slowdisk] Fix test_expiration_on_warmup test case

    abhinavdangeti authored chiyoung committed
    Disable the expiry pager during the initial part
    of the test to ensure that expiry pager doesn't
    remove an item before flusher settles on a very
    slow disk.
    
    Change-Id: I878f3eb81c4bbc7373bee90878344f084657c9b5
    Reviewed-on: http://review.couchbase.org/53623
    Tested-by: abhinav dangeti <abhinav@couchbase.com>
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
  7. @hisundar @chiyoung

    Switch to hrtime from timeval in Global Thread Pool

    hisundar authored chiyoung committed
    This has small improvements in memory and cpu usage.
    Also fixes several ThreadSanitizer races from unit tests.
    
    Change-Id: I78fdddb832251fc062058c04f75f8d22c4c2f68d
    Reviewed-on: http://review.couchbase.org/53381
    Tested-by: buildbot <build@couchbase.com>
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
  8. @abhinavdangeti @chiyoung

    Refactoring DCP consumer code

    abhinavdangeti authored chiyoung committed
    Use std::string to determine the length as opposed
    to hard coding in the length.
    
    Change-Id: I48f508190b02de0854b298a6019bffe79681eee0
    Reviewed-on: http://review.couchbase.org/53511
    Tested-by: buildbot <build@couchbase.com>
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Commits on Jul 22, 2015
  1. @abhinavdangeti

    Merge remote-tracking branch 'couchbase/sherlock'

    abhinavdangeti authored
    couchbase/sherlock:
    * MB-15757: Upon merging checkpoints, update snapshot start
    
    Change-Id: I9d1f8dbcdf59021707a54f49a3c3b2804b9e5375
  2. @abhinavdangeti @chiyoung

    MB-15757: Upon merging checkpoints, update snapshot start

    abhinavdangeti authored chiyoung committed
    After merging the previous checkpoint to the current
    checkpoint, the snapshot start of the current checkpoint
    needs to be updated with the first item of the current
    checkpoint as new items are added into this checkpoint
    from the previous checkpoint.
    
    Change-Id: Ieae30e45f3733a8f0bcc3563c14ee1566a9b395c
    Reviewed-on: http://review.couchbase.org/53565
    Tested-by: buildbot <build@couchbase.com>
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
  3. @trondn @chiyoung

    Add build support with VS2015 Community Edition

    trondn authored chiyoung committed
    Change-Id: I5a7527f31c809504a7693092951afad6c69afa46
    Reviewed-on: http://review.couchbase.org/53547
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
    Tested-by: Chiyoung Seo <chiyoung@couchbase.com>
Something went wrong with that request. Please try again.