MB-28734 : make cancelTimer() return true on success, false if timer

is not found and exception otherwise.

Change-Id: I7c4b59f9238c9903a91ebdedfc46a7748f952a55
Reviewed-on: http://review.couchbase.org/c/eventing/+/127363
Reviewed-by: CI Bot
Reviewed-by: <ankit.prabhu@couchbase.com>
Reviewed-by: Jeelan Basha Poola <jeelan.poola@couchbase.com>
Tested-by: Jeelan Basha Poola <jeelan.poola@couchbase.com>

v8_consumer/src/timer.cc

@@ -121,11 +121,16 @@ bool Timer::CancelTimerImpl(const v8::FunctionCallbackInfo<v8::Value> &args) {
   FillTimerPartition(timer_info);
 
   auto err = v8worker->DelTimer(timer_info);
-  if (err != LCB_SUCCESS) {
+
+  if (err == LCB_SUCCESS) {
+    args.GetReturnValue().Set(true);
+  } else if (err == LCB_KEY_ENOENT) {
+    args.GetReturnValue().Set(false);
+  } else {
     js_exception->ThrowKVError(v8worker->GetTimerLcbHandle(), err);
     return false;
   }
-  args.GetReturnValue().Set(v8Str(isolate_, timer_info.reference));
+
   return true;
 }