Permalink
Commits on Jul 19, 2017
  1. MB-25293: NOOP response to be an MCResponse

    + Add support to transmit the response for an UPR_NOOP
      as an MCResponse which the server expects rather than
      an MCRequest.
    + Requires: http://review.couchbase.org/#/c/81124/
    
    Change-Id: Idaf3222de85a756925ba1c8f820f9836bf9f2e96
    Reviewed-on: http://review.couchbase.org/81125
    Reviewed-by: Adam Fraser <adam.fraser@couchbase.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: abhinav dangeti <abhinav@couchbase.com>
    abhinavdangeti committed with abhinavdangeti Jul 19, 2017
Commits on Jul 18, 2017
  1. MB-25293: Set default of NoopTimeIntervalSecs to 120

    + Per DCP documentation.
    
    Change-Id: I2a9ea12f1602bba9ab3233a8dd56e584b2b30a15
    Reviewed-on: http://review.couchbase.org/80974
    Reviewed-by: Adam Fraser <adam.fraser@couchbase.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: abhinav dangeti <abhinav@couchbase.com>
    abhinavdangeti committed with abhinavdangeti Jul 18, 2017
Commits on Jul 12, 2017
  1. MB-24975: Enable noop before setting the interval

    Per DCP documentation, enabling noop messages is a
    2 step procedure:
    1. Control message to enable noop
    2. Control message to set the noop interval
    
    Change-Id: I01a4a7a698ca418f7e504cf1483158d1562f8b64
    Reviewed-on: http://review.couchbase.org/80603
    Tested-by: abhinav dangeti <abhinav@couchbase.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    abhinavdangeti committed with abhinavdangeti Jul 12, 2017
Commits on Jul 6, 2017
  1. MB-24975: cbdatasource to enable DCP NO-OPs

    + Set the control message 'set_noop_interval' to
      enable the DCP producer to send NO-OP messages
      to the cbdatasource consumer.
    + The default options to set this to a server
      default of 1 second.
    
    Change-Id: I423298950bd9ace3d9e53eb10d7d082cfd311aed
    Reviewed-on: http://review.couchbase.org/80032
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: abhinav dangeti <abhinav@couchbase.com>
    abhinavdangeti committed with abhinavdangeti Jun 26, 2017
  2. MB-24661: Adding new Bucket API to detect rebalance

    API: NodeListChanged() - Returns true if in the case
    of a rebalance having occurred since the last update
    to Bucket.nodesList.
    
    Change-Id: If6dda61a9f93465669d083d53809c19e015601e0
    Reviewed-on: http://review.couchbase.org/79985
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: abhinav dangeti <abhinav@couchbase.com>
    abhinavdangeti committed with abhinavdangeti Jun 24, 2017
Commits on Jul 5, 2017
  1. MB-24429. Pass the request timeout to Fetch

    Change-Id: I4a6b7b0e149ba40b7cf0612c3a6dc4e796e290e1
    Reviewed-on: http://review.couchbase.org/79818
    Reviewed-by: Marco Greco <marco.greco@couchbase.com>
    Reviewed-by: Johan Larson <johan.larson@couchbase.com>
    Tested-by: Sitaram Vemulapalli <sitaram.vemulapalli@couchbase.com>
    sitaramv committed with sitaramv Jun 21, 2017
Commits on Jun 25, 2017
  1. MB-25021. fix panic

    Change-Id: Icb4e8465b2b1837bb3147e0e2ff9b3b9245bdffb
    Reviewed-on: http://review.couchbase.org/80003
    Reviewed-by: Sitaram Vemulapalli <sitaram.vemulapalli@couchbase.com>
    Tested-by: Sitaram Vemulapalli <sitaram.vemulapalli@couchbase.com>
    sitaramv committed with sitaramv Jun 25, 2017
Commits on Jun 14, 2017
  1. MB-24752. Retry Out Of Bounds Opaque

    Change-Id: I7b43f7c090c6a6e934a3a571b626ae74311f3bab
    Reviewed-on: http://review.couchbase.org/79374
    Reviewed-by: Marco Greco <marco.greco@couchbase.com>
    Tested-by: Sitaram Vemulapalli <sitaram.vemulapalli@couchbase.com>
    sitaramv committed with sitaramv Jun 12, 2017
Commits on Jun 12, 2017
  1. MB-24456 - Making error details less verbose

    Reducing verbosity of err details
    
    Change-Id: Ia807c25b3e12997a03df22e396066508a75b419f
    Reviewed-on: http://review.couchbase.org/79355
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Sreekanth Sivasankaran
    sreekanth-cb committed with Sreekanth Sivasankaran Jun 12, 2017
Commits on Jun 8, 2017
  1. MB-24637 set correct domain for configured administrator

    Change-Id: Id02498a4f6e71379f3c83b65098cff11d84010f7
    Reviewed-on: http://review.couchbase.org/79250
    Reviewed-by: Marco Greco <marco.greco@couchbase.com>
    Tested-by: Johan Larson <johan.larson@couchbase.com>
    j-larson committed with j-larson Jun 8, 2017
Commits on Jun 2, 2017
  1. MB-24429. Disable timeout temporarly

    Change-Id: Ia5008a8b54a53d06f2b12ec0fc75e3c73da69d91
    Reviewed-on: http://review.couchbase.org/78980
    Reviewed-by: Sitaram Vemulapalli <sitaram.vemulapalli@couchbase.com>
    Tested-by: Sitaram Vemulapalli <sitaram.vemulapalli@couchbase.com>
    sitaramv committed with sitaramv Jun 2, 2017
Commits on May 26, 2017
  1. MB-24429 Add Error function

    Change-Id: I84702cd202f6d2b71a08fa16fad28f0bccaabcb2
    Reviewed-on: http://review.couchbase.org/78656
    Reviewed-by: Marco Greco <marco.greco@couchbase.com>
    Tested-by: Sitaram Vemulapalli <sitaram.vemulapalli@couchbase.com>
    sitaramv committed with sitaramv May 26, 2017
Commits on May 19, 2017
  1. MB-24429 Add timeout while reading from KV

    Change-Id: Icadabbd216c73e0a937fa75f1c08b6a212cf0007
    Reviewed-on: http://review.couchbase.org/78271
    Reviewed-by: Johan Larson <johan.larson@couchbase.com>
    Reviewed-by: Marco Greco <marco.greco@couchbase.com>
    Tested-by: Sitaram Vemulapalli <sitaram.vemulapalli@couchbase.com>
    sitaramv committed with sitaramv May 17, 2017
Commits on May 8, 2017
  1. MB-23858 add configured administrator to user_info and my_user_info t…

    …ables
    
    Change-Id: I8adce2ccbafe461b0a1f0827320771bba3696f1e
    Reviewed-on: http://review.couchbase.org/77828
    Reviewed-by: Sitaram Vemulapalli <sitaram.vemulapalli@couchbase.com>
    Tested-by: Johan Larson <johan.larson@couchbase.com>
    j-larson committed with j-larson May 8, 2017
Commits on May 6, 2017
  1. MB-24254 - fts crashes after bucket flush

    Adding out of bound checks
    
    Change-Id: I200fe8a1d36d654161918e89eeea195e1a75f39b
    Reviewed-on: http://review.couchbase.org/77800
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Sreekanth Sivasankaran
    sreekanth-cb committed with Sreekanth Sivasankaran May 6, 2017
Commits on May 4, 2017
  1. Only SelectBucket when username!=bucketname

    Change-Id: Id6393407ba74c3dd622d1860720a4e4c6e8698bd
    Reviewed-on: http://review.couchbase.org/77685
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Adam Fraser <adam.fraser@couchbase.com>
    adamcfraser committed with adamcfraser May 3, 2017
Commits on May 3, 2017
  1. MB-24201 - cbdatasource use better HELO name

    Changed to more meaningful 'HELO' name
    
    Change-Id: I3708b3c411568357aa894b45a62f15fce39ac6e3
    Reviewed-on: http://review.couchbase.org/77656
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Sreekanth Sivasankaran
    sreekanth-cb committed with Sreekanth Sivasankaran May 3, 2017
Commits on May 2, 2017
  1. MB-21934 - Taking vbucket UUID into partial rollbacks

    Adding a new interface for the new RollbackEx method
    with vBucketUUID information
    
    Change-Id: Ia6df9b432fab0bb9e14ff22370739af3124c1bdb
    Reviewed-on: http://review.couchbase.org/77178
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Reviewed-by: Marty Schoch <marty.schoch@gmail.com>
    Tested-by: Sreekanth Sivasankaran
    sreekanth-cb committed with Sreekanth Sivasankaran Apr 21, 2017
Commits on Apr 29, 2017
  1. MB-24105 - cbdatasource needs to SelectBucket

    Added SelectBucket call before UPROpen
    Added XERROR flag in HELO handshake
    Added HELO handshaket to UPROpen call
    Refactoring the handshake part
    Code cleanup
    
    Change-Id: I4b841c884f997d71dea47cb4af78e2c2b80e61e7
    Reviewed-on: http://review.couchbase.org/77420
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Sreekanth Sivasankaran
    sreekanth-cb committed with Sreekanth Sivasankaran Apr 27, 2017
Commits on Apr 26, 2017
  1. MB-24092. Check nill pointer

    Change-Id: I1b544c93d41d268ac9c7efebd066ea8024352e93
    Reviewed-on: http://review.couchbase.org/77379
    Reviewed-by: Isha Kandaswamy <isha@couchbase.com>
    Tested-by: Sitaram Vemulapalli <sitaram.vemulapalli@couchbase.com>
    sitaramv committed with sitaramv Apr 26, 2017
Commits on Apr 20, 2017
  1. MB-23773 use updated user domains rather than type field

    Change-Id: I41e3177fb103228319ed9d0d5a729384586c3701
    Reviewed-on: http://review.couchbase.org/77122
    Reviewed-by: Marco Greco <marco.greco@couchbase.com>
    Tested-by: Johan Larson <johan.larson@couchbase.com>
    j-larson committed with j-larson Apr 20, 2017
Commits on Mar 30, 2017
  1. MB-23555 shouldn't try to access ddocs for ephemeral buckets

    there's no ddocs uri for ephemeral buckets - accessing returns errors.
    just return empty ddocs instead.
    
    Change-Id: I9479017d2045b761578f446dce7da3d875c702e4
    Reviewed-on: http://review.couchbase.org/76032
    Reviewed-by: Sitaram Vemulapalli <sitaram.vemulapalli@couchbase.com>
    Tested-by: Marco Greco <marco.greco@couchbase.com>
    marcogrecopriolo committed with marcogrecopriolo Mar 30, 2017
Commits on Mar 24, 2017
  1. MB-23346 - cbgt/cbdatasource should support XATTRS

    Adding DataType Bytes to dcp connection 'Helo' handshake
    
    Change-Id: Ia8af6b57fde8803c191ecc613f1d632c475d3f1a
    Reviewed-on: http://review.couchbase.org/75660
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Sreekanth Sivasankaran
    sreekanth-cb committed with Sreekanth Sivasankaran Mar 24, 2017
Commits on Mar 22, 2017
  1. MB-23346 - cbgt / cbdatasource should support XATTRS

    Adding the XATTRS flag to open dcp connection
    Added the 'HELLO' handshake and error handling
    for pre-spoke builds
    Added logging for errors
    golanging the code, break on nw errors
    
    Change-Id: Icea7113584468cd433799808a44165e1f43728db
    Reviewed-on: http://review.couchbase.org/75469
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Sreekanth Sivasankaran
    sreekanth-cb committed with Sreekanth Sivasankaran Mar 21, 2017
Commits on Mar 14, 2017
  1. MB-23256 create Go API for getting all defined roles

    Change-Id: I2d507724cf02c402c11363d7a5fb0a74236b67bc
    Reviewed-on: http://review.couchbase.org/75069
    Reviewed-by: Marco Greco <marco.greco@couchbase.com>
    Reviewed-by: Gerald Sangudi <gerald@couchbase.com>
    Tested-by: Johan Larson <johan.larson@couchbase.com>
    j-larson committed with j-larson Mar 13, 2017
Commits on Mar 9, 2017
  1. MB-23168 treat builtin and saslauth differently on update

    Change-Id: Iad80db4d75b71a687d22b7a484420637836b4dd8
    Reviewed-on: http://review.couchbase.org/74915
    Reviewed-by: Sitaram Vemulapalli <sitaram.vemulapalli@couchbase.com>
    Tested-by: Johan Larson <johan.larson@couchbase.com>
    j-larson committed with j-larson Mar 9, 2017
Commits on Mar 2, 2017
  1. MB-22656 n1ql nodes don't determine their own name correctly

    This is the go-couchbase side of clustering fixes - we need the services
    hosted in each node (whether they are up or not).
    
    This will support system:nodes, and is also needed in order to help n1ql
    nodes determine their own name: they need to see what is supposed to run
    in each node rather what is actually runnig, because ns_server does not
    populate the ports until it decides that the nodes are healthy, which is
    only way after the node has been initialized
    
    Change-Id: Iae270ccf08f78ce8fdb3195bcb7b08943671e11c
    Reviewed-on: http://review.couchbase.org/74533
    Reviewed-by: Sitaram Vemulapalli <sitaram.vemulapalli@couchbase.com>
    Reviewed-by: Johan Larson <johan.larson@couchbase.com>
    Tested-by: Marco Greco <marco.greco@couchbase.com>
    marcogrecopriolo committed with marcogrecopriolo Mar 2, 2017
Commits on Dec 29, 2016
  1. MB-20493 - cbdatasource empties workerCh before performing kick

    The sequence of events is the refresh-cluster goroutine (kinda like a
    manager) is trying to inform 1 or more worker goroutines of which
    vbuckets they're each responsible for.  (Each worker goroutine
    connects to a different DCP server.)
    
    The refresh-cluster goroutine does this by sending a message to the
    workerCh of each worker.
    
    Unfortunately, a worker might have gotten into a situation (X) where
    it's trying to contact a DCP server that's been rebalanced out of the
    cluster, and the DCP server is responding with auth-failure responses.
    So, that means the worker goroutine never gets around to reading from
    its workerCh.  In turn, the refresh-cluster goroutine becomes blocked
    trying to send to the workerCh.
    
    A possible "1-liner" fix would have been to just crank up the size of
    the workerCh's buffer, but then that feels hacky and hard to pick the
    right larger size.
    
    Instead, in an X situation, this fix has the worker just consume and
    throw away all the messages on its workerCh before kicking the manager
    for a requested top-down "refresh cluster".  There might be more
    places where this is needed, so there might be more forthcoming code
    changes, but for now, attempting a "light touch" on the code impact.
    
    Change-Id: Iab58e14d02203839a6f95c9dcf968c573f609b75
    Reviewed-on: http://review.couchbase.org/71397
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
    steveyen committed Dec 29, 2016
Commits on Dec 22, 2016
  1. MB-20493 cbdatasource: refresh cluster on memcached auth error

    Found in a test case, during a swap rebalance, a cbdatasource worker
    would continue to try to talk to a node that was swap-rebalanced out,
    receiving an authentication error from cbauth.  This change propagates
    that as an asynchronous refresh cluster kick event, which forces a new
    cluster map to be retrieved, which will then shut down that worker.
    
    Change-Id: I9ed21a8ae2ef2a628d5fe5edbbfe266ca0768513
    Reviewed-on: http://review.couchbase.org/71197
    Reviewed-by: Marty Schoch <marty.schoch@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
    steveyen committed Dec 21, 2016
Commits on Dec 21, 2016
  1. MB-22079. Increase bulkget queue size.

    Change-Id: I05a032c3d10bf151ab262ba3f8473a6d1b3cefaa
    Reviewed-on: http://review.couchbase.org/71190
    Reviewed-by: Sitaram Vemulapalli <sitaram.vemulapalli@couchbase.com>
    Tested-by: Gerald Sangudi <gerald@couchbase.com>
    geraldss committed with geraldss Dec 21, 2016
Commits on Dec 14, 2016
  1. MB-21094 Add method to put user roles (for GRANT ROLES statement.)

    Change-Id: I7d4ddeedf9b31d04906d0187ecb662385c5c7558
    Reviewed-on: http://review.couchbase.org/70948
    Reviewed-by: Gerald Sangudi <gerald@couchbase.com>
    Tested-by: Johan Larson <johan.larson@couchbase.com>
    j-larson committed with j-larson Dec 14, 2016
Commits on Oct 17, 2016
  1. MB-21194 replace timeSynchronization bucket metadata with conflictRes…

    …olutionType
    
    Change-Id: I93383a915a5c571958339ef48f796f3c4bc11221
    Reviewed-on: http://review.couchbase.org/68820
    Reviewed-by: John Liang <johliang00@yahoo.com>
    Reviewed-by: Yu Sui <ysui68@gmail.com>
    Tested-by: Yu Sui <ysui68@gmail.com>
    Reviewed-on: http://review.couchbase.org/68843
    ysui6888 committed with Yu Sui Oct 17, 2016
Commits on Oct 5, 2016
  1. MB-21048 Add UserRoles() method.

    Change-Id: Id74546cfc0e92e9281d8a2a73a938ac735522d15
    Reviewed-on: http://review.couchbase.org/68401
    Reviewed-by: Gerald Sangudi <gerald@couchbase.com>
    Tested-by: Johan Larson <johan.larson@couchbase.com>
    j-larson committed with j-larson Oct 5, 2016
Commits on Sep 26, 2016
  1. MB-19585 Change Bucket to use an RWMutex rather than atomic operations.

    Change-Id: I568a74d1693da34216b103825c7c8f81f368ad3b
    Reviewed-on: http://review.couchbase.org/67919
    Reviewed-by: Sitaram Vemulapalli <sitaram.vemulapalli@couchbase.com>
    Reviewed-by: Gerald Sangudi <gerald@couchbase.com>
    Tested-by: Johan Larson <johan.larson@couchbase.com>
    j-larson committed with j-larson Sep 22, 2016
Commits on Sep 8, 2016
  1. MB-20841 - cbdatasource: more checking of vbucketmap int indexes

    Change-Id: Ibf0d53ff986a2975df6045815a50d07ea39b7dab
    Reviewed-on: http://review.couchbase.org/67505
    Reviewed-by: Marty Schoch <marty.schoch@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
    steveyen committed Sep 8, 2016