Skip to content
Commits on Apr 10, 2012
  1. @avsej @ingenthr

    Update meta for release 1.1.0dp2

    avsej committed with ingenthr
    The shared object should be 1.3.1 and the library version number should be
    set to 1.1.0dp2
    
    Change-Id: I6b0fc461ba43d2f6cf2255222cf9c512d0b25d1e
    Reviewed-on: http://review.couchbase.org/14722
    Tested-by: Sergey Avseyev <sergey.avseyev@gmail.com>
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
  2. @avsej @ingenthr

    Don't wait for empty buffers (CCBC-59)

    avsej committed with ingenthr
    libcouchbase_wait() blocks forever if there is nothing queued
    
    Very simply, if you call libcouchbase_wait() without queuing some operation
    first (e.g store a key/value, arithmetic, etc...) the call to
    libcouchbase_wait() never returns.
    
    This means that a single threaded application that calls libcouchbase_wait()
    at different times to make sure operations are sent to the server runs the
    risk of stalling indefinitely. This is a very likely scenario.
    
    Change-Id: I9cf0d8e655f5bd076a87183d3e77e7eb22582305
    Reviewed-on: http://review.couchbase.org/14696
    Tested-by: Sergey Avseyev <sergey.avseyev@gmail.com>
    Reviewed-by: Mordechai Nunberg <mnunberg@haskalah.org>
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
  3. @avsej @ingenthr

    Don't define size_t and ssize_t for VS2008

    avsej committed with ingenthr
    https://groups.google.com/d/topic/couchbase/d_vdVruDfGE/discussion
    
    Change-Id: Ie8a46f14063c42803fab538403de409ade004407
    Reviewed-on: http://review.couchbase.org/14642
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
Commits on Apr 9, 2012
  1. @avsej

    Fix segfault while authorizing on protected buckets

    avsej committed
    Minimal working example
    =======================
    
    test.c
    ------
    
      #define _FORTIFY_SOURCE 2
      #include <stdio.h>
      #include <string.h>
      #include <stdlib.h>
    
      struct sasl {
          const char *name;
          union {
              struct {
                  unsigned long len;
                  unsigned char data[1];
              } secret;
              char buffer[256];
          } password;
          void *callbacks[4];
      };
    
      #define STACK_MKSASL struct sasl sasl_stack;
      #define STACK_SASL (&sasl_stack)
    
      #define HEAP_MKSASL  struct sasl *sasl_heap = malloc(sizeof(*sasl_heap))
      #define HEAP_SASL sasl_heap
    
      int main(void)
      {
          STACK_MKSASL;
          HEAP_MKSASL;
          const char *str = "secret";
          printf("GCCs __bos (For stack): 0x%lx\n", __bos(STACK_SASL->password.secret.data));
          printf("GCCs __bos (For heap): 0x%lx\n", __bos(HEAP_SASL->password.secret.data));
          strcpy((char*)STACK_SASL->password.secret.data, str);
          strcpy((char*)HEAP_SASL->password.secret.data, str);
          return 0;
      }
    
    $ gcc -O2 -o test test.c
    In file included from /usr/include/string.h:642:0,
                     from test.c:3:
    In function ‘strcpy’,
        inlined from ‘main’ at test.c:31:11:
    /usr/include/x86_64-linux-gnu/bits/string3.h:105:3: warning: call to __builtin___strcpy_chk will always overflow destination buffer [enabled by default]
    In function ‘strcpy’,
        inlined from ‘main’ at test.c:32:11:
    /usr/include/x86_64-linux-gnu/bits/string3.h:105:3: warning: call to __builtin___strcpy_chk will always overflow destination buffer [enabled by default]
    
    $ ./test
    GCCs __bos (For stack): 0x1
    GCCs __bos (For heap): 0x1
    *** buffer overflow detected ***: ./test terminated
    ======= Backtrace: =========
    /lib/x86_64-linux-gnu/libc.so.6(__fortify_fail+0x37)[0x7f1885534077]
    /lib/x86_64-linux-gnu/libc.so.6(+0xebf30)[0x7f1885532f30]
    ./test[0x400525]
    /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xfd)[0x7f1885465ead]
    ./test[0x40056d]
    ======= Memory map: ========
    00400000-00401000 r-xp 00000000 08:03 13114118                           /home/avsej/tmp/test
    00600000-00601000 rw-p 00000000 08:03 13114118                           /home/avsej/tmp/test
    014e9000-0150a000 rw-p 00000000 00:00 0                                  [heap]
    7f1885231000-7f1885246000 r-xp 00000000 08:01 2360249                    /lib/x86_64-linux-gnu/libgcc_s.so.1
    7f1885246000-7f1885446000 ---p 00015000 08:01 2360249                    /lib/x86_64-linux-gnu/libgcc_s.so.1
    7f1885446000-7f1885447000 rw-p 00015000 08:01 2360249                    /lib/x86_64-linux-gnu/libgcc_s.so.1
    7f1885447000-7f18855c4000 r-xp 00000000 08:01 2359335                    /lib/x86_64-linux-gnu/libc-2.13.so
    7f18855c4000-7f18857c4000 ---p 0017d000 08:01 2359335                    /lib/x86_64-linux-gnu/libc-2.13.so
    7f18857c4000-7f18857c8000 r--p 0017d000 08:01 2359335                    /lib/x86_64-linux-gnu/libc-2.13.so
    7f18857c8000-7f18857c9000 rw-p 00181000 08:01 2359335                    /lib/x86_64-linux-gnu/libc-2.13.so
    7f18857c9000-7f18857ce000 rw-p 00000000 00:00 0
    7f18857ce000-7f18857ed000 r-xp 00000000 08:01 2363016                    /lib/x86_64-linux-gnu/ld-2.13.so
    7f18859cc000-7f18859cf000 rw-p 00000000 00:00 0
    7f18859ea000-7f18859ed000 rw-p 00000000 00:00 0
    7f18859ed000-7f18859ee000 r--p 0001f000 08:01 2363016                    /lib/x86_64-linux-gnu/ld-2.13.so
    7f18859ee000-7f18859ef000 rw-p 00020000 08:01 2363016                    /lib/x86_64-linux-gnu/ld-2.13.so
    7f18859ef000-7f18859f0000 rw-p 00000000 00:00 0
    7fff268c0000-7fff268e1000 rw-p 00000000 00:00 0                          [stack]
    7fff26900000-7fff26901000 r-xp 00000000 00:00 0                          [vdso]
    ffffffffff600000-ffffffffff601000 r-xp 00000000 00:00 0                  [vsyscall]
    Aborted (core dumped)
    
    Change-Id: I4dc88636a15bcb380ec28579760d70a588fd7947
    Reviewed-on: http://review.couchbase.org/14641
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Tested-by: Sergey Avseyev <sergey.avseyev@gmail.com>
Commits on Apr 7, 2012
  1. @avsej @trondn

    Allow to pass additional arguments to RPM builder

    avsej committed with trondn
    Change-Id: Ic994cb0bbfcd53376fcbbc5ae3d7bcb16fd61727
    Reviewed-on: http://review.couchbase.org/14546
    Tested-by: Sergey Avseyev <sergey.avseyev@gmail.com>
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Commits on Apr 4, 2012
  1. @avsej

    Update changelogs for release 1.1.0dp

    avsej committed
    Change-Id: I5592997c9a93ffdc4f187a44abc895098e5f5fcf
    Reviewed-on: http://review.couchbase.org/14526
    Tested-by: Sergey Avseyev <sergey.avseyev@gmail.com>
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
  2. @avsej

    Update library version

    avsej committed
    The shared object should be 1.3.0 and the library version number
    should be set to 1.1.0
    
    Change-Id: Ifd516822e160d12d3b72c1fcf6e7bbe9f8aa938e
    Reviewed-on: http://review.couchbase.org/14525
    Tested-by: Sergey Avseyev <sergey.avseyev@gmail.com>
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
  3. @avsej @trondn

    Fix several segfaults

    avsej committed with trondn
    Change-Id: Ie67874f96a40c498c334d41b2dd894c91d1cce94
    Reviewed-on: http://review.couchbase.org/14511
    Tested-by: Sergey Avseyev <sergey.avseyev@gmail.com>
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Commits on Apr 3, 2012
  1. @avsej @trondn

    Fix formatting: use typedef as return type

    avsej committed with trondn
    When astyle founds 'struct' tocket it thinks this is struct definition and
    joins the curly brace
    
    Change-Id: If2afabe8b7a8e22d9d21ccc19750aa758347a455
    Reviewed-on: http://review.couchbase.org/14498
    Tested-by: Sergey Avseyev <sergey.avseyev@gmail.com>
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
  2. @trondn

    Updates according to coding style

    trondn committed
    Change-Id: I9d0e941b2ddd286b191e6d27a57347a79ecb2088
    Reviewed-on: http://review.couchbase.org/14427
    Reviewed-by: Sergey Avseyev <sergey.avseyev@gmail.com>
    Tested-by: Sergey Avseyev <sergey.avseyev@gmail.com>
  3. @trondn

    Add --unpad-paren to remove the ugly if ( asdf )

    trondn committed
    Change-Id: Iac1b478af1ecff4281d0ef72894735b3ab4222ae
    Reviewed-on: http://review.couchbase.org/14426
    Reviewed-by: Sergey Avseyev <sergey.avseyev@gmail.com>
    Tested-by: Sergey Avseyev <sergey.avseyev@gmail.com>
Commits on Apr 2, 2012
  1. @avsej @trondn

    Return reference to request struct from constructor

    avsej committed with trondn
    Change-Id: Ib337a5b925ddc3ef4dd6f8c6bc969bf70d65670d
    Reviewed-on: http://review.couchbase.org/14461
    Tested-by: Sergey Avseyev <sergey.avseyev@gmail.com>
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Commits on Mar 30, 2012
  1. @avsej @trondn

    Gracefully cancel couch request

    avsej committed with trondn
    This patch fixes segfault when user cancels request in on_data callback
    
    Change-Id: Icbb35217f25e7b20696293db5ab7aa4c6ae5a8f9
    Reviewed-on: http://review.couchbase.org/14430
    Tested-by: Sergey Avseyev <sergey.avseyev@gmail.com>
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Commits on Mar 27, 2012
  1. @mnunberg @trondn

    Allow tests to use user-defined event loop for iops

    mnunberg committed with trondn
    Change-Id: Ic6bfd5001729d4952360b6c6a48abf3ad54b5f7e
    Reviewed-on: http://review.couchbase.org/14132
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
  2. @avsej @trondn

    Pick up cookies from pending buffer unless node connected

    avsej committed with trondn
    Change-Id: I645ab4557901b480f70c23b56e38c63e0222d888
    Reviewed-on: http://review.couchbase.org/14337
    Tested-by: Sergey Avseyev <sergey.avseyev@gmail.com>
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
  3. @avsej @trondn

    vbucket_found_incorrect_master() returns server index

    avsej committed with trondn
    Change-Id: I39eb6543656fb7f9bd7bcdb9a57a0fb531e9eb75
    Reviewed-on: http://review.couchbase.org/14336
    Tested-by: Sergey Avseyev <sergey.avseyev@gmail.com>
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
  4. @mnunberg @trondn

    Null-terminate unhandled vbucket-stream chunk data

    mnunberg committed with trondn
    Otherwise strstr() might return faulty delimiter in already-parsed data
    
    Change-Id: I5b793c39a89c072388987ef1e75d52fa1624e9ee
    Reviewed-on: http://review.couchbase.org/14141
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
Commits on Mar 14, 2012
  1. @avsej @trondn

    Use libcouchbase IO layer for views

    avsej committed with trondn
    Change-Id: I0c0c0f0c5a73935a2334a416229cf965d167621a
    Reviewed-on: http://review.couchbase.org/13885
    Tested-by: Sergey Avseyev <sergey.avseyev@gmail.com>
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
  2. @avsej @ingenthr

    Implement hash set data structure

    avsej committed with ingenthr
    Change-Id: I048844374843e8e840611d296996d8967b1a7d24
    Reviewed-on: http://review.couchbase.org/13884
    Tested-by: Sergey Avseyev <sergey.avseyev@gmail.com>
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
  3. @avsej @ingenthr

    Build HTTP parser as separate library

    avsej committed with ingenthr
    Change-Id: Ib3dc4d19cb0f40e0052fa9678c4d2278152508ad
    Reviewed-on: http://review.couchbase.org/13894
    Tested-by: Sergey Avseyev <sergey.avseyev@gmail.com>
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
  4. @avsej @ingenthr

    Fix pedantic warnings

    avsej committed with ingenthr
    More info: nodejs/http-parser#102
    
    Change-Id: I70997a636b631df13d56154c8d1684b5d39c81bd
    Reviewed-on: http://review.couchbase.org/13883
    Tested-by: Sergey Avseyev <sergey.avseyev@gmail.com>
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
  5. @avsej @ingenthr

    Bundle HTTP parser from https://github.com/joyent/http-parser

    avsej committed with ingenthr
    Change-Id: Ia6165fcce5d2f915febfbe9c6e3f5a806c50e030
    Reviewed-on: http://review.couchbase.org/13882
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Tested-by: Sergey Avseyev <sergey.avseyev@gmail.com>
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
Commits on Mar 12, 2012
  1. @trondn

    Include errno.h to ensure that the macros should be set first

    trondn committed
    Change-Id: Id7bc3d49092e32329fd121cc44f4adf6b3273277
    Reviewed-on: http://review.couchbase.org/13901
    Reviewed-by: Sergey Avseyev <sergey.avseyev@gmail.com>
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
  2. @trondn

    Don't try to be smart linking the strerror test

    trondn committed
    Change-Id: Ic326147f8f359dc36c1ad48e8683d8ff049ddc24
    Reviewed-on: http://review.couchbase.org/13895
    Reviewed-by: Sergey Avseyev <sergey.avseyev@gmail.com>
    Tested-by: Sergey Avseyev <sergey.avseyev@gmail.com>
Commits on Mar 11, 2012
  1. @trondn

    Clean up warnings reported by lint

    trondn committed
    Change-Id: I11a119fdfba74d9722ff5bc3396deedf7279515d
    Reviewed-on: http://review.couchbase.org/13856
    Reviewed-by: Sergey Avseyev <sergey.avseyev@gmail.com>
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
Commits on Mar 9, 2012
  1. @avsej @trondn

    Check for newer libvbucket

    avsej committed with trondn
    Change-Id: Ic98954ff540aad128455be0e1f0b8d66bb097bc2
    Reviewed-on: http://review.couchbase.org/13850
    Tested-by: Sergey Avseyev <sergey.avseyev@gmail.com>
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
  2. @trondn

    Fix errors reported by lint

    trondn committed
    Change-Id: I688876a659e68166456541f9d296e038118af6e5
    Reviewed-on: http://review.couchbase.org/13825
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
Commits on Mar 8, 2012
  1. @trondn

    MB-4834: Request the tap bytes in a known byte order

    trondn committed
    Change-Id: Ib53b352b04e38b515f66301b79a55fc56ea7e93d
    Reviewed-on: http://review.couchbase.org/13806
    Reviewed-by: Sergey Avseyev <sergey.avseyev@gmail.com>
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
  2. @trondn @ingenthr

    Add lint rule

    trondn committed with ingenthr
    Change-Id: I8504170986e19bd7d69ee3be69c9fa3609ea67d0
    Reviewed-on: http://review.couchbase.org/13824
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
Commits on Mar 7, 2012
  1. @trondn

    Refactor: rename libcouchbase_ringbuffer_ to ringbuffer_

    trondn committed
    These are library internal functions not exported outside the library
    
    Change-Id: Iccb8f2aef9f1d23109d676d7adf45cbd99c0995d
    Reviewed-on: http://review.couchbase.org/13805
    Tested-by: Sergey Avseyev <sergey.avseyev@gmail.com>
    Reviewed-by: Sergey Avseyev <sergey.avseyev@gmail.com>
    Reviewed-by: Mordechai Nunberg <mnunberg@haskalah.org>
  2. @trondn @avsej

    Fix build breaks with --enable-werror with SPRO

    trondn committed with avsej
    Change-Id: Ib9792a2e4ed16bf07c462e780e1cef9351a78f42
    Reviewed-on: http://review.couchbase.org/13814
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
    Tested-by: Sergey Avseyev <sergey.avseyev@gmail.com>
    Reviewed-by: Sergey Avseyev <sergey.avseyev@gmail.com>
Commits on Mar 6, 2012
  1. @avsej @trondn

    Updated package metadata for 1.0.2 release

    avsej committed with trondn
    Change-Id: Id3333121aff904c41af5908637bb3bc1dfa35b96
    Reviewed-on: http://review.couchbase.org/13785
    Tested-by: Sergey Avseyev <sergey.avseyev@gmail.com>
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
  2. @avsej @trondn

    make reformat

    avsej committed with trondn
    Change-Id: I0c5b6e23c32fb641c98636377d1fe5032a6620a8
    Reviewed-on: http://review.couchbase.org/13781
    Tested-by: Sergey Avseyev <sergey.avseyev@gmail.com>
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
Commits on Mar 2, 2012
  1. @trondn

    Update library version

    trondn committed
    The shared object should be 1.2.0 and the library version number
    should be set to 1.0.2
    
    Change-Id: If3bb7ca0dcf0c6c63a644a7aab824c2b6e66a9b8
    Reviewed-on: http://review.couchbase.org/13747
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
  2. @trondn

    Fix buildbreak on win32

    trondn committed
    Change-Id: Ie48ed69ba95a2eb54e2a1fad346423e22eeb7504
    Reviewed-on: http://review.couchbase.org/13749
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
Something went wrong with that request. Please try again.