Skip to content
Commits on Nov 11, 2010
  1. @steveyen @seanlynch

    MB-2724 - configurable auth_timeout with auth timeout blacklisting

    steveyen committed with seanlynch
    auth_timeout is now command-line configurable, and can now be used
    with the zstored downstream conn blacklisting flags.  For example...
    
        cycle=200,
        connect_max_errors=10,
        connect_retry_interval=30000,
        auth_timeout=100,
        ...
    
    A new tot_auth_timeout stat also tracks how often we see
    an auth timeout error.
    
    Change-Id: Idfb64d627ff0b5b470332efb640b498382d9e5bf
    Reviewed-on: http://review.membase.org/3628
    Tested-by: Sean Lynch <seanl@literati.org>
    Reviewed-by: Sean Lynch <seanl@literati.org>
Commits on Nov 10, 2010
  1. @steveyen

    MB-2689 - call select() right

    steveyen committed
    Change-Id: I02bdcff66390bafb76cab93b55d1d7585d1df418
    Reviewed-on: http://review.membase.org/3618
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
  2. @steveyen

    MB-2689 - use timeout if any part is nonzero

    steveyen committed
    Change-Id: I0c1d2104353879b0936369da15f8481cadf0aca6
    Reviewed-on: http://review.membase.org/3614
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
  3. @steveyen

    more logging of key in ascii get response

    steveyen committed
    Change-Id: I77479157c6440f11740d445e1ccb57fac833d039
    Reviewed-on: http://review.membase.org/3607
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
  4. @steveyen @seanlynch

    MB-2689 - add timeout to moxi SASL auth & bucket select requests

    steveyen committed with seanlynch
    In this change, moxi SASl auth and bucket select are still
    synchronous, but have additional configurable timeouts (via the
    downstream_timeout configuration parameter).
    
    This is done by adding a select() with timeout mcs_io_read(),
    which shouldn't be too horrible as SASL auth should be very
    infrequent due to long-lived, reused connections.
    
    The alternative solution of rewriting SASL auth and bucket-select, in
    comparison, to be asynchronous is a lot of effort.
    
    Change-Id: I61f31fb3a4c4a994ff79d6a9f909ca578ae02236
    Reviewed-on: http://review.membase.org/3604
    Reviewed-by: Sean Lynch <seanl@literati.org>
    Tested-by: Sean Lynch <seanl@literati.org>
  5. @steveyen @seanlynch

    bug MB-2660 - downstream_conn_max fix on closed conns

    steveyen committed with seanlynch
    When a downstream conn was closed, moxi wasn't decrementing the
    dc_acquired counter correctly (via zstored_error_count()), leading to
    a locked up moxi.
    
    The test script ./t/issue-MB-2660.sh no longer locks up with this fix.
    
    Change-Id: I5b5dccbe63f3d685ed7cb6f80157611f01a13a2d
    Reviewed-on: http://review.membase.org/3603
    Tested-by: Sean Lynch <seanl@literati.org>
    Reviewed-by: Sean Lynch <seanl@literati.org>
Commits on Nov 8, 2010
  1. @steveyen

    downstream_max of 0 means unlimited

    steveyen committed
    Change-Id: Ie96773eea36983fb7a3d546f0a7b4105d54cd968
    Reviewed-on: http://review.membase.org/3582
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
  2. @steveyen @dustin

    MB-2690 - don't assert on STATS error

    steveyen committed with dustin
    Change-Id: I09987384feb3a04f212dcb206d9668b44703e749
    Reviewed-on: http://review.membase.org/3579
    Tested-by: Dustin Sallings <dustin@spy.net>
    Reviewed-by: Dustin Sallings <dustin@spy.net>
Commits on Nov 5, 2010
  1. @steveyen @seanlynch

    MB-2672 - moxi logs at -v level when config is received

    steveyen committed with seanlynch
    When moxi has verbosity level > 0 (-v or greater), and moxi receives a
    configuration JSON message on the REST/URL stream, it will now log...
    
      2010-11-04 18:22:23: (agent_config.c.389) configuration received
    
    Change-Id: I667a3fe877f6c65cf5f126160468e9a47aa306c8
    Reviewed-on: http://review.membase.org/3560
    Tested-by: Sean Lynch <seanl@literati.org>
    Reviewed-by: Sean Lynch <seanl@literati.org>
  2. @steveyen

    MB-2670 - stats proxy config

    steveyen committed
    If moxi was started with ketama hashing...
    
     $ ./dev/moxi/moxi -z 11211=127.0.0.1:11411,127.0.0.1:11511
    
    Then "stats proxy config" would return...
    
     $ echo stats proxy config | nc 127.0.0.1 11211
     STAT 11211:default:config 127.0.0.1:11411,127.0.0.1:11511
     END
    
    If moxi was started with membase REST/URL/JSON, then you'll see JSON...
    
     $ echo stats proxy config | nc 127.0.0.1 11211
     STAT 11211:default:config {
         "name":              "default",
         "nodeLocator":       "vbucket",
         "saslPassword":      "",
         ...clipped...
     }
     STAT 11211:[ <NULL_BUCKET> ]:config
     END
    
    Change-Id: I246a101e1cbf9e9a1f9f23779a47c03fd67ac1ec
    Reviewed-on: http://review.membase.org/3559
    Reviewed-by: Sean Lynch <seanl@literati.org>
    Tested-by: Steve Yen <steve.yen@gmail.com>
Commits on Nov 3, 2010
  1. @mtaneja @steveyen

    Implementation for Get Locked (getl) command

    mtaneja committed with steveyen
    support for pessimistic locking command for binary and ascii protocol.
    
    B:localhost:11311 getl k1
    VALUE k1 0 5 41
    dudea
    END
    B:localhost:11311 getl k1
    LOCK_ERROR
    
    Change-Id: Id25fc7a32ee3a80697903f7981c2abf2e580b748
    Reviewed-on: http://review.membase.org/3538
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
Commits on Oct 18, 2010
  1. @steveyen

    implemented gdb-callable connections_diag

    Aliaksey Kandratsenka committed with steveyen
    This provides relatively easily accessible high-level diagnostics of
    what is going on inside moxi
    
    Change-Id: Iff04d63be694891bf0d329a89bc83ad5ffbd22b1
    Reviewed-on: http://review.membase.org/3302
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
Commits on Oct 14, 2010
  1. @steveyen

    bug 2759 - two is not enough verbosity

    steveyen committed
    Change-Id: Idf6a3812f19d6a82f485434f99dce3bfb28acf2f
    Reviewed-on: http://review.membase.org/3236
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Commits on Oct 12, 2010
  1. @trondn @dustin

    Don't loose the cppflags added by automake

    trondn committed with dustin
    This includes an -I directive to allow compilation of moxi from
    another directory (eg. ../moxi/configure && make )
    
    Change-Id: Ie84242bc12cfaee08e65ac1217fa161473131e9b
    Reviewed-on: http://review.membase.org/3222
    Reviewed-by: Dustin Sallings <dustin@spy.net>
    Tested-by: Dustin Sallings <dustin@spy.net>
Commits on Oct 5, 2010
  1. @steveyen

    bug 2600 - fcntl() F_GETFL was lying on windows

    steveyen committed
    The bad effect was that all sockets on windows ended up being
    incorrectly in blocking mode instead of non-blocking mode,
    after doing a sasl-auth.
    
    Change-Id: I06d8a1447b33bbeef4aa35bf119a9c448e635a55
    Reviewed-on: http://review.northscale.com/3047
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
Commits on Oct 4, 2010
  1. @steveyen

    more asserts around read()

    steveyen committed
    Change-Id: Iea765fa712daad66c24176468c19b5e0c3e34f55
    Reviewed-on: http://review.northscale.com/3035
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
Commits on Oct 3, 2010
  1. @steveyen

    bug 2570 - downstream_conn_max unlimited again

    steveyen committed
    Change-Id: If48ad1ab11023e2ecf7d681d14a5f32fc4cc3876
  2. @steveyen

    use appropriate lock before accessing proxy->name

    steveyen committed
    Change-Id: I4b38326385bb0ed0565cde998a0e23d3f1e6cfea
  3. @steveyen

    bug 2605 - propagate usr/pwd correctly to mcs layer

    steveyen committed
    A helpful fix for empty-password buckets like the default bucket.
    The host_ident hash string caching in mcs, in particular, was
    sensitive to formatting NULL vs empty ("") passwords.
    
    Change-Id: I17650074e2a962881f9904c7c6ede218f58ae9d5
    Reviewed-on: http://review.northscale.com/2998
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
Commits on Oct 2, 2010
  1. @steveyen

    logging had 1 too many ampersands

    steveyen committed
    Change-Id: I69af882a1cda688f3c9b4f533be662fd482115ad
    Reviewed-on: http://review.northscale.com/2992
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
  2. @steveyen

    bug 2600 - more logging for diagnosis

    steveyen committed
    Change-Id: I695b3bc0d3a911e8dc33cb6e04be214f858edbc8
    Reviewed-on: http://review.northscale.com/2981
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
  3. @steveyen

    bug 2602 - fixed multitenancy default bucket test

    steveyen committed
    In the new regime of saslBucketsStreaming, moxi will sasl auth for the
    default bucket, using username 'default', password '', so this commit
    updates the mock tests to reflect that.
    
    Change-Id: I79f0af838377f155b2d8c2a62af13549bc120987
    Reviewed-on: http://review.northscale.com/2975
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
  4. @steveyen

    bug 2602 - update test data to match cleaned up JSON format

    steveyen committed
    Change-Id: I7e19ced9e17bb09a38ea753b2e620e20bbe45ac7
    Reviewed-on: http://review.northscale.com/2974
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
  5. @steveyen @chiyoung

    moxi logging thread and buffer safety

    steveyen committed with chiyoung
    The scratch buffer wasn't thread-safe, as we saw an assert when going
    past the MAX_LOGBUF_LEN.  Added some extra byte slop to avoid going
    past that, too.
    
    Change-Id: Ie1b3135e2b1b41c5952e2d224fc614b3fb194054
    Reviewed-on: http://review.northscale.com/2965
    Tested-by: Chiyoung Seo <chiyoung.seo@gmail.com>
    Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>
Commits on Oct 1, 2010
  1. @steveyen @seanlynch

    bug 2602 - use name/saslPassword, not vBucketServerMap.user/password

    steveyen committed with seanlynch
    Change-Id: I365d61ef3b6c29454a943851115b85fb91db2052
    Reviewed-on: http://review.northscale.com/2933
    Tested-by: Sean Lynch <seanl@literati.org>
    Reviewed-by: Sean Lynch <seanl@literati.org>
  2. @steveyen @seanlynch

    bug 2608 - use json-provided bucket name rather than "default"

    steveyen committed with seanlynch
    Change-Id: Ifb5bc73e39fa0925e5bd7a9f756ca87029752575
    Reviewed-on: http://review.northscale.com/2931
    Reviewed-by: Sean Lynch <seanl@literati.org>
    Tested-by: Sean Lynch <seanl@literati.org>
  3. @steveyen @seanlynch

    bug 2608 - moxi should ignore unhealthy nodes for ketama

    steveyen committed with seanlynch
    Change-Id: Ic7b8654781d08bc4f0ada1d538b3a7c15e63ddf9
    Reviewed-on: http://review.northscale.com/2925
    Reviewed-by: Sean Lynch <seanl@literati.org>
    Tested-by: Sean Lynch <seanl@literati.org>
Commits on Sep 30, 2010
  1. @steveyen

    bug 2592 - extra case of reading bucket pswd from JSON

    steveyen committed
    Missed one of the many places to get a user/pswd from the JSON.
    
    Change-Id: I2eff20a487f61c74001e6b1b627d1f6a095c252e
    Reviewed-on: http://review.northscale.com/2917
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Reviewed-by: Dustin Sallings <dustin@spy.net>
  2. @steveyen

    bug 2576 - relevant err msg when bad uds socket

    steveyen committed
    Change-Id: I714feaf92d0596c8f81e6c60ccb8848345ecc585
    Reviewed-on: http://review.northscale.com/2884
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
  3. @steveyen

    bug 2541 - allow heterogeneous buckets (memcached & membase)

    steveyen committed
    Change-Id: I3fb9b361ef0124a53c27ed56b6a771b25aafaba9
    Reviewed-on: http://review.northscale.com/2883
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
Commits on Sep 29, 2010
  1. @steveyen

    bug 1998 - better error msg when client tries to use NULL bucket

    steveyen committed
    Change-Id: Ia434f701c76e0174535894491a4329244c21d82f
    Reviewed-on: http://review.northscale.com/2861
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
  2. @steveyen

    bug 1998 - handle missing default bucket correctly

    steveyen committed
    This change introduces or corrects a few related concepts...
    
    - default_bucket_name
      - This is a -Z cmd-line key-value parameter.  Example:
        "-Z default_bucket_name=default,port_listen=11211"
      - By default, the default_bucket_name parameter is,
        confusingly, FIRST_BUCKET.
      - moxi assign new client/upstream connections to the bucket named
        $(default_bucket_name), if it exists.  If that named bucket
        doesn't exist, new client/upstream connections are assigned
        to the NULL_BUCKET.
    
    - FIRST_BUCKET
      - A special bucket name, used like a sentinel value.
      - Have moxi assign new connections to the first configured bucket.
        Confusingly, this is the default for the default_bucket_name.
    
    - NULL_BUCKET
      - A special bucket name, used like a sentinel value.
      - This refers to a special black-hole bucket, where any mutations
        result in SERVER_ERROR responses, and get's result in misses/END.
    
    When moxi is used standalone on a per-bucket basis, the
    default_bucket_name is left unspecifiedm, so FIRST_BUCKET.
    
    When moxi is used as a gateway proxy, default_bucket_name=default.
    
    Change-Id: Idfbdf68a75964fe84dee0c52e8d54fc90834cca8
    Reviewed-on: http://review.northscale.com/2824
    Reviewed-by: Dustin Sallings <dustin@spy.net>
    Tested-by: Steve Yen <steve.yen@gmail.com>
  3. @steveyen

    bug 1998 - emitting test cmd-lines

    steveyen committed
    Change-Id: I291a1a4256eac0941bd34d28429b904640743297
    Reviewed-on: http://review.northscale.com/2823
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
Commits on Sep 28, 2010
  1. @steveyen

    bug 2539 - use protocol correctly while caching host_ident

    steveyen committed with Matt Ingenthron
    In mcmux, the client can dynamically switch between ascii & binary
    protocols ("[A|B]:host:port" prefix).  That protocol was incorrectly
    getting ignored by the recent performance fix that was caching the
    host_ident strings.
    
    mcs_server_st_ident() API and implementation was changed to
    switch correctly to the right ident_a or ident_b buffer in
    this change.
    
    Change-Id: If0d6b7d643bd9611a48dd590454bc681adace610
    Reviewed-on: http://review.northscale.com/2810
    Reviewed-by: Matt Ingenthron <matt@northscale.com>
    Tested-by: Matt Ingenthron <matt@northscale.com>
  2. @steveyen

    bug 2529 - port 8080 to 8091

    steveyen committed with Matt Ingenthron
    Change-Id: Ic1a1d0ed6be0c8afc7c91b05487eefaf09dfe500
    Reviewed-on: http://review.northscale.com/2787
    Reviewed-by: Matt Ingenthron <matt@northscale.com>
    Tested-by: Matt Ingenthron <matt@northscale.com>
Something went wrong with that request. Please try again.