Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on May 25, 2011
  1. @steveyen

    MB-3799 - moxi default libmemcached hashing is now ketama_weighted

    steveyen authored
    Change-Id: I84c498913f9f816ecd4a084375cccbe67b556967
    Reviewed-on: http://review.membase.org/6537
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
Commits on May 23, 2011
  1. @steveyen @bcui6611

    TOUCH ascii-to-binary

    steveyen authored bcui6611 committed
    Change-Id: Icf6d56350a57895a0e5b13c101c8f68755c89011
    Reviewed-on: http://review.membase.org/6460
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Reviewed-by: Bin Cui <bin.cui@gmail.com>
  2. @steveyen @bcui6611

    binary protocol codes for TOUCH, GAT/Q, EVICT, SYNC, etc

    steveyen authored bcui6611 committed
    Change-Id: I190e1e2348fcc9fa3695175f4a86e1764b6de4c7
    Reviewed-on: http://review.membase.org/6459
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Reviewed-by: Bin Cui <bin.cui@gmail.com>
Commits on May 19, 2011
  1. @steveyen @bcui6611

    Skip moxi decr wraparound test

    steveyen authored bcui6611 committed
    Skipping a part of the incrdecr.t unit test, which was inherited from
    memcached, as it's testing moxi running in "pretend-to-be-memcached"
    mode.  That mode is deprioritized right now.
    
    Change-Id: I2827e00f4a902c26e7832e48b5645aec6d0a2033
    Reviewed-on: http://review.membase.org/6362
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Reviewed-by: Bin Cui <bin.cui@gmail.com>
  2. @steveyen @bcui6611

    MB-3575 - conflate new_config() call signature changed

    steveyen authored bcui6611 committed
    Provide a useful response to the new_config() callback, where moxi can
    tell conflate that it received a bogus config.  conflate can then try
    to contact an alternative REST config server.
    
    Change-Id: I19a76db41dd161e62938d4ef6b5738d1a7aab7f5
    Reviewed-on: http://review.membase.org/6342
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Reviewed-by: Bin Cui <bin.cui@gmail.com>
Commits on May 18, 2011
  1. @steveyen

    MB-3856 - SERVER_ERROR proxy downstream timeout $HOST

    steveyen authored
    The $HOST is only appended during timeout of single-server commands
    (get, set, delete, etc) which are the single-key commands.  Broadcast
    commands (like flush_all) won't have the $HOST appended during a
    timeout.
    
    Change-Id: I40c307a2ea4974aca6b884054da1f935ea8216a4
    Reviewed-on: http://review.membase.org/6315
    Reviewed-by: Bin Cui <bin.cui@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
  2. @steveyen

    MB-3575 - Pass around conflate src/url for debuggability

    steveyen authored
    Emit the url/src information during REST parsing errors.
    
    Change-Id: Ib559ac33be17e178dce6b5d8a299cde5a2df38e4
    Reviewed-on: http://review.membase.org/6338
    Reviewed-by: Bin Cui <bin.cui@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
Commits on May 16, 2011
  1. @steveyen @alk

    MB-3849 - SERVER_ERROR proxy write to downstream $HOST

    steveyen authored alk committed
    Changed the error message to include the downstream host which moxi
    could not propagate the request to.
    
    Change-Id: Ia3e0bbc7ccf2f2ae203aaff56b60f571a1036b75
    Reviewed-on: http://review.membase.org/6269
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  2. @steveyen @alk

    MB-3849 - SERVER_ERROR proxy downstream closed $HOST_IDENT

    steveyen authored alk committed
    Change-Id: Ibe9fd62bc76fc1f14554977f592ef347f871d734
    Reviewed-on: http://review.membase.org/6268
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  3. @steveyen @alk

    MB-3479 - Use binary protocol AUTH_ERROR on null bucket access

    steveyen authored alk committed
    When the client tries to do operations on the so-called "NULL bucket",
    instead of returning a binary protocol response ENOMEM, respond with
    the PROTOCOL_BINARY_RESPONSE_AUTH_ERROR result code.
    
    Change-Id: I0efed77c4dbc2782fad1d8638a7ec7fe42313e21
    Reviewed-on: http://review.membase.org/6267
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  4. @steveyen @alk

    MB-3845 - Improved rehabilitation of a born-again conn

    steveyen authored alk committed
    It's possible that a conn_new() reuses a conn structure from the
    freelist rather than from calloc().  Initialize the fields of that
    recycled conn better.
    
    Change-Id: Ib0f491106980f4648c0c60a1ab3c9c5af61a4486
    Reviewed-on: http://review.membase.org/6265
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Commits on May 14, 2011
  1. @steveyen

    MB-3479 - Use binary protocol EBUSY & EINTERNAL instead of ENOMEM

    steveyen authored
    Instead of over-using the OOM / ENOMEM binary protocol response
    error...
    
    - Return EBUSY during a timeout.
    - Return EINTERNAL for closed sockets & down servers.
    - Return ENOMEM when memcached returns ENOMEM.
    
    Also, use EINTERNAL rather than ENOMEM as the generic catch-all error
    code, which should reduce confusion ("but, I'm not actually out of
    memory").
    
    Change-Id: I207903f0c4d5b967866c67cb61ac3b43a832d5cd
    Reviewed-on: http://review.membase.org/6177
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
Commits on May 12, 2011
  1. @steveyen

    Updated usage() for mcs_opts

    steveyen authored
    Change-Id: I260ab871bd564a744ed0d86913cbe74a249ddb2f
    Reviewed-on: http://review.membase.org/6159
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
  2. @trondn @alk

    MB-3812 Upgrade pandora_check_cxx_standard.m4

    trondn authored alk committed
    Change-Id: I8634c1899b85328f7ed0b1a71b08c9fd56a7b42d
    Reviewed-on: http://review.membase.org/6182
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Commits on May 11, 2011
  1. @steveyen

    MB-3798 - moxi option for ketama/weighted/modula item distributions

    steveyen authored
    When using libmemcached, start moxi with an extra -Z key=value
    configuration option...
    
      moxi -Z mcs_opts=distribution:ketama
      moxi -Z mcs_opts=distribution:ketama-weighted
      moxi -Z mcs_opts=distribution:modula
    
    In this commit, moxi stays with distribution:ketama as its default and
    a later debate can change that.
    
    Change-Id: I36d3df3a2ba79c9d793a5e1e1a31d0d24ba48450
    Reviewed-on: http://review.membase.org/6138
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Reviewed-by: Matt Ingenthron <matt@northscale.com>
Commits on May 9, 2011
  1. @alk @steveyen

    shutdown moxi on EOL in addition to EOF

    alk authored steveyen committed
    So that erlang can reliably shutdown moxi.
    
    Change-Id: Ie31b4b577a5454115e251c92392306337e6be988
    Reviewed-on: http://review.membase.org/6070
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
Commits on May 8, 2011
  1. @steveyen @alk

    MB-3774 - detect binary broadcast cmd properly

    steveyen authored alk committed
    With binary upstream clients, the uc->cmd_curr field is -1.
    Instead, we should be detecting against the uc->cmd field.
    
    Change-Id: I7cd337fb3a6fd8748e4a0e4df2d4edb93977c71c
    Reviewed-on: http://review.membase.org/6067
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Commits on May 7, 2011
  1. @steveyen

    Fix auth B2B tests that depended on old timeout config

    steveyen authored
    A previous commit (0b23b54) changed the default timeout settings
    to be more user friendly for client-side moxi cases, but some auth B2B
    tests were depending on the old (rather generous) timeout settings,
    which this change now makes explicit.
    
    Change-Id: Id23365ade273ec301e5c2e7ecc1b068e40f6e521
    Reviewed-on: http://review.membase.org/6037
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
Commits on May 5, 2011
  1. @steveyen

    MB-3742 - 512 ought to be enough for any stats

    steveyen authored
    Change-Id: I36d29bb60f05946ac945301f884eb4aed26b766e
    Reviewed-on: http://review.membase.org/5936
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
Commits on May 2, 2011
  1. @steveyen

    Exit if empty -z configuration

    steveyen authored
    Change-Id: I591319f81f1e8ed1f42d9d709876f774eb05159b
    Reviewed-on: http://review.membase.org/5836
    Reviewed-by: Bin Cui <bin.cui@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
Commits on Apr 29, 2011
  1. @steveyen @bcui6611

    Allow comment characters in -Z config files

    steveyen authored bcui6611 committed
    Change-Id: I1a8ace6c4a4b40a8e827223748b4645f45e0a861
    Reviewed-on: http://review.membase.org/5829
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Reviewed-by: Bin Cui <bin.cui@gmail.com>
  2. @steveyen

    usage() help on -l and -d flags

    steveyen authored
    Change-Id: Ied0c517ac861b7cfa0f4e5376e2abc73600e8148
    Reviewed-on: http://review.membase.org/5825
    Reviewed-by: Bin Cui <bin.cui@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
  3. @steveyen

    pt-12636461 - default timeout config

    steveyen authored
    Values taken from the default configurations from membase/ns_server
    for server-side moxi.
    
    Change-Id: I261b02b86e30962d6278dca3c8077d5563fd8652
    Reviewed-on: http://review.membase.org/5632
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
Commits on Mar 29, 2011
  1. @steveyen @alk

    MB-2403 - default to 200ms clock cycle for better logging

    steveyen authored alk committed
    Change-Id: I046b42b604957f8a25dbf5809208cb370470cb53
    Reviewed-on: http://review.membase.org/5133
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Commits on Mar 14, 2011
  1. @tsuna @steveyen

    Make Moxi compile without libconflate.

    tsuna authored steveyen committed
    Change-Id: I32258c4b0f8d837ce81e07559f425c9a95cecb80
    Reviewed-on: http://review.membase.org/4899
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
  2. @tsuna @alk

    Remove version.sh.

    tsuna authored alk committed
    This script was superseded by config/autorun.sh.
    
    Change-Id: I9922a66360cd15c659f1ff28bd92025e1da0d383
    Reviewed-on: http://review.membase.org/4898
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Commits on Mar 7, 2011
  1. @alk @steveyen

    fixed warning from comparing different enum types

    alk authored steveyen committed
    Change-Id: I52c0ae14c4633353745a0b1ba1a3956cb1734c5f
    Reviewed-on: http://review.membase.org/4805
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
Commits on Mar 3, 2011
  1. @alk @steveyen

    remove bogus www.danga.com/moxi link

    alk authored steveyen committed
    Change-Id: Ic30a41ee9de3490a0b95f1d7d9408c21f1a6e348
    Reviewed-on: http://review.membase.org/4773
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
Commits on Feb 19, 2011
  1. @steveyen @alk

    MB-3447 - binary protocol err handling

    steveyen authored alk committed
    Need to schedule the upstream conn into libevent so the error response
    actually gets written to socket.
    
    Change-Id: Id058e9dc84beeb2b109b99787b1ee9fc35dbbb38
    Reviewed-on: http://review.membase.org/4664
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Commits on Feb 10, 2011
  1. @alk @steveyen

    made binary proxy stats include all cmd stats

    alk authored steveyen committed
    Change-Id: I765a7642f4f755626c9a4192158e8a99bb6801ad
    Reviewed-on: http://review.membase.org/4500
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  2. @alk @steveyen

    added stats for local & total latencies

    alk authored steveyen committed
    NOTE: that we assume that first server in downstream server list is
    'local'. Corresponding change will be made to ns_server.
    
    Change-Id: I8dd5c61828f6cdcc3c75a0e4f8d2559731701341
    Reviewed-on: http://review.membase.org/4499
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
  3. @alk @steveyen

    fixed gcc warning

    alk authored steveyen committed
    Change-Id: I5d09d6a7474e5e2906a5bf78b0d4c0aa732b1f37
    Reviewed-on: http://review.membase.org/4498
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  4. @alk @steveyen

    replaced self parameter with local

    alk authored steveyen committed
    local requests are requests to first downstream server
    
    Change-Id: I9e95bffd6adc388f55986b280c2023eda61d66e8
    Reviewed-on: http://review.membase.org/4497
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
  5. @alk @steveyen

    removed tot_optimize_self stat

    alk authored steveyen committed
    Change-Id: I04a9063b9dc230784a3034a4c6ad4567faac77c8
    Reviewed-on: http://review.membase.org/4496
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  6. @alk @steveyen

    removed self-optimization

    alk authored steveyen committed
    Change-Id: I1eb77daded0a5e4ecaec0a0507ae0d89ce08021c
    Reviewed-on: http://review.membase.org/4495
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Something went wrong with that request. Please try again.