Permalink
Commits on Jul 7, 2011
  1. MB-2897 - use 64-bits for msec_current time

    steveyen committed Jul 6, 2011
    32-bits overlows after 49+ days, and 64-bits should be enough for
    anybody.
    
    Change-Id: I769839ee4cb41f10ce808cf7f669c0cd1beb7245
    Reviewed-on: http://review.couchbase.org/7748
    Reviewed-by: Bin Cui <bin.cui@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
Commits on Jun 23, 2011
  1. MB-4003 - Allow empty binary stats values, part 2

    steveyen committed Jun 23, 2011
    Change-Id: Ice66eff1997d9c98d2542c02735d892bf9d2b696
    Reviewed-on: http://review.couchbase.org/7151
    Reviewed-by: Bin Cui <bin.cui@gmail.com>
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
  2. MB-4003 - Allow empty binary stats values

    steveyen committed Jun 23, 2011
    Change-Id: I167537f1b80ecf1ff1146b9618ae40e1fff9c6d8
    Reviewed-on: http://review.couchbase.org/7148
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
Commits on Jun 14, 2011
  1. MB-3949. Getl doesn't pass expiration info correctly

    Mike Wiederhold authored and mikewied committed Jun 14, 2011
    Fixed the ASCII to binary protocol conversion to correctly place
    the expiration time for a getl into the correct binary field.
    
    Change-Id: Ifa35e32166ad65895de80d70f5844885457502ec
    Reviewed-on: http://review.couchbase.org/6975
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
Commits on May 25, 2011
  1. MB-3799 - moxi default libmemcached hashing is now ketama_weighted

    steveyen committed May 25, 2011
    Change-Id: I84c498913f9f816ecd4a084375cccbe67b556967
    Reviewed-on: http://review.membase.org/6537
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
Commits on May 23, 2011
  1. TOUCH ascii-to-binary

    steveyen authored and bcui6611 committed May 23, 2011
    Change-Id: Icf6d56350a57895a0e5b13c101c8f68755c89011
    Reviewed-on: http://review.membase.org/6460
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Reviewed-by: Bin Cui <bin.cui@gmail.com>
  2. binary protocol codes for TOUCH, GAT/Q, EVICT, SYNC, etc

    steveyen authored and bcui6611 committed May 23, 2011
    Change-Id: I190e1e2348fcc9fa3695175f4a86e1764b6de4c7
    Reviewed-on: http://review.membase.org/6459
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Reviewed-by: Bin Cui <bin.cui@gmail.com>
Commits on May 19, 2011
  1. Skip moxi decr wraparound test

    steveyen authored and bcui6611 committed May 19, 2011
    Skipping a part of the incrdecr.t unit test, which was inherited from
    memcached, as it's testing moxi running in "pretend-to-be-memcached"
    mode.  That mode is deprioritized right now.
    
    Change-Id: I2827e00f4a902c26e7832e48b5645aec6d0a2033
    Reviewed-on: http://review.membase.org/6362
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Reviewed-by: Bin Cui <bin.cui@gmail.com>
  2. MB-3575 - conflate new_config() call signature changed

    steveyen authored and bcui6611 committed May 18, 2011
    Provide a useful response to the new_config() callback, where moxi can
    tell conflate that it received a bogus config.  conflate can then try
    to contact an alternative REST config server.
    
    Change-Id: I19a76db41dd161e62938d4ef6b5738d1a7aab7f5
    Reviewed-on: http://review.membase.org/6342
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Reviewed-by: Bin Cui <bin.cui@gmail.com>
Commits on May 18, 2011
  1. MB-3856 - SERVER_ERROR proxy downstream timeout $HOST

    steveyen committed May 17, 2011
    The $HOST is only appended during timeout of single-server commands
    (get, set, delete, etc) which are the single-key commands.  Broadcast
    commands (like flush_all) won't have the $HOST appended during a
    timeout.
    
    Change-Id: I40c307a2ea4974aca6b884054da1f935ea8216a4
    Reviewed-on: http://review.membase.org/6315
    Reviewed-by: Bin Cui <bin.cui@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
  2. MB-3575 - Pass around conflate src/url for debuggability

    steveyen committed May 18, 2011
    Emit the url/src information during REST parsing errors.
    
    Change-Id: Ib559ac33be17e178dce6b5d8a299cde5a2df38e4
    Reviewed-on: http://review.membase.org/6338
    Reviewed-by: Bin Cui <bin.cui@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
Commits on May 16, 2011
  1. MB-3849 - SERVER_ERROR proxy write to downstream $HOST

    steveyen authored and alk committed May 16, 2011
    Changed the error message to include the downstream host which moxi
    could not propagate the request to.
    
    Change-Id: Ia3e0bbc7ccf2f2ae203aaff56b60f571a1036b75
    Reviewed-on: http://review.membase.org/6269
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  2. MB-3849 - SERVER_ERROR proxy downstream closed $HOST_IDENT

    steveyen authored and alk committed May 16, 2011
    Change-Id: Ibe9fd62bc76fc1f14554977f592ef347f871d734
    Reviewed-on: http://review.membase.org/6268
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  3. MB-3479 - Use binary protocol AUTH_ERROR on null bucket access

    steveyen authored and alk committed May 16, 2011
    When the client tries to do operations on the so-called "NULL bucket",
    instead of returning a binary protocol response ENOMEM, respond with
    the PROTOCOL_BINARY_RESPONSE_AUTH_ERROR result code.
    
    Change-Id: I0efed77c4dbc2782fad1d8638a7ec7fe42313e21
    Reviewed-on: http://review.membase.org/6267
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  4. MB-3845 - Improved rehabilitation of a born-again conn

    steveyen authored and alk committed May 16, 2011
    It's possible that a conn_new() reuses a conn structure from the
    freelist rather than from calloc().  Initialize the fields of that
    recycled conn better.
    
    Change-Id: Ib0f491106980f4648c0c60a1ab3c9c5af61a4486
    Reviewed-on: http://review.membase.org/6265
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Commits on May 14, 2011
  1. MB-3479 - Use binary protocol EBUSY & EINTERNAL instead of ENOMEM

    steveyen committed May 12, 2011
    Instead of over-using the OOM / ENOMEM binary protocol response
    error...
    
    - Return EBUSY during a timeout.
    - Return EINTERNAL for closed sockets & down servers.
    - Return ENOMEM when memcached returns ENOMEM.
    
    Also, use EINTERNAL rather than ENOMEM as the generic catch-all error
    code, which should reduce confusion ("but, I'm not actually out of
    memory").
    
    Change-Id: I207903f0c4d5b967866c67cb61ac3b43a832d5cd
    Reviewed-on: http://review.membase.org/6177
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
Commits on May 12, 2011
  1. Updated usage() for mcs_opts

    steveyen committed May 11, 2011
    Change-Id: I260ab871bd564a744ed0d86913cbe74a249ddb2f
    Reviewed-on: http://review.membase.org/6159
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
  2. MB-3812 Upgrade pandora_check_cxx_standard.m4

    trondn authored and alk committed May 12, 2011
    Change-Id: I8634c1899b85328f7ed0b1a71b08c9fd56a7b42d
    Reviewed-on: http://review.membase.org/6182
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Commits on May 11, 2011
  1. MB-3798 - moxi option for ketama/weighted/modula item distributions

    steveyen committed May 10, 2011
    When using libmemcached, start moxi with an extra -Z key=value
    configuration option...
    
      moxi -Z mcs_opts=distribution:ketama
      moxi -Z mcs_opts=distribution:ketama-weighted
      moxi -Z mcs_opts=distribution:modula
    
    In this commit, moxi stays with distribution:ketama as its default and
    a later debate can change that.
    
    Change-Id: I36d3df3a2ba79c9d793a5e1e1a31d0d24ba48450
    Reviewed-on: http://review.membase.org/6138
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Reviewed-by: Matt Ingenthron <matt@northscale.com>
Commits on May 9, 2011
  1. shutdown moxi on EOL in addition to EOF

    Aliaksey Kandratsenka authored and steveyen committed May 8, 2011
    So that erlang can reliably shutdown moxi.
    
    Change-Id: Ie31b4b577a5454115e251c92392306337e6be988
    Reviewed-on: http://review.membase.org/6070
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
Commits on May 8, 2011
  1. MB-3774 - detect binary broadcast cmd properly

    steveyen authored and alk committed May 8, 2011
    With binary upstream clients, the uc->cmd_curr field is -1.
    Instead, we should be detecting against the uc->cmd field.
    
    Change-Id: I7cd337fb3a6fd8748e4a0e4df2d4edb93977c71c
    Reviewed-on: http://review.membase.org/6067
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Commits on May 7, 2011
  1. Fix auth B2B tests that depended on old timeout config

    steveyen committed May 7, 2011
    A previous commit (0b23b54) changed the default timeout settings
    to be more user friendly for client-side moxi cases, but some auth B2B
    tests were depending on the old (rather generous) timeout settings,
    which this change now makes explicit.
    
    Change-Id: Id23365ade273ec301e5c2e7ecc1b068e40f6e521
    Reviewed-on: http://review.membase.org/6037
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
Commits on May 5, 2011
  1. MB-3742 - 512 ought to be enough for any stats

    steveyen committed May 4, 2011
    Change-Id: I36d29bb60f05946ac945301f884eb4aed26b766e
    Reviewed-on: http://review.membase.org/5936
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
Commits on May 2, 2011
  1. Exit if empty -z configuration

    steveyen committed Apr 29, 2011
    Change-Id: I591319f81f1e8ed1f42d9d709876f774eb05159b
    Reviewed-on: http://review.membase.org/5836
    Reviewed-by: Bin Cui <bin.cui@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
Commits on Apr 29, 2011
  1. Allow comment characters in -Z config files

    steveyen authored and bcui6611 committed Apr 29, 2011
    Change-Id: I1a8ace6c4a4b40a8e827223748b4645f45e0a861
    Reviewed-on: http://review.membase.org/5829
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Reviewed-by: Bin Cui <bin.cui@gmail.com>
  2. usage() help on -l and -d flags

    steveyen committed Apr 29, 2011
    Change-Id: Ied0c517ac861b7cfa0f4e5376e2abc73600e8148
    Reviewed-on: http://review.membase.org/5825
    Reviewed-by: Bin Cui <bin.cui@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
  3. pt-12636461 - default timeout config

    steveyen committed Apr 25, 2011
    Values taken from the default configurations from membase/ns_server
    for server-side moxi.
    
    Change-Id: I261b02b86e30962d6278dca3c8077d5563fd8652
    Reviewed-on: http://review.membase.org/5632
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
Commits on Mar 29, 2011
  1. MB-2403 - default to 200ms clock cycle for better logging

    steveyen authored and alk committed Mar 29, 2011
    Change-Id: I046b42b604957f8a25dbf5809208cb370470cb53
    Reviewed-on: http://review.membase.org/5133
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Commits on Mar 14, 2011
  1. Make Moxi compile without libconflate.

    tsuna authored and steveyen committed Mar 14, 2011
    Change-Id: I32258c4b0f8d837ce81e07559f425c9a95cecb80
    Reviewed-on: http://review.membase.org/4899
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
  2. Remove version.sh.

    tsuna authored and alk committed Mar 14, 2011
    This script was superseded by config/autorun.sh.
    
    Change-Id: I9922a66360cd15c659f1ff28bd92025e1da0d383
    Reviewed-on: http://review.membase.org/4898
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Commits on Mar 7, 2011
  1. fixed warning from comparing different enum types

    Aliaksey Kandratsenka authored and steveyen committed Mar 7, 2011
    Change-Id: I52c0ae14c4633353745a0b1ba1a3956cb1734c5f
    Reviewed-on: http://review.membase.org/4805
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
Commits on Mar 3, 2011
  1. remove bogus www.danga.com/moxi link

    Aliaksey Kandratsenka authored and steveyen committed Mar 2, 2011
    Change-Id: Ic30a41ee9de3490a0b95f1d7d9408c21f1a6e348
    Reviewed-on: http://review.membase.org/4773
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
Commits on Feb 19, 2011
  1. MB-3447 - binary protocol err handling

    steveyen authored and alk committed Feb 19, 2011
    Need to schedule the upstream conn into libevent so the error response
    actually gets written to socket.
    
    Change-Id: Id058e9dc84beeb2b109b99787b1ee9fc35dbbb38
    Reviewed-on: http://review.membase.org/4664
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Commits on Feb 10, 2011
  1. made binary proxy stats include all cmd stats

    Aliaksey Kandratsenka authored and steveyen committed Feb 9, 2011
    Change-Id: I765a7642f4f755626c9a4192158e8a99bb6801ad
    Reviewed-on: http://review.membase.org/4500
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  2. added stats for local & total latencies

    Aliaksey Kandratsenka authored and steveyen committed Feb 9, 2011
    NOTE: that we assume that first server in downstream server list is
    'local'. Corresponding change will be made to ns_server.
    
    Change-Id: I8dd5c61828f6cdcc3c75a0e4f8d2559731701341
    Reviewed-on: http://review.membase.org/4499
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>