Skip to content
Commits on Jun 19, 2010
  1. @steveyen

    bug 1429 - stop retrying after too many ascii-to-binary retries

    There are two cases of retry tracking added here, so code
    needed fixing in 2 different places...
    
    - for simple, single-shot mutation commands
    - for scatter-gather GETKQ's and NOOP translation case
    
    Also, fixed a case when the multiget was NULL, introduced
    in a previous performance enhancement fix.
    
    Change-Id: I043f12f9733624b225196c29b144f5b1e02e5852
    Reviewed-on: http://review.northscale.com:8080/700
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    steveyen committed Jun 19, 2010
  2. @steveyen

    turn off the front_cache matcher and key_stats by default

    for more performance
    
    Change-Id: Idcefbc13bed99952bbd8633f8057b2296301e8d9
    Reviewed-on: http://review.northscale.com:8080/697
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    steveyen committed Jun 19, 2010
  3. @steveyen

    moxi is faster without slabber

    Using the slabber's global lock is worse than using straight malloc in
    moxi.  This change probably prevents moxi from working right as a
    memcached server, but it'll now be a faster proxy, consuming less CPU
    resource.
    
    Change-Id: I976aa01c1c1a24d665d9cadcfd3e3c8c43fbf095
    Reviewed-on: http://review.northscale.com:8080/696
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Reviewed-by: Matt Ingenthron <matt@northscale.com>
    Reviewed-by: Eric Lambert <eric.d.lambert@gmail.com>
    steveyen committed Jun 19, 2010
  4. @steveyen

    avoid dedupe map during single-key gets

    Change-Id: I84f6ca20ae0b52bce59e543d7de405f2e00923f0
    Reviewed-on: http://review.northscale.com:8080/695
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Reviewed-by: Eric Lambert <eric.d.lambert@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    steveyen committed Jun 18, 2010
  5. @steveyen

    b2b upstream & downstream for simple, non-quiet commands

    Change-Id: I25c4e4a4fa1cac101aa19853f47857914dfc0836
    Reviewed-on: http://review.northscale.com:8080/687
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    steveyen committed Jun 15, 2010
  6. @steveyen

    negotiating_proxy_prot added

    Change-Id: I3891502bacdf0701813060548dc66f8927374492
    Reviewed-on: http://review.northscale.com:8080/686
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Reviewed-by: Eric Lambert <eric.d.lambert@gmail.com>
    steveyen committed Jun 15, 2010
  7. @steveyen

    binary protocol fix to is_compatible_request

    Change-Id: Ib7c9d034ceee29502409571c6f0d6f3c4b9030dc
    Reviewed-on: http://review.northscale.com:8080/685
    Reviewed-by: Dustin Sallings <dustin@spy.net>
    Tested-by: Steve Yen <steve.yen@gmail.com>
    steveyen committed Jun 15, 2010
  8. @steveyen @CaptTofu

    bug 1074 - upstream_error() supports b2b proxying

    Need to write a binary error response when the upstream protocol
    is binary protocol.
    
    Change-Id: Iacdb108b42abfe6cf57b8e028bd744dd2978a144
    Reviewed-on: http://review.northscale.com:8080/684
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Patrick M. Galbraith <patg@patg.net>
    Reviewed-by: Patrick M. Galbraith <patg@patg.net>
    steveyen committed with CaptTofu Jun 15, 2010
Commits on Jun 18, 2010
  1. @steveyen @dustin

    bug 1431 - moxi invokes vbucket_compare()

    so that moxi does a better job of reusing pre-existing
    downstream connections.
    
    Change-Id: I9f803b062bf6f94e7d9f0a52d3e697826de29a50
    Reviewed-on: http://review.northscale.com:8080/651
    Reviewed-by: Dustin Sallings <dustin@spy.net>
    Tested-by: Dustin Sallings <dustin@spy.net>
    steveyen committed with dustin Jun 17, 2010
  2. @steveyen

    upstream_retry when multi-GET not-my-vbucket err

    Change-Id: Iebbae35b0509cc16cbaf4610a3e433b60b71b94b
    
    In this implementation of handling not-my-bucket errors during
    ascii-to-binary proxying, we use the binary header's opaque field.
    
    moxi uses the opaque field to store either a vbucket id or a key
    index, depending on the command opcode.  The key index is for a char
    array, and is used to retreive the key for a given command.  Given the
    key, moxi can then re-retrieve the vbucket id.
    
    Given the vbucket id, finally, during a not-my-vbucket error, moxi can
    then call the incorrect_master() API of libvbucket.
    
    Change-Id: I8f7f015a4d0392834778654c2b9441f432a09db0
    Reviewed-on: http://review.northscale.com:8080/642
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Patrick M. Galbraith <patg@northscale.com>
    Reviewed-by: Patrick M. Galbraith <patg@northscale.com>
    steveyen committed Jun 17, 2010
Commits on Jun 17, 2010
  1. @steveyen @dustin

    hooked up vbucket_found_incorrect_master()

    Change-Id: I20c9da6f775a3532c7406430c261195a0f6b47b8
    Reviewed-on: http://review.northscale.com:8080/635
    Reviewed-by: Dustin Sallings <dustin@spy.net>
    Tested-by: Dustin Sallings <dustin@spy.net>
    steveyen committed with dustin Jun 17, 2010
  2. @steveyen @dustin

    handle not-my-vbucket error for simple, non-get, with-reply cmds

    Change-Id: I35a1cd83306d13bc6c80735c3a5fdda24f6d5a4f
    Reviewed-on: http://review.northscale.com:8080/634
    Tested-by: Dustin Sallings <dustin@spy.net>
    Reviewed-by: Dustin Sallings <dustin@spy.net>
    steveyen committed with dustin Jun 17, 2010
  3. @steveyen @dustin

    updated moxi's PROTOCOL_BINARY enum's

    Change-Id: I724f287b0ba2b40c5936aa6c578d4af87b71a8f4
    Reviewed-on: http://review.northscale.com:8080/633
    Tested-by: Dustin Sallings <dustin@spy.net>
    Reviewed-by: Dustin Sallings <dustin@spy.net>
    steveyen committed with dustin Jun 17, 2010
Commits on Jun 15, 2010
  1. @steveyen

    bug 1362 - more casting to allow rhel build

    Change-Id: I028108b704f015ccd958962d99c5aecd92ef4e66
    Reviewed-on: http://review.northscale.com:8080/576
    Reviewed-by: Eric Lambert <eric.d.lambert@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
    steveyen committed Jun 15, 2010
  2. @steveyen

    bug 1362 - moxi should use long long unsigned int

    Change-Id: I4b2a9f18dc2ac7ced7159a7cdbf808b41fa7842b
    Reviewed-on: http://review.northscale.com:8080/570
    Reviewed-by: Patrick M. Galbraith <patg@northscale.com>
    Tested-by: Patrick M. Galbraith <patg@northscale.com>
    steveyen committed with Patrick M. Galbraith Jun 15, 2010
  3. @steveyen

    bug 1362 - moxi should use uint64 for stats math

    Change-Id: I44167cc0e5110b7bdf151dcd5f3820a849df8716
    Reviewed-on: http://review.northscale.com:8080/564
    Reviewed-by: Eric Lambert <eric.d.lambert@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
    steveyen committed Jun 15, 2010
  4. @steveyen

    better printf during timeout handling

    Change-Id: I33a65eab076548d5f98f6de3bd0715e86f43304b
    Reviewed-on: http://review.northscale.com:8080/557
    Reviewed-by: Eric Lambert <eric.d.lambert@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
    steveyen committed Jun 15, 2010
  5. @steveyen

    bug 1349 - re-enabling verbosity for memcapable

    Change-Id: I9238b122967857471dcc611cfcc3e17c4c17a884
    Reviewed-on: http://review.northscale.com:8080/556
    Reviewed-by: Eric Lambert <eric.d.lambert@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
    steveyen committed Jun 15, 2010
  6. @steveyen

    bug 1349 - moxi ascii-2-binary was messing up noreply semantics.

    moxi was treating the downstream binary protocol quiet commands
    incorrectly with the same semantics as the upstream ascii noreply
    commands.
    
    This fix has moxi send translate any ascii noreply commands into a
    binary command with a magic opaque OPAQUE_IGNORE_REPLY value.  Any
    binary responses with that magic opaque value will be dropped by moxi.
    
    Change-Id: Ibb3b14a7493cc3640bf0d7eb2044b028adcfec39
    Reviewed-on: http://review.northscale.com:8080/555
    Reviewed-by: Eric Lambert <eric.d.lambert@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
    steveyen committed Jun 15, 2010
  7. @steveyen

    more unified debug logging

    Change-Id: Ied594afb8718102bc78d6e783437fb6ebdf1abc1
    Reviewed-on: http://review.northscale.com:8080/554
    Reviewed-by: Eric Lambert <eric.d.lambert@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
    steveyen committed Jun 15, 2010
  8. @steveyen

    bug 1349 - moxi gets a little more memcapable

    Change-Id: Ia796adb406c8866522ac8155536bae2fc3878977
    Reviewed-on: http://review.northscale.com:8080/545
    Reviewed-by: Dustin Sallings <dustin@spy.net>
    Reviewed-by: Eric Lambert <eric.d.lambert@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
    steveyen committed Jun 15, 2010
Commits on Jun 14, 2010
  1. @steveyen

    comments around magic sizeof numbers

    Change-Id: I61ca3a888a66fe09045432b420126debdadbb434
    Reviewed-on: http://review.northscale.com:8080/508
    Tested-by: Patrick M. Galbraith <patg@northscale.com>
    Reviewed-by: Patrick M. Galbraith <patg@northscale.com>
    steveyen committed Jun 14, 2010
  2. @steveyen

    bug 1306 - incr/decr a2b fixed via sizeof() fixes

    incr/decr a2b was failing due to wrong # of header bytes.
    
    I had expected sizeof(protocol_binary_request_decr) to be 44 (24 +
    20), but instead it returns 48.
    
    So, doing the math explicitly instead now, via...
    
      sizeof(protocol_binary_request_header) + 20
    
    Change-Id: Ic3da8bbad4d99a6359634c710a7bd4de3a833c8c
    Reviewed-on: http://review.northscale.com:8080/507
    Tested-by: Patrick M. Galbraith <patg@northscale.com>
    Reviewed-by: Patrick M. Galbraith <patg@northscale.com>
    steveyen committed Jun 14, 2010
  3. @steveyen

    Bug 1321 - moxi GET was not passing vbucket

    All the commands were passing along the vbucket parameter, except
    for the 'get' implementation.  And that is now fixed.
    
    Change-Id: I3e0d89bcaf6e69e9e9761dfc7bb332097de5fa05
    Reviewed-on: http://review.northscale.com:8080/490
    Reviewed-by: Eric Lambert <eric.d.lambert@gmail.com>
    Reviewed-by: Dustin Sallings <dustin@spy.net>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
    steveyen committed Jun 13, 2010
Commits on Jun 13, 2010
  1. @steveyen

    config string might have newlines

    Change-Id: I1909171c8fc68e6bfa516eb5305b638195c2e6fb
    steveyen committed Jun 12, 2010
  2. @steveyen

    removed JHP_STATS conditional code

    So that we're always using the JHP codepath.
    
    Change-Id: I0cbebf5e9e01716d1c46088e18f5f6557b648048
    steveyen committed Jun 12, 2010
  3. @steveyen

    Added new ascii commands of "stats proxy sub-command".

    Merged enhancements from...
    
    commit 5aab94b307ccd8d8eb424da38764f733aa6c7da2
    Author: Joon(JunHyun Park) <junhyun.park@nhn.com>
    Date:   Tue Jun 8 15:36:15 2010 +0900
    
    Change-Id: I28cfb3f1acf080121afd438e1637fad50d5f3c5a
    Joon(JunHyun Park) committed with steveyen Jun 8, 2010
  4. @steveyen

    Reduce excessive memory usage by stats_prefix.

    A key without prefix is also registered in stats_prefix structure.
    It uses too much memory and lowers the performance in finding prefixes.
    So, I made the key not having prefix is not registered in stats_prefix.
    Joon(JunHyun Park) committed with steveyen Jun 8, 2010
  5. @dustin @steveyen

    Fixed version.m4 entry in .gitignore.

    Note that I've got a bit of emacs config that auto-sorts .gitignore as
    well.  It's for the better.
    
    Change-Id: I098916446b31b185bd265cfddb7fdee87649807c
    Reviewed-on: http://review.northscale.com:8080/451
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    dustin committed with steveyen Jun 12, 2010
  6. @dustin @steveyen

    version.m4 should not have been checked in.

    Change-Id: I6fbb82e036848f80ff3e5e5f1e04c03ad9304e69
    Reviewed-on: http://review.northscale.com:8080/450
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    dustin committed with steveyen Jun 12, 2010
Commits on Jun 12, 2010
  1. @steveyen
  2. @steveyen
  3. @steveyen

    mcs_create() failure fprintfs

    steveyen committed Jun 11, 2010
  4. @steveyen

    htons for vbucket field

    steveyen committed Jun 11, 2010
Commits on Jun 11, 2010
  1. @steveyen
Something went wrong with that request. Please try again.