{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":59219757,"defaultBranch":"master","name":"phosphor","ownerLogin":"couchbase","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2016-05-19T15:36:20.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/605755?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1699436553.0","currentOid":""},"activityList":{"items":[{"before":"97a9fcbc46268aab4c377c7de9840d5d8c5090c2","after":"a4d27b2bc07fb71b08af8d8295e97cad6f2ff39a","ref":"refs/heads/master","pushedAt":"2024-04-19T09:39:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"Cleanup: squash multiple test into same binary\n\nWe don't need to compile and link multiple binaries just\nto run a single gtest suite\n\nChange-Id: Ib3c988d6678e04895de5b96b09cbfc0aa02ca4a6\nReviewed-on: https://review.couchbase.org/c/phosphor/+/208737\nReviewed-by: Jim Walker \nTested-by: Trond Norbye ","shortMessageHtmlLink":"Cleanup: squash multiple test into same binary"}},{"before":"42fac86fab10936bf720e5c2aa399e141c676c65","after":"97a9fcbc46268aab4c377c7de9840d5d8c5090c2","ref":"refs/heads/master","pushedAt":"2024-04-19T09:39:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"Unify case in CMakeLists.txt\n\nThere was a mix of upper and lowercase. Unify to use lowercase\nand don't set the include directories on the top level directory\n\nChange-Id: Iced42bb1b9b036fb2cea96a0c9301b0a49d6ac30\nReviewed-on: https://review.couchbase.org/c/phosphor/+/208736\nReviewed-by: Jim Walker \nTested-by: Trond Norbye ","shortMessageHtmlLink":"Unify case in CMakeLists.txt"}},{"before":"69799aeba79e3b09f45b49979554f0378bd2fbf4","after":"42fac86fab10936bf720e5c2aa399e141c676c65","ref":"refs/heads/master","pushedAt":"2024-04-19T09:39:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"Remove unused examples\n\nChange-Id: I3d2c9c3a961e343121b5f2c2ed230ddbddf50a42\nReviewed-on: https://review.couchbase.org/c/phosphor/+/208735\nTested-by: Trond Norbye \nReviewed-by: Jim Walker ","shortMessageHtmlLink":"Remove unused examples"}},{"before":"4a156082630abebd1a8535b32d48fc631969737d","after":"69799aeba79e3b09f45b49979554f0378bd2fbf4","ref":"refs/heads/master","pushedAt":"2024-02-08T05:53:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"[clang-tidy] JSON export\n\nChange-Id: Ie70e0127f2642c3ecbe7d45e55cac9b1bb6c812c\nReviewed-on: https://review.couchbase.org/c/phosphor/+/204564\nReviewed-by: Pavlos Georgiou \nTested-by: Build Bot ","shortMessageHtmlLink":"[clang-tidy] JSON export"}},{"before":"2b60ad75472a886668e2d17369334dbadd23e59e","after":"4a156082630abebd1a8535b32d48fc631969737d","ref":"refs/heads/master","pushedAt":"2024-02-07T07:30:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"[clang-tidy] trace_context\n\npass by value and use std::move\n\nChange-Id: Id8cd8231f2c4a08056d494ffbc15f1097c05a19c\nReviewed-on: https://review.couchbase.org/c/phosphor/+/204494\nTested-by: Build Bot \nReviewed-by: Paolo Cocchi ","shortMessageHtmlLink":"[clang-tidy] trace_context"}},{"before":"0cbec074411ba87ae6f5f3920908a69228d55a8c","after":"2b60ad75472a886668e2d17369334dbadd23e59e","ref":"refs/heads/master","pushedAt":"2024-02-01T07:21:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"Extend the tests for the JSON\n\nParse the returned JSON with a JSON parser and verify\nthat it is as expected\n\nChange-Id: I3f9e584e471e9cdc669fb922d3f4320d6dfc5bd9\nReviewed-on: https://review.couchbase.org/c/phosphor/+/204493\nReviewed-by: Vesko Karaganev \nTested-by: Build Bot ","shortMessageHtmlLink":"Extend the tests for the JSON"}},{"before":"99f1a79407c0b34ba55d388d2bfea590bd4ea3ad","after":"0cbec074411ba87ae6f5f3920908a69228d55a8c","ref":"refs/heads/master","pushedAt":"2024-02-01T07:21:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"Don't try to (and fail) to format JSON\n\nThe JSON exporter tried to do some \"formatting\" of the resulting\njson with indentations, newlines and (inconsistently) space at\nvarious places, but did not do a very good job.\n\nThere are way better tools out there which handle formatting\nof JSON (and we want the smallest possible representation\nas we're going to send it over the wire to the client)\n\nChange-Id: Ib4779155e12c0448b0202a76206b684524b479bf\nReviewed-on: https://review.couchbase.org/c/phosphor/+/204446\nTested-by: Build Bot \nReviewed-by: Vesko Karaganev ","shortMessageHtmlLink":"Don't try to (and fail) to format JSON"}},{"before":"4fc5a245ed8a368f79d8c2056d5804b281187218","after":"99f1a79407c0b34ba55d388d2bfea590bd4ea3ad","ref":"refs/heads/master","pushedAt":"2024-01-30T15:05:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"[cleanup] Remove use of StringPtr\n\nThe extra complexity isn't needed as we don't use a shared\nlibrary\n\nChange-Id: I2d84819a262343a853a39ed277fbf7123dbdaaeb\nReviewed-on: https://review.couchbase.org/c/phosphor/+/204491\nTested-by: Build Bot \nReviewed-by: Paolo Cocchi ","shortMessageHtmlLink":"[cleanup] Remove use of StringPtr"}},{"before":"523724cbf381b6d42dcb194dab04910b4e90ec81","after":"4fc5a245ed8a368f79d8c2056d5804b281187218","ref":"refs/heads/master","pushedAt":"2024-01-30T14:52:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"[Cleanup] Remove PHOSPHOR_API as we don't build a DLL\n\nWe don't need the extra complexity setting the symbol visibility\n\nChange-Id: I23eaa1ea9ced5325dd350a8d84bd774fc1256078\nReviewed-on: https://review.couchbase.org/c/phosphor/+/204490\nReviewed-by: Jim Walker \nTested-by: Build Bot ","shortMessageHtmlLink":"[Cleanup] Remove PHOSPHOR_API as we don't build a DLL"}},{"before":"c0a034fe407eec4723f2e01db2d72762efdbc276","after":"523724cbf381b6d42dcb194dab04910b4e90ec81","ref":"refs/heads/master","pushedAt":"2024-01-29T13:57:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"[cleanup] clang-format source code\n\nReformat the code to meet our coding standard\n\nChange-Id: Ia8226e9ce975eadc9b1ae22c6258b9e8d124807f\nReviewed-on: https://review.couchbase.org/c/phosphor/+/204488\nTested-by: Build Bot \nReviewed-by: Jim Walker ","shortMessageHtmlLink":"[cleanup] clang-format source code"}},{"before":"f8bc436984bd8f1472c1043c4810cd23a93fd351","after":"c0a034fe407eec4723f2e01db2d72762efdbc276","ref":"refs/heads/master","pushedAt":"2023-11-15T08:32:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"Remove unused file gsl_p/span.h\n\nChange-Id: I7b2503045dcbd410bb9d06621e58f5f74e188192\nReviewed-on: https://review.couchbase.org/c/phosphor/+/200908\nTested-by: Build Bot \nReviewed-by: Paolo Cocchi ","shortMessageHtmlLink":"Remove unused file gsl_p/span.h"}},{"before":"21b93c688bd82a8ac993778add71f2b82405fcec","after":"f8bc436984bd8f1472c1043c4810cd23a93fd351","ref":"refs/heads/master","pushedAt":"2023-11-14T12:27:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"Use std::string_view instead of gsl::cstring_span\n\nin StatsCallback callback class\n\nChange-Id: I186b823da58fd117a99cf0361715af5b1e7ba701\nReviewed-on: https://review.couchbase.org/c/phosphor/+/200578\nReviewed-by: Paolo Cocchi \nTested-by: Trond Norbye ","shortMessageHtmlLink":"Use std::string_view instead of gsl::cstring_span"}},{"before":"b3687fd652c75884b89f769d44e76cf77eeb7354","after":"21b93c688bd82a8ac993778add71f2b82405fcec","ref":"refs/heads/master","pushedAt":"2023-11-14T12:24:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"Add Unity build\n\nChange-Id: Id2b958117701f600ca9077e92462f1b2c550f468\nReviewed-on: https://review.couchbase.org/c/phosphor/+/200814\nTested-by: Trond Norbye \nReviewed-by: Paolo Cocchi ","shortMessageHtmlLink":"Add Unity build"}},{"before":"9116a3cd3021b5cf2e233544ac385fe899970231","after":"b3687fd652c75884b89f769d44e76cf77eeb7354","ref":"refs/heads/master","pushedAt":"2023-10-02T11:05:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"MB-58833: Fix gcc -Wshadow=compatible-local warnings\n\nWe have recently hit a nasty issue caused by variable shadowing and the\nconsequent usage of the wrong variable reference (MB-58463).\n\nThe -Wshadow flag would give us a compilation warning and reduce the\nchance of making that kind of error.\n\nHere we fix phosphor before enabling the flag in tlm.\n\nChange-Id: I62b30da2b2311e4f0d32d6eca4c3f00a1c85bd0f\nReviewed-on: https://review.couchbase.org/c/phosphor/+/197947\nReviewed-by: Trond Norbye \nTested-by: Paolo Cocchi ","shortMessageHtmlLink":"MB-58833: Fix gcc -Wshadow=compatible-local warnings"}},{"before":"a57a13c116b9f32cdbdebc1bce34560e5715600e","after":"9116a3cd3021b5cf2e233544ac385fe899970231","ref":"refs/heads/master","pushedAt":"2023-04-20T15:06:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"Apple clang supports thread_local\n\nWe've upgraded XCode so the old hacks are no longer needed\n\nChange-Id: I02a028bfbd1b97c6f2ba1a809035f8036b677f52\nReviewed-on: https://review.couchbase.org/c/phosphor/+/189925\nReviewed-by: Dave Rigby \nTested-by: Trond Norbye ","shortMessageHtmlLink":"Apple clang supports thread_local"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAENP7_-QA","startCursor":null,"endCursor":null}},"title":"Activity ยท couchbase/phosphor"}