This repository has been archived by the owner on Apr 20, 2022. It is now read-only.
improvement to config.w32 #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request!! To ensure quality review, Couchbase employs a code review system based on Gerrit to manage the workflow of changes in addition to tracking our contributor agreements. To get this change in and collaborate in code review, please register on Gerrit, accept our CLA and push your change there. More detailed instructions are available here: P.S. Our bot tells us you are currently unregistered on Gerrit. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please consider merging this tiny fix in order we can do the automatic PECL builds. Here's the build of the latest couchbase release using config.w32 patched
http://windows.php.net/downloads/pecl/releases/couchbase/1.1.5/
The problem with adding include/libcouchbase to includes is that it contains conflicting headers, so when a snapshot build is used, some extensions pull them in and fail to compile.