MB-30249 make INCLUDE mandatory

Change-Id: I1791159be7fe69f4ec2b6af72ae3c7ea3bf07be8 Reviewed-on: https://review.couchbase.org/c/query/+/175758 Tested-by: Sitaram Vemulapalli <sitaram.vemulapalli@couchbase.com> Reviewed-by: Bingjie Miao <bingjie.miao@couchbase.com>
couchbase · Jun 21, 2022 · dc3d5e2 · dc3d5e2
1 parent f979279
commit dc3d5e2
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/parser/n1ql/n1ql.y b/parser/n1ql/n1ql.y
@@ -2976,9 +2976,6 @@ ASC
 DESC
 { $$ = algebra.IK_DESC }
 |
-MISSING
-{ $$ = algebra.IK_MISSING }
-|
 INCLUDE MISSING
 { $$ = algebra.IK_MISSING }
 ;

diff --git a/test/gsi/test_cases/lkmissing/lkmissing_test.go b/test/gsi/test_cases/lkmissing/lkmissing_test.go
@@ -35,7 +35,7 @@ func TestLkMissing(t *testing.T) {
 	indexes := []string{
 		"CREATE PRIMARY INDEX %s ON %s;",
 		"CREATE INDEX %s ON %s(team, fname DESC, lname);",
-		"CREATE INDEX %s ON %s(ALL ARRAY FLATTEN_KEYS(c.id MISSING, c.type, c.default) FOR c IN contacts END, fname, lname, team)",
+		"CREATE INDEX %s ON %s(ALL ARRAY FLATTEN_KEYS(c.id INCLUDE MISSING, c.type, c.default) FOR c IN contacts END, fname, lname, team)",
 		"CREATE INDEX %s ON %s(ALL ARRAY FLATTEN_KEYS(c.id, c.type, c.default) FOR c IN contacts END, team)",
 		"CREATE INDEX %s ON %s(fname INCLUDE MISSING DESC, lname, team);",
 		"CREATE INDEX %s ON %s(fname INCLUDE MISSING DESC, lname, team, DISTINCT ARRAY FLATTEN_KEYS(v.id, v.type, v.default) FOR v IN contacts END);",