New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of GoCB opTimeout value #3508

Closed
tleyden opened this Issue Apr 25, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@tleyden
Copy link
Contributor

tleyden commented Apr 25, 2018

Problems with current behavior

  1. Can create an undesirable positive feedback loop where retries trigger more ops which further degrades the performance of the SDK, which causes further timeouts, etc...
  2. Increases # of open HTTP request sockets
  3. SG API client's (aka CBLite most of the time) HTTP requests can timeout, which will cause t and they implement retry on the client side, which will exacerbate the positive feedback loop mentioned above.

Interim fix

  • Allow users to increase the opTimeout value that triggers timeouts. The current default value is 2.5s.
  • Possibly increase the current default value

This came out of the investigation into the cause of #3212

@tleyden tleyden added this to the 3.0.0 milestone Apr 25, 2018

@tleyden tleyden referenced this issue Apr 25, 2018

Open

Improve GoCB backpressure handling #3509

0 of 1 task complete

@tleyden tleyden modified the milestones: 3.0.0, 2.1.0 Apr 25, 2018

@tleyden tleyden added the P1: high label Apr 25, 2018

tleyden pushed a commit that referenced this issue Apr 25, 2018

@tleyden tleyden self-assigned this Apr 25, 2018

tleyden added a commit that referenced this issue Apr 27, 2018

Fixes #3508 Allow configuration of GoCB opTimeout value (#3512)
* Fixes #3508 Allow configuration of GoCB opTimeout value

* PR feedback - improve variable name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment