Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure consistent use of http.DefaultTransport #3792

Closed
bbrks opened this issue Oct 10, 2018 · 0 comments

Comments

@bbrks
Copy link
Member

commented Oct 10, 2018

Currently Sync Gateway creates http clients for multiple use cases (webhooks, OIDC, CBS REST calls). These don't consistently pick up the http_proxy/https_proxy/no_proxy environment variables, due to the way the http.Client and http.Transport are initialized.

Wherever we specify a http.Client with a custom http.Transport, we should inherit the properties from http.DefaultTransport.

This gives us several things for free, including forward-proxy support via the http_proxy/https_proxy/no_proxy environment variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.