Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid nested read locks on BucketLock #3898

Closed
adamcfraser opened this issue Jan 9, 2019 · 0 comments

Comments

@adamcfraser
Copy link
Contributor

commented Jan 9, 2019

Calls to unmarshalPrincipal are making nested read lock on context.BucketLock, which deadlocks when someone else requests the write lock between the two read locks.

The BucketLock handling in general looks like a relatively clunky way to avoid races associated with bucket teardown. Should be cleaned up or potentially removed altogether.

@adamcfraser adamcfraser self-assigned this Jan 9, 2019

@adamcfraser adamcfraser added this to the Iridium milestone Jan 9, 2019

@adamcfraser adamcfraser added the P1: high label Jan 9, 2019

@bbrks bbrks closed this in #3899 Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.