Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR wires a metadata store through DCP client setup so persistent DCP checkpoints can be stored outside the streamed collection, covering both Couchbase Server and Rosmar-backed feeds.
Changes:
- Adds
MetadataStoreto DCP client option structs and forwards it to GoCB and Rosmar DCP clients. - Updates import, resync, attachment migration, and attachment compaction DCP option construction to pass database metadata stores.
- Bumps
sg-bucketandrosmarmodule versions and updates related tests.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updates sg-bucket and rosmar dependency versions. |
| go.sum | Updates checksums for the bumped dependencies. |
| db/import_listener.go | Passes database metadata store to import DCP feed options. |
| db/background_mgr_resync_dcp.go | Passes metadata store to resync DCP options. |
| db/background_mgr_attachment_migration.go | Threads metadata store into attachment migration DCP options. |
| db/background_mgr_attachment_migration_test.go | Updates test helper call for the new metadata store argument. |
| db/attachment_compaction.go | Passes metadata store to attachment compaction DCP options. |
| base/rosmar_dcp_client.go | Forwards metadata store into Rosmar feed arguments and checkpoint purge lookup. |
| base/gocb_dcp_feed.go | Removes obsolete GoCB DCP feed startup implementation. |
| base/gocb_dcp_client.go | Adds persistent metadata store option to GoCB DCP client creation. |
| base/dcp_client.go | Adds metadata store option validation and forwards it to GoCB DCP options. |
| base/dcp_client_test.go | Updates DCP tests to provide metadata stores where persistent checkpoints are used. |
bbrks
requested changes
May 18, 2026
bbrks
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CBG-5367
Adds ability to pass down metadata store into dcp client for both rosmar and CBS
Pre-review checklist
fmt.Print,log.Print, ...)base.UD(docID),base.MD(dbName))docs/apiDependencies (if applicable)
Integration Tests