Skip to content

Loading…

Fixed make usage #1

Closed
wants to merge 1 commit into from

1 participant

@stevenh

Fixed make usage so its compatible with machines whos default make is not gmake

@stevenh

Closing due to not being relevant any more.

@stevenh stevenh closed this
@ns-codereview ns-codereview pushed a commit that referenced this pull request
@jimwwalker jimwwalker ThreadSanitizer: Suppress libc tzset_internal which has a known data-…
…race.

Write of size 8 at 0x7d040000f5d0 by main thread:
 #0 free <null>:0
 #1 tzset_internal
 #2 ISOTime::generatetimestamp(std::array<char, 33ul>&, long, unsigned int)
 #3 ISOTime::generatetimestamp()
 #4 Audit::create_audit_event(unsigned int, cJSON*)
 #5 shutdown_auditdaemon
 #6 main

Previous write of size 8 at 0x7d040000f5d0 by thread T4 (mutexes: write M775):
 #0 malloc <null>:0
 #1 __GI___strdup
 #2 ISOTime::generatetimestamp(std::array<char, 33ul>&, long, unsigned int)
 #3 ISOTime::generatetimestamp()
 #4 put_json_audit_event
 #5 audit_invalid_packet crtstuff.c:0
 #6 process_bin_packet(Connection*)
 #7 Connection::runStateMachinery()
 #8 run_event_loop
 #9 event_handler(int, short, void*)
 #10 event_base_loop <null>:0
 #11 platform_thread_wrap

This is triggered by our use of mktime in isotime.cc. We're not the first
to encounter this and suppress it.

https://code.google.com/p/chromium/issues/detail?id=78014
http://src.chromium.org/svn/trunk/src/tools/valgrind/tsan/suppressions.txt?p=115967

Change-Id: I8cb46e085adc0d18230bd51eebf2195ed1a5c453
Reviewed-on: http://review.couchbase.org/55393
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: buildbot <build@couchbase.com>
cefb5a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 9, 2012
  1. @stevenh
Showing with 3 additions and 3 deletions.
  1. +3 −3 Makefile.top
View
6 Makefile.top
@@ -66,7 +66,7 @@ DIST_COMPONENTS_EXTRA = couchbase-python-client
DIST_COMPONENTS = $(filter-out libcouchbase, $(COMPONENTS)) $(DIST_COMPONENTS_EXTRA)
dist:
- for i in $(DIST_COMPONENTS); do (cd $$i && rm -f *.tar.gz && make dist || true); done
+ for i in $(DIST_COMPONENTS); do (cd $$i && rm -f *.tar.gz && $(MAKE) dist || true); done
mkdir -p tmp/$(DIST_PRODUCT)_src
rm -rf tmp/$(DIST_PRODUCT)_src/*
(for i in $(DIST_COMPONENTS); do \
@@ -105,10 +105,10 @@ do-install-all: $(MAKE_INSTALL_TARGETS) $(MAKE_INSTALL_TARGETS_EX) make-install-
rm -f memcached*log
clean: -clean-common
- for i in $(COMPONENTS); do (cd $$i && make clean || true); done
+ for i in $(COMPONENTS); do (cd $$i && $(MAKE) clean || true); done
distclean: -clean-common
- for i in $(COMPONENTS); do (cd $$i && make distclean || true); done
+ for i in $(COMPONENTS); do (cd $$i && $(MAKE) distclean || true); done
rm -rf install tmp
rm -f moxi*log
rm -f memcached*log
Something went wrong with that request. Please try again.