Fix one static analyzer issue and three warnings #76

Open
wants to merge 2 commits into
from

Projects

None yet

2 participants

@tciuro
tciuro commented Feb 9, 2014

Hi Jens,

I just cleaned a couple issues I found:

Static analyzer issue:

/CouchCocoa/Couch/CouchQuery.m:114:9: Value argument to 'setObject:forKey:' cannot be nil

Warning:

implicit conversion from enumeration type 'enum NSJSONReadingOptions' to different enumeration type 'NSJSONWritingOptions' (aka 'enum NSJSONWritingOptions')

-- Tito

Tito Ciuro added some commits Feb 9, 2014
Tito Ciuro Fix: implicit conversion from enumeration type 'enum NSJSONReadingOpt…
…ions' to different enumeration type 'NSJSONWritingOptions' (aka 'enum NSJSONWritingOptions')
d9d7591
Tito Ciuro Fix: value argument to 'setObject:forKey:' cannot be nil 09e3e9b
@snej
Member

The bug is actually on this line — it should use _endKeyDocID instead of _startKeyDocID. (And then take out your previous change, which will be wrong.)

@tciuro
tciuro commented on 09e3e9b Feb 9, 2014

Sounds good... you know the code better than me ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment