Tiny patch which removes username and password from the logs #87

Merged
merged 3 commits into from Mar 1, 2013

Projects

None yet

3 participants

@cesine
Contributor
cesine commented Feb 20, 2013

The logs log out the entire remote, including the couchdb username and password if any ie:
before :

 TDPusher[http://adminuser:supersecretpassswordnotsosecretanymore@yourcouch.iriscouch.com/yourdb] STARTING ...
02-19 23:23:59.010: V/TDDatabase(4135): Making request to http://adminuser:supersecretpassswordnotsosecretanymore@yourcouch.iriscouch.com/yourdb/_changes?feed=longpoll&limit=50&heartbeat=300000&since=1

now:

 02-19 21:34:07.480: V/TDDatabase(2325): TDPusher[http://---:---@yourcouch.iriscouch.com/yourdb] STARTING ...
02-19 23:23:59.010: V/TDDatabase(4135): Making request to http://---:---@yourcouch.iriscouch.com/yourdb/_changes?feed=longpoll&limit=50&heartbeat=300000&since=1
@jchris jchris commented on the diff Mar 1, 2013
...rc/com/couchbase/touchdb/replicator/TDReplicator.java
@@ -105,7 +105,9 @@ public void databaseClosing() {
}
public String toString() {
@jchris
jchris Mar 1, 2013 Contributor

are there other places this string representation matters? eg for calculating revision ids or anything? If there's not, then I'm happy to merge this.

@mschoch
mschoch Mar 1, 2013 Member

Its probably safe. Simplest thing to do is apply the patch and run the
unit tests.

marty

On Fri, Mar 1, 2013 at 2:59 PM, Chris Anderson notifications@github.comwrote:

In TouchDB-Android/src/com/couchbase/touchdb/replicator/TDReplicator.java:

@@ -105,7 +105,9 @@ public void databaseClosing() {
}

 public String toString() {

are there other places this string representation matters? eg for
calculating revision ids or anything? If there's not, then I'm happy to
merge this.


Reply to this email directly or view it on GitHubhttps://github.com/couchbaselabs/TouchDB-Android/pull/87/files#r3210086
.

@jchris jchris merged commit 04333b2 into couchbaselabs:master Mar 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment