This repository has been archived by the owner on Mar 9, 2022. It is now read-only.
Bug fix to #266 whereby TDRouter could get messaged after deallocation #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/issues/266: TDHTTPResponse -cleanUp should rstop the router from observing notifications. Q: is this a good way to fix - should cleanUp instead set _router to nil or call its -stopNow which does the same, also in a synchronized way?
…DB-iOS/issues/266" This reverts commit 85d2761.
…chDB-iOS/issues/266: TDHTTPResponse -cleanUp should rstop the router from observing notifications. Q: is this a good way to fix - should cleanUp instead set _router to nil or call its -stopNow which does the same, also in a synchronized way?" This reverts commit 56aea02.
…that the roouter doesn't get deallocated during it, as suggested by @snej in https://github.com/couchbaselabs/TouchDB-iOS/issues/266#issuecomment-19927084
|
I'm pretty sure your fix works. I've reverted my changes and applied yours. If you decide to take it in, probably good idea to squash my changes when merging. |
|
Made redundant by 9606ce9 |
|
Since I have my patch in my source tree already, I'll just commit that instead of going through the squashing :) Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround (fix?) to https://github.com/couchbaselabs/TouchDB-iOS/issues/266 whereby TDRouter could get messaged after deallocation. Problem appears to be caused by a race condition whereby TDRouter's notification observer callback is started on one thread, and the router is deallocated on another (dealloc itself will send -stopNow to and thereby remove the notification observer, but this wasn't threadsafe).