Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Feb 15, 2012
  1. @chiyoung @trondn

    Add more comprehensive log messages to dispatcher modules.

    chiyoung authored trondn committed
    Change-Id: I05d30db4fca4ac60a17e691c9c602087090978a1
    Reviewed-on: http://review.couchbase.org/13240
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Commits on Apr 21, 2011
  1. @trondn @chiyoung

    Allow some tasks to be completed during forced shutdown

    trondn authored chiyoung committed
    Change-Id: I66f4bc6b12e062b071466f3a3da6f77c2252fa53
    Reviewed-on: http://review.membase.org/5504
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Chiyoung Seo <chiyoung.seo@gmail.com>
    Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>
Commits on Apr 11, 2011
  1. @trondn @chiyoung

    Use threadlocal storage to keep track of the current engine

    trondn authored chiyoung committed
    Change-Id: Id0d5de0c6f7509467f0cc4caef5de692cd9787a4
    Reviewed-on: http://review.membase.org/5306
    Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>
    Tested-by: Chiyoung Seo <chiyoung.seo@gmail.com>
Commits on Feb 2, 2011
  1. @chiyoung @trondn

    MB-2771 - Support for the force shutdown.

    chiyoung authored trondn committed
    This change extends the engine's destroy API to support the force
    shutdown.
    
    Change-Id: Ife7ad317bcf1bfd842c321cd2e5454a316ff6779
    Reviewed-on: http://review.membase.org/4379
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Bin Cui <bin.cui@gmail.com>
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Commits on Dec 10, 2010
  1. @dustin @chiyoung

    Removed a gettimeofday call from the dispatcher loop.

    dustin authored chiyoung committed
    Change-Id: Ib8025977628de1cb3008b5eef4f2290cafca3622
    Reviewed-on: http://review.membase.org/4010
    Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>
    Tested-by: Chiyoung Seo <chiyoung.seo@gmail.com>
Commits on Nov 25, 2010
  1. @dustin @trondn

    Cleaned up dispatcher notifications and idle task interaction.

    dustin authored trondn committed
    A race condition allowed an idle task to start as another task was
    being added in such a way that the idle task wasn't notified and the
    job execution was delayed.
    
    This mostly showed up in slow execution of tests (the generated tests
    were the most likely since most of them were here), but would happen
    any time an idle task and another task interacted.
    
    Change-Id: I06fd0ff8370acde2dac613f9168c14c532dfdd26
    Reviewed-on: http://review.membase.org/3863
    Reviewed-by: Toby DiPasquale <toby@cbcg.net>
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Commits on Nov 24, 2010
  1. @dustin @trondn

    Fix max duration of idle job.

    dustin authored trondn committed
    My comment was dumb as I realized that it's actually nearly 600 years
    worth of nanoseconds you can fit into a 64-bit number.  You just can't
    do it as a single literal.
    
    Change-Id: Ib94d4a25e83f39becc96d3bfde974c966ca8f8ca
    Reviewed-on: http://review.membase.org/3840
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
  2. @dustin @trondn

    Have IdleTask account for dispatcher idle time.

    dustin authored trondn committed
    This moves the sleep logic out and slightly reduces the special cases
    in the dispatcher such that the only time it's not running a job is
    when there is no job ever to run.
    
    Change-Id: Ie48f2334d69e7d20b4223418fde7fb5b1b7125ff
    Reviewed-on: http://review.membase.org/3835
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Commits on Nov 14, 2010
  1. @dustin

    MB-2661 Show recent "slow" jobs.

    dustin authored
    This adds to the dispatcher job logging to show which things were
    taking longer than we expected them to take.
    
    Change-Id: Ib0f726fb610ffbbbcc28775a10156b92ace208bf
    Reviewed-on: http://review.membase.org/3669
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Tested-by: Dustin Sallings <dustin@spy.net>
Commits on Nov 1, 2010
  1. @chiyoung @dustin

    Get a task's name by calling the DispatcherCallback's description()

    chiyoung authored dustin committed
    This allows us to get the task's name by invoking the
    DispatcherCallback's description() that can be used for providing
    the task's current status.
    
    Change-Id: Ic49c4f02a7d9882e33a7cdd6d877473758204d13
    Reviewed-on: http://review.membase.org/3488
    Tested-by: Dustin Sallings <dustin@spy.net>
    Reviewed-by: Dustin Sallings <dustin@spy.net>
  2. @dustin @trondn

    Report recent task runs in dispatcher stats.

    dustin authored trondn committed
    You can optionally ask the stats tool for information on previous
    dispatcher runs.
    
     dispatcher
         state:  dispatcher_running
         status: idle
         Log:
            runtime:   7us
            starttime: 1542
            task:      Paging out items.
            ---------
            runtime:   8us
            starttime: 1542
            task:      Running a flusher loop.
    [...]
    
    Change-Id: Ibdac22bf858a5aed31c18c1d7b07608107bc2c08
    Reviewed-on: http://review.membase.org/3450
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
Commits on Oct 8, 2010
  1. @dustin @seanlynch

    More meaningful dispatcher stats since there are fewer states

    dustin authored seanlynch committed
    Change-Id: If5194949120d0e21d6ad6a466e536df15ce86090
    Reviewed-on: http://review.northscale.com/3157
    Reviewed-by: Sean Lynch <seanl@literati.org>
    Tested-by: Sean Lynch <seanl@literati.org>
  2. @dustin @seanlynch

    bug 2656 - fix prioritization of future scheduled events

    dustin authored seanlynch committed
    This splits the task priority queue into two -- one for "ready" tasks
    to be executed in priority order and another for "future" tasks which
    are to be added to the "ready" queue as soon as their due date
    permits.
    
    This change will increase our gettimeofday calls around scheduling
    since every task should now have a "due" date, but this is only at
    creation, rescheduling, and execution times.
    
    Change-Id: I600641ebd5b4764e140d4bde5bc9e243f7f99aba
    Reviewed-on: http://review.northscale.com/3156
    Reviewed-by: Sean Lynch <seanl@literati.org>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Sean Lynch <seanl@literati.org>
Commits on Oct 7, 2010
  1. @dustin @chiyoung

    Added dispatcher stats so we can see what they're doing.

    dustin authored chiyoung committed
    This will help me give a better answer when someone says, ``It's using
    all of the CPU, but not doing anything.''  It's doing *something*.
    Now I can know what.
    
    Change-Id: I9e9315ceb6a23d16cc11871b321fa945163acac6
    Reviewed-on: http://review.northscale.com/3129
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>
    Tested-by: Chiyoung Seo <chiyoung.seo@gmail.com>
Commits on Sep 9, 2010
  1. @chiyoung

    bug 2295 - Support both daemon and non-daemon tasks

    chiyoung authored Matt Ingenthron committed
    We should be able to schedule a task with a soft guarantee that it
    will run so that the shutdown procedure can ignore any task that is
    considered daemon, but will run all tasks (e.g., vBucket deletion)
    that are declared to be important.
    
    Change-Id: I74b574e4e217da6007729216c1679abfb97a584a
    Reviewed-on: http://review.northscale.com/2319
    Reviewed-by: Dustin Sallings <dustin@spy.net>
    Tested-by: Dustin Sallings <dustin@spy.net>
    Reviewed-by: Matt Ingenthron <matt@northscale.com>
    Tested-by: Matt Ingenthron <matt@northscale.com>
Commits on Sep 3, 2010
  1. @chiyoung @dustin

    Bug 2270: Adjusted dispatcher job priorities

    chiyoung authored dustin committed
    Change-Id: I9cd38ec9bd6b9064e71bfd8648482527c41f51c3
    Reviewed-on: http://review.northscale.com/2223
    Reviewed-by: Dustin Sallings <dustin@spy.net>
    Tested-by: Dustin Sallings <dustin@spy.net>
Commits on Jun 23, 2010
  1. @dustin @steveyen

    Documentation for dispatcher.

    dustin authored steveyen committed
    Change-Id: I6fcb8c64e75ea132f0468bdf8ee9872e01f521f9
    Reviewed-on: http://review.northscale.com:8080/842
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
Commits on May 31, 2010
  1. @dustin @trondn

    Dispatcher and Flusher refactoring to prevent task ID races.

    dustin authored trondn committed
    The task ID is assigned within the dispatcher mutex preventing
    execution before receiving the assignment.  All flusher-side task ID
    read or write access is guarded by a mutex.
    
    Change-Id: I6111a44e6c4b87c7654a28d361c70b9c85fd3007
    Reviewed-on: http://review.northscale.com:8080/248
    Reviewed-by: Jayesh Jose <jjose@zynga.com>
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
Commits on May 30, 2010
  1. @dustin

    Move the bulk of the dispatcher implementation into the .cc file.

    dustin authored
    Change-Id: Ie3160a01bfb7696db70bdf8f2bc8691eeca0717c
    Reviewed-on: http://review.northscale.com:8080/247
    Tested-by: Matt Ingenthron <ingenthr@gmail.com>
    Reviewed-by: Matt Ingenthron <ingenthr@gmail.com>
  2. @dustin

    Don't try to stop a stopping dispatcher.

    dustin authored
    Change-Id: Idf53c2fa7cefcddabc02e82fee3e488537c67f0a
    Reviewed-on: http://review.northscale.com:8080/230
    Reviewed-by: Sean Lynch <seanl@literati.org>
    Tested-by: Sean Lynch <seanl@literati.org>
Commits on May 26, 2010
  1. @dustin

    Ensure the task ID gets assigned to the flusher before use.

    dustin authored
    Change-Id: Ia3b7e1e2b14576241ac74f1ffb7881a37b0e1df0
    Reviewed-on: http://review.northscale.com:8080/159
    Reviewed-by: Eric Lambert <eric.d.lambert@gmail.com>
    Tested-by: Dustin Sallings <dustin@spy.net>
Commits on May 18, 2010
  1. @seanlynch @dustin

    Make the dispatcher less chatty

    seanlynch authored dustin committed
    Change-Id: Ie456754b4c03a94fc426230433fb2f512a59d6d0
    Reviewed-on: http://review.northscale.com:8080/97
    Tested-by: Dustin Sallings <dustin@spy.net>
    Reviewed-by: Dustin Sallings <dustin@spy.net>
  2. @seanlynch @dustin

    Add dispatcher

    seanlynch authored dustin committed
    Change-Id: I408cc2f77bb7bee8258343ba3dc7bae1bfb03252
    Reviewed-on: http://review.northscale.com:8080/16
    Reviewed-by: Dustin Sallings <dustin@spy.net>
    Tested-by: Dustin Sallings <dustin@spy.net>
Something went wrong with that request. Please try again.