Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Jan 25, 2012
  1. @chiyoung

    Refactor engine's addUnlessThere() functions.

    chiyoung authored
    Change-Id: I3f11fdc822fc1087c93ebaa482f26cff41f3f1ba
    Reviewed-on: http://review.couchbase.org/12633
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Chiyoung Seo <chiyoung.seo@gmail.com>
Commits on Jan 21, 2012
  1. @t3rm1n4l @chiyoung

    Optimize restore query to improve restore performance

    t3rm1n4l authored chiyoung committed
    Most of the validations and ordering of mutations according to
    checkpoint id can be performed outside of ep-engine.
    The RestoreManager should be able to simply restore the given
    backup file without doing lot of validations. This patch adds an
    ep-engine parameter `restore_file_checks=false`, which can be used
    to enable or disable the validations on the backup file. The default
    value for restore_file_checks is true.
    
    It is seen that, upto 95% of total time for a file restore operation
    is consumed for executing the first sqlite3_step() statement due to
    the expensive query. Use `restore_file_checks=false` parameter with
    the following constraints:
     - The backup file contains at most one checkpoint
     - The restores are performed by doing restore in the reverse
     chronological order by which the backups are taken.
    
     Usage of restore_file_checks=false will result upto 95% faster
     online restore.
    
    Change-Id: Ia752bd38c39680f848d5a9494307a19e420338f5
    Reviewed-on: http://review.couchbase.org/12563
    Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>
    Tested-by: Chiyoung Seo <chiyoung.seo@gmail.com>
Commits on Jan 20, 2012
  1. @t3rm1n4l @chiyoung

    Add restore_checkpoint in raw restore stats

    t3rm1n4l authored chiyoung committed
    The `restore_checkpoint` stats shows the highest checkpoint id
    of the first restored backup file by starting membase in
    restore mode. `restore_checkpoint` indicates the checkpoint to
    which the membase server is restored.
    
    Change-Id: I0738a76eabce957513b37802cccf7c4b6c92251a
    Reviewed-on: http://review.couchbase.org/12503
    Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>
    Tested-by: Chiyoung Seo <chiyoung.seo@gmail.com>
Commits on Jan 11, 2012
  1. @t3rm1n4l @chiyoung

    Fix for DecrementalRestorer fails to close sqlite file descriptor

    t3rm1n4l authored chiyoung committed
    DecrementalRestorer does not use sqlite3_finalize() on sqlite
    statements after all statements are processed using sqlite3_step().
    Calling sqlite3_close() without doing a sqlite_finalize(statement)
    is causing failure in closing sqlite file descriptor. This patch
    adds sqlite3_finalize() statements before doing close().
    
    Change-Id: I39c1f28b058f5078537fcb9a228b449f2af033e6
    Reviewed-on: http://review.couchbase.org/12267
    Tested-by: Chiyoung Seo <chiyoung.seo@gmail.com>
    Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>
Commits on Dec 14, 2011
  1. @chiyoung

    Don't consider a seq number in a checkpoint in merging backup files

    chiyoung authored
    As each checkpoint only contains the list of unique keys, we don't
    need to consider their seq numbers generated from the incremental
    backup script in merging backup files.
    
    Change-Id: I00b7b47b4e3d9a2f7ba066af3cdffa0e032a25f3
    Reviewed-on: http://review.couchbase.org/11638
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Chiyoung Seo <chiyoung.seo@gmail.com>
Commits on Apr 11, 2011
  1. @trondn @chiyoung

    Use threadlocal storage to keep track of the current engine

    trondn authored chiyoung committed
    Change-Id: Id0d5de0c6f7509467f0cc4caef5de692cd9787a4
    Reviewed-on: http://review.membase.org/5306
    Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>
    Tested-by: Chiyoung Seo <chiyoung.seo@gmail.com>
Commits on Mar 29, 2011
  1. @alk @chiyoung

    fixed mis-compilation on i386

    alk authored chiyoung committed
    Change-Id: I35c4338b30ca5af715845d5d33421594e44b80e0
    Reviewed-on: http://review.membase.org/5126
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>
  2. @chiyoung @trondn

    Fix to the compilation error on online restore implementation.

    chiyoung authored trondn committed
    Change-Id: I509b8bbb963db6927fbc54d2cae02a2d942f03c0
    Reviewed-on: http://review.membase.org/5132
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
Commits on Mar 25, 2011
  1. @trondn @chiyoung

    Add support for "decremental" restore

    trondn authored chiyoung committed
    (Adding all of the incremental backups in the reverse order)
    
    Change-Id: I005c366331433703bcc0f002b37a726853692999
    Reviewed-on: http://review.membase.org/5077
    Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>
    Tested-by: Chiyoung Seo <chiyoung.seo@gmail.com>
Something went wrong with that request. Please try again.