Please sign in to comment.
Fixes breaking change introduced by (e79d072)
Summary: The problem is that e79d072 fixes odd behavior in Hackbook, which had support in the SDK code’s logout function. Prior to e79d072 Hackbook was more convoluted, and the logout behavior broke encapsulation. The solution is to put back a deprecated logout method that matches the original signature, and keeps most of the original behavior (though it does not break encapsulation, which was badness.) Test Plan: Manually modify Hackbook, and whitebox test each of the following permutations: * login with no delegate (call the cached delegate) * login with a delegate matching the cached delegate (call the cached delegate) * login with a delegate different from the cached delegate (call both) Reviewers: yariv, caabernathy, mmarucheck, vijaye Reviewed By: yariv Differential Revision: https://phabricator.fb.com/D405235 Task ID: 905137
- Loading branch information...
Showing with 21 additions and 0 deletions.