Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Fix issue causing blank white dialog when loading friends list

Summary:
Set the UIActivityIndicator color to gray to stop it from blending into the background.
On iOS5 we do this by setting the color to gray. On older iOS versions which don't support this
property, this is done by setting the style to UIActivityIndicatorViewStyleGray instead of
UIActivityIndicatorViewStyleWhiteLarge which results in a slightly smaller indicator.

Test Plan: Testing using Hackbook.

Reviewers: jacl, dgibson

Reviewed By: jacl

Differential Revision: https://phabricator.fb.com/D426894

Task ID: 908016
  • Loading branch information...
commit f6ae975fc0e627128bb2de15efbd3463144b7cea 1 parent b512d54
@suhasjoshi suhasjoshi authored
Showing with 5 additions and 0 deletions.
  1. +5 −0 src/FBDialog.m
View
5 src/FBDialog.m
@@ -367,6 +367,11 @@ - (id)init {
_spinner = [[UIActivityIndicatorView alloc] initWithActivityIndicatorStyle:
UIActivityIndicatorViewStyleWhiteLarge];
+ if ([_spinner respondsToSelector:@selector(setColor:)]) {
+ [_spinner setColor:[UIColor grayColor]];
+ } else {
+ [_spinner setActivityIndicatorViewStyle:UIActivityIndicatorViewStyleGray];
+ }
_spinner.autoresizingMask =
UIViewAutoresizingFlexibleTopMargin | UIViewAutoresizingFlexibleBottomMargin
| UIViewAutoresizingFlexibleLeftMargin | UIViewAutoresizingFlexibleRightMargin;
Please sign in to comment.
Something went wrong with that request. Please try again.